* [PATCH] x86: work around old gas bug (try 2)
@ 2011-03-03 10:55 Jan Beulich
2011-03-03 10:57 ` Ingo Molnar
2011-03-03 11:52 ` [tip:x86/mm] x86: Work around old gas bug tip-bot for Jan Beulich
0 siblings, 2 replies; 4+ messages in thread
From: Jan Beulich @ 2011-03-03 10:55 UTC (permalink / raw)
To: mingo, tglx, hpa; +Cc: Shaohua Li, akpm, linux-kernel
Add extra parentheses around a couple of definitions introduced by
"x86: Cleanup vector usage" and used in assembly macro arguments, and
remove spaces. Without that old (2.16.1) gas would see more macro
arguments than were actually specified.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Shaohua Li <shaohua.li@intel.com>
---
arch/x86/include/asm/irq_vectors.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- tip-20110303.orig/arch/x86/include/asm/irq_vectors.h
+++ tip-20110303/arch/x86/include/asm/irq_vectors.h
@@ -126,14 +126,14 @@
/* up to 32 vectors used for spreading out TLB flushes: */
#if NR_CPUS <= 32
-# define NUM_INVALIDATE_TLB_VECTORS NR_CPUS
+# define NUM_INVALIDATE_TLB_VECTORS (NR_CPUS)
#else
-# define NUM_INVALIDATE_TLB_VECTORS 32
+# define NUM_INVALIDATE_TLB_VECTORS (32)
#endif
-#define INVALIDATE_TLB_VECTOR_END 0xee
+#define INVALIDATE_TLB_VECTOR_END (0xee)
#define INVALIDATE_TLB_VECTOR_START \
- (INVALIDATE_TLB_VECTOR_END - NUM_INVALIDATE_TLB_VECTORS + 1)
+ (INVALIDATE_TLB_VECTOR_END-NUM_INVALIDATE_TLB_VECTORS+1)
#define NR_VECTORS 256
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: work around old gas bug (try 2)
2011-03-03 10:55 [PATCH] x86: work around old gas bug (try 2) Jan Beulich
@ 2011-03-03 10:57 ` Ingo Molnar
2011-03-03 11:24 ` Andrew Morton
2011-03-03 11:52 ` [tip:x86/mm] x86: Work around old gas bug tip-bot for Jan Beulich
1 sibling, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2011-03-03 10:57 UTC (permalink / raw)
To: Jan Beulich; +Cc: tglx, hpa, Shaohua Li, akpm, linux-kernel
* Jan Beulich <JBeulich@novell.com> wrote:
> Add extra parentheses around a couple of definitions introduced by
> "x86: Cleanup vector usage" and used in assembly macro arguments, and
> remove spaces. Without that old (2.16.1) gas would see more macro
> arguments than were actually specified.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Shaohua Li <shaohua.li@intel.com>
Wondering, have you managed to test this with 2.16, or should i wait for akpm's
testing before applying it?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: work around old gas bug (try 2)
2011-03-03 10:57 ` Ingo Molnar
@ 2011-03-03 11:24 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2011-03-03 11:24 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Jan Beulich, tglx, hpa, Shaohua Li, linux-kernel
On Thu, 3 Mar 2011 11:57:55 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> * Jan Beulich <JBeulich@novell.com> wrote:
>
> > Add extra parentheses around a couple of definitions introduced by
> > "x86: Cleanup vector usage" and used in assembly macro arguments, and
> > remove spaces. Without that old (2.16.1) gas would see more macro
> > arguments than were actually specified.
> >
> > Signed-off-by: Jan Beulich <jbeulich@novell.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Shaohua Li <shaohua.li@intel.com>
>
> Wondering, have you managed to test this with 2.16, or should i wait for akpm's
> testing before applying it?
>
arch/x86/kernel/entry_64.S compiles successfully with that patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/mm] x86: Work around old gas bug
2011-03-03 10:55 [PATCH] x86: work around old gas bug (try 2) Jan Beulich
2011-03-03 10:57 ` Ingo Molnar
@ 2011-03-03 11:52 ` tip-bot for Jan Beulich
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Jan Beulich @ 2011-03-03 11:52 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, shaohua.li, akpm, jbeulich, JBeulich,
tglx, mingo
Commit-ID: d04c579f971bf7d995db1ef7a7161c0143068859
Gitweb: http://git.kernel.org/tip/d04c579f971bf7d995db1ef7a7161c0143068859
Author: Jan Beulich <JBeulich@novell.com>
AuthorDate: Thu, 3 Mar 2011 10:55:29 +0000
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 3 Mar 2011 12:47:08 +0100
x86: Work around old gas bug
Add extra parentheses around a couple of definitions introduced
by "x86: Cleanup vector usage" and used in assembly macro
arguments, and remove spaces. Without that old (2.16.1) gas
would see more macro arguments than were actually specified.
Reported-and-tested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Shaohua Li <shaohua.li@intel.com>
LKML-Reference: <4D6F81B10200007800034B0B@vpn.id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/include/asm/irq_vectors.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h
index 4980f48..6e976ee 100644
--- a/arch/x86/include/asm/irq_vectors.h
+++ b/arch/x86/include/asm/irq_vectors.h
@@ -126,14 +126,14 @@
/* up to 32 vectors used for spreading out TLB flushes: */
#if NR_CPUS <= 32
-# define NUM_INVALIDATE_TLB_VECTORS NR_CPUS
+# define NUM_INVALIDATE_TLB_VECTORS (NR_CPUS)
#else
-# define NUM_INVALIDATE_TLB_VECTORS 32
+# define NUM_INVALIDATE_TLB_VECTORS (32)
#endif
-#define INVALIDATE_TLB_VECTOR_END 0xee
+#define INVALIDATE_TLB_VECTOR_END (0xee)
#define INVALIDATE_TLB_VECTOR_START \
- (INVALIDATE_TLB_VECTOR_END - NUM_INVALIDATE_TLB_VECTORS + 1)
+ (INVALIDATE_TLB_VECTOR_END-NUM_INVALIDATE_TLB_VECTORS+1)
#define NR_VECTORS 256
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-03 11:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-03 10:55 [PATCH] x86: work around old gas bug (try 2) Jan Beulich
2011-03-03 10:57 ` Ingo Molnar
2011-03-03 11:24 ` Andrew Morton
2011-03-03 11:52 ` [tip:x86/mm] x86: Work around old gas bug tip-bot for Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.