From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv1] ARM: imx: Add support for low power suspend on MX51.
Date: Thu, 3 Mar 2011 11:52:42 +0000 [thread overview]
Message-ID: <20110303115242.GA25891@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110302215238.GK22310@pengutronix.de>
On Wed, Mar 02, 2011 at 10:52:38PM +0100, Uwe Kleine-K?nig wrote:
> > +static int __init mx5_pm_init(void)
> > +{
> > + if (cpu_is_mx51())
> > + suspend_set_ops(&mx5_suspend_ops);
> I'd prefer to have that called by imx51_init_early.
This function name looks fine. As we now have an init_early in the
arch hooks, let's keep things called foo_init_early() to that use
and not start using 'early' for stuff used from initcalls.
Renaming this is a recipe for causing confusion and having grep hit
false positives. Please leave it as is.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dinh.Nguyen@freescale.com, linux-kernel@vger.kernel.org,
s.hauer@pengutronix.de, xiao-lizhang@freescale.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv1] ARM: imx: Add support for low power suspend on MX51.
Date: Thu, 3 Mar 2011 11:52:42 +0000 [thread overview]
Message-ID: <20110303115242.GA25891@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110302215238.GK22310@pengutronix.de>
On Wed, Mar 02, 2011 at 10:52:38PM +0100, Uwe Kleine-König wrote:
> > +static int __init mx5_pm_init(void)
> > +{
> > + if (cpu_is_mx51())
> > + suspend_set_ops(&mx5_suspend_ops);
> I'd prefer to have that called by imx51_init_early.
This function name looks fine. As we now have an init_early in the
arch hooks, let's keep things called foo_init_early() to that use
and not start using 'early' for stuff used from initcalls.
Renaming this is a recipe for causing confusion and having grep hit
false positives. Please leave it as is.
next prev parent reply other threads:[~2011-03-03 11:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 17:17 [PATCHv1] ARM: imx: Add support for low power suspend on MX51 Dinh.Nguyen at freescale.com
2011-03-02 17:17 ` Dinh.Nguyen
2011-03-02 19:35 ` Arnaud Patard (Rtp)
2011-03-02 19:35 ` Arnaud Patard
2011-03-02 19:41 ` Nguyen Dinh-R00091
2011-03-02 19:41 ` Nguyen Dinh-R00091
2011-03-02 21:52 ` Uwe Kleine-König
2011-03-02 21:52 ` Uwe Kleine-König
2011-03-02 23:51 ` Thomas Gleixner
2011-03-02 23:51 ` Thomas Gleixner
2011-03-03 9:35 ` Uwe Kleine-König
2011-03-03 9:35 ` Uwe Kleine-König
2011-03-03 11:02 ` Thomas Gleixner
2011-03-03 11:02 ` Thomas Gleixner
2011-03-03 11:49 ` Uwe Kleine-König
2011-03-03 11:49 ` Uwe Kleine-König
2011-03-03 11:52 ` Russell King - ARM Linux [this message]
2011-03-03 11:52 ` Russell King - ARM Linux
2011-03-03 12:46 ` Uwe Kleine-König
2011-03-03 12:46 ` Uwe Kleine-König
2011-03-03 13:45 ` Russell King - ARM Linux
2011-03-03 13:45 ` Russell King - ARM Linux
2011-03-03 20:15 ` Uwe Kleine-König
2011-03-03 20:15 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303115242.GA25891@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.