* Re: [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses
2011-03-04 15:09 [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses sysfs Guenter Roeck
@ 2011-03-04 18:41 ` Jean Delvare
2011-03-04 19:17 ` Guenter Roeck
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2011-03-04 18:41 UTC (permalink / raw)
To: lm-sensors
On Fri, 4 Mar 2011 07:09:46 -0800, Guenter Roeck wrote:
> This patch adds support for the fanX_pulses sysfs attribute.
>
> --
> Index: lib/sensors.h
> =================================> --- lib/sensors.h (revision 5937)
> +++ lib/sensors.h (working copy)
> @@ -170,6 +170,7 @@
> SENSORS_SUBFEATURE_FAN_FAULT,
> SENSORS_SUBFEATURE_FAN_DIV,
> SENSORS_SUBFEATURE_FAN_BEEP,
> + SENSORS_SUBFEATURE_FAN_PULSES,
>
> SENSORS_SUBFEATURE_TEMP_INPUT = SENSORS_FEATURE_TEMP << 8,
> SENSORS_SUBFEATURE_TEMP_MAX,
> Index: lib/sysfs.c
> =================================> --- lib/sysfs.c (revision 5937)
> +++ lib/sysfs.c (working copy)
> @@ -265,6 +265,7 @@
> { "input", SENSORS_SUBFEATURE_FAN_INPUT },
> { "min", SENSORS_SUBFEATURE_FAN_MIN },
> { "div", SENSORS_SUBFEATURE_FAN_DIV },
> + { "pulses", SENSORS_SUBFEATURE_FAN_PULSES },
> { "alarm", SENSORS_SUBFEATURE_FAN_ALARM },
> { "fault", SENSORS_SUBFEATURE_FAN_FAULT },
> { "beep", SENSORS_SUBFEATURE_FAN_BEEP },
>
Looks good. Please don't forget to update doc/libsensors-API.txt and
CHANGES too.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses
2011-03-04 15:09 [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses sysfs Guenter Roeck
2011-03-04 18:41 ` [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses Jean Delvare
@ 2011-03-04 19:17 ` Guenter Roeck
2011-03-04 20:31 ` Jean Delvare
2011-03-04 20:40 ` Guenter Roeck
3 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2011-03-04 19:17 UTC (permalink / raw)
To: lm-sensors
On Fri, 2011-03-04 at 13:41 -0500, Jean Delvare wrote:
> On Fri, 4 Mar 2011 07:09:46 -0800, Guenter Roeck wrote:
> > This patch adds support for the fanX_pulses sysfs attribute.
> >
> > --
> > Index: lib/sensors.h
> > =================================> > --- lib/sensors.h (revision 5937)
> > +++ lib/sensors.h (working copy)
> > @@ -170,6 +170,7 @@
> > SENSORS_SUBFEATURE_FAN_FAULT,
> > SENSORS_SUBFEATURE_FAN_DIV,
> > SENSORS_SUBFEATURE_FAN_BEEP,
> > + SENSORS_SUBFEATURE_FAN_PULSES,
> >
> > SENSORS_SUBFEATURE_TEMP_INPUT = SENSORS_FEATURE_TEMP << 8,
> > SENSORS_SUBFEATURE_TEMP_MAX,
> > Index: lib/sysfs.c
> > =================================> > --- lib/sysfs.c (revision 5937)
> > +++ lib/sysfs.c (working copy)
> > @@ -265,6 +265,7 @@
> > { "input", SENSORS_SUBFEATURE_FAN_INPUT },
> > { "min", SENSORS_SUBFEATURE_FAN_MIN },
> > { "div", SENSORS_SUBFEATURE_FAN_DIV },
> > + { "pulses", SENSORS_SUBFEATURE_FAN_PULSES },
> > { "alarm", SENSORS_SUBFEATURE_FAN_ALARM },
> > { "fault", SENSORS_SUBFEATURE_FAN_FAULT },
> > { "beep", SENSORS_SUBFEATURE_FAN_BEEP },
> >
>
> Looks good. Please don't forget to update doc/libsensors-API.txt and
> CHANGES too.
>
Do you want to include the new attribute in the upcoming version of the
sensors code ?
Reason for asking is that I plan to commit the sysfs ABI changes into
2.6.39, so the attribute won't be documented yet if you release a new
version of the sensors code this weekend (ie prior to the Linux merge
window).
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses
2011-03-04 15:09 [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses sysfs Guenter Roeck
2011-03-04 18:41 ` [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses Jean Delvare
2011-03-04 19:17 ` Guenter Roeck
@ 2011-03-04 20:31 ` Jean Delvare
2011-03-04 20:40 ` Guenter Roeck
3 siblings, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2011-03-04 20:31 UTC (permalink / raw)
To: lm-sensors
On Fri, 4 Mar 2011 11:17:24 -0800, Guenter Roeck wrote:
> On Fri, 2011-03-04 at 13:41 -0500, Jean Delvare wrote:
> > On Fri, 4 Mar 2011 07:09:46 -0800, Guenter Roeck wrote:
> > > This patch adds support for the fanX_pulses sysfs attribute.
> > >
> > > --
> > > Index: lib/sensors.h
> > > =================================> > > --- lib/sensors.h (revision 5937)
> > > +++ lib/sensors.h (working copy)
> > > @@ -170,6 +170,7 @@
> > > SENSORS_SUBFEATURE_FAN_FAULT,
> > > SENSORS_SUBFEATURE_FAN_DIV,
> > > SENSORS_SUBFEATURE_FAN_BEEP,
> > > + SENSORS_SUBFEATURE_FAN_PULSES,
> > >
> > > SENSORS_SUBFEATURE_TEMP_INPUT = SENSORS_FEATURE_TEMP << 8,
> > > SENSORS_SUBFEATURE_TEMP_MAX,
> > > Index: lib/sysfs.c
> > > =================================> > > --- lib/sysfs.c (revision 5937)
> > > +++ lib/sysfs.c (working copy)
> > > @@ -265,6 +265,7 @@
> > > { "input", SENSORS_SUBFEATURE_FAN_INPUT },
> > > { "min", SENSORS_SUBFEATURE_FAN_MIN },
> > > { "div", SENSORS_SUBFEATURE_FAN_DIV },
> > > + { "pulses", SENSORS_SUBFEATURE_FAN_PULSES },
> > > { "alarm", SENSORS_SUBFEATURE_FAN_ALARM },
> > > { "fault", SENSORS_SUBFEATURE_FAN_FAULT },
> > > { "beep", SENSORS_SUBFEATURE_FAN_BEEP },
> > >
> >
> > Looks good. Please don't forget to update doc/libsensors-API.txt and
> > CHANGES too.
> >
> Do you want to include the new attribute in the upcoming version of the
> sensors code ?
I don't think you need any change to the sensors program itself.
> Reason for asking is that I plan to commit the sysfs ABI changes into
> 2.6.39, so the attribute won't be documented yet if you release a new
> version of the sensors code this weekend (ie prior to the Linux merge
> window).
I don't have any problem with this. There is always some latency in one
direction or another, the kernel and libsensors can't be in perfect
sync all the time.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses
2011-03-04 15:09 [lm-sensors] [PATCH] libsensors: Add support for fanX_pulses sysfs Guenter Roeck
` (2 preceding siblings ...)
2011-03-04 20:31 ` Jean Delvare
@ 2011-03-04 20:40 ` Guenter Roeck
3 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2011-03-04 20:40 UTC (permalink / raw)
To: lm-sensors
On Fri, 2011-03-04 at 15:31 -0500, Jean Delvare wrote:
> On Fri, 4 Mar 2011 11:17:24 -0800, Guenter Roeck wrote:
> > On Fri, 2011-03-04 at 13:41 -0500, Jean Delvare wrote:
> > > On Fri, 4 Mar 2011 07:09:46 -0800, Guenter Roeck wrote:
> > > > This patch adds support for the fanX_pulses sysfs attribute.
> > > >
> > > > --
> > > > Index: lib/sensors.h
> > > > =================================> > > > --- lib/sensors.h (revision 5937)
> > > > +++ lib/sensors.h (working copy)
> > > > @@ -170,6 +170,7 @@
> > > > SENSORS_SUBFEATURE_FAN_FAULT,
> > > > SENSORS_SUBFEATURE_FAN_DIV,
> > > > SENSORS_SUBFEATURE_FAN_BEEP,
> > > > + SENSORS_SUBFEATURE_FAN_PULSES,
> > > >
> > > > SENSORS_SUBFEATURE_TEMP_INPUT = SENSORS_FEATURE_TEMP << 8,
> > > > SENSORS_SUBFEATURE_TEMP_MAX,
> > > > Index: lib/sysfs.c
> > > > =================================> > > > --- lib/sysfs.c (revision 5937)
> > > > +++ lib/sysfs.c (working copy)
> > > > @@ -265,6 +265,7 @@
> > > > { "input", SENSORS_SUBFEATURE_FAN_INPUT },
> > > > { "min", SENSORS_SUBFEATURE_FAN_MIN },
> > > > { "div", SENSORS_SUBFEATURE_FAN_DIV },
> > > > + { "pulses", SENSORS_SUBFEATURE_FAN_PULSES },
> > > > { "alarm", SENSORS_SUBFEATURE_FAN_ALARM },
> > > > { "fault", SENSORS_SUBFEATURE_FAN_FAULT },
> > > > { "beep", SENSORS_SUBFEATURE_FAN_BEEP },
> > > >
> > >
> > > Looks good. Please don't forget to update doc/libsensors-API.txt and
> > > CHANGES too.
> > >
> > Do you want to include the new attribute in the upcoming version of the
> > sensors code ?
>
> I don't think you need any change to the sensors program itself.
>
Sorry, I meant libsensors, assuming the new version will include both
the sensors command and libsensors.
> > Reason for asking is that I plan to commit the sysfs ABI changes into
> > 2.6.39, so the attribute won't be documented yet if you release a new
> > version of the sensors code this weekend (ie prior to the Linux merge
> > window).
>
> I don't have any problem with this. There is always some latency in one
> direction or another, the kernel and libsensors can't be in perfect
> sync all the time.
>
Ok, committed with updated doc/libsensors-API.txt. CHANGES already says
"Add support for new sysfs attributes" which I guess covers this one as
well.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 5+ messages in thread