From: Pavel Machek <pavel@ucw.cz>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: linux-kernel@vger.kernel.org, security@kernel.org,
Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH] power: disable hibernation if module loading is disabled
Date: Fri, 4 Mar 2011 21:32:02 +0100 [thread overview]
Message-ID: <20110304203201.GA22079@elf.ucw.cz> (raw)
In-Reply-To: <1299255084-4390-1-git-send-email-segoon@openwall.com>
On Fri 2011-03-04 19:11:24, Vasiliy Kulikov wrote:
> If /proc/sys/kernel/modules_disabled is set to 1, then nobody (even full
> root) may not read/write arbitrary kernel memory. In spite of it,
> hibernation allows anyone with an access to either /dev/snapshot or
> /sys/power/ make the full snapshot of the system. This snapshot may be
> freely changed and uploaded back.
module loading has nothing to do with hibernation, and hibernation
already checks for CAP_ADMIN or something similary strong. I don't see
why this new check is needed.
In fact, you are probably breaking someone's setup right now.
> + if (modules_disabled)
> + return -EPERM;
> +
> error = platform_begin(platform_mode);
Hmm. How is this supposed to work with CONFIG_MODULES off?
NAK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2011-03-04 20:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 16:11 [PATCH] power: disable hibernation if module loading is disabled Vasiliy Kulikov
2011-03-04 18:43 ` Kees Cook
2011-03-04 18:43 ` Kees Cook
2011-03-04 20:48 ` Rafael J. Wysocki
2011-03-04 20:48 ` Rafael J. Wysocki
2011-03-04 20:32 ` Pavel Machek [this message]
2011-03-04 21:52 ` Vasiliy Kulikov
2011-03-04 21:52 ` Vasiliy Kulikov
2011-03-04 20:32 ` Pavel Machek
2011-03-04 20:42 ` Rafael J. Wysocki
2011-03-04 20:42 ` Rafael J. Wysocki
2011-03-04 21:10 ` Vasiliy Kulikov
2011-03-04 21:10 ` Vasiliy Kulikov
2011-03-04 21:21 ` Rafael J. Wysocki
2011-03-04 21:21 ` Rafael J. Wysocki
2011-03-04 21:46 ` Vasiliy Kulikov
2011-03-04 21:46 ` Vasiliy Kulikov
2011-03-04 22:30 ` Rafael J. Wysocki
2011-03-04 22:30 ` Rafael J. Wysocki
2011-03-04 22:42 ` Pavel Machek
2011-03-04 22:42 ` Pavel Machek
2011-03-05 10:34 ` Vasiliy Kulikov
2011-03-05 11:24 ` Rafael J. Wysocki
2011-03-08 6:58 ` Pavel Machek
2011-03-08 6:58 ` Pavel Machek
2011-03-05 11:24 ` Rafael J. Wysocki
2011-03-05 10:34 ` Vasiliy Kulikov
2011-03-04 21:27 ` [Security] " Greg KH
2011-03-04 21:51 ` Vasiliy Kulikov
2011-03-04 21:51 ` Vasiliy Kulikov
2011-03-04 21:27 ` Greg KH
2011-03-06 19:36 ` david
2011-03-06 19:36 ` david
-- strict thread matches above, loose matches on Subject: below --
2011-03-04 16:11 Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304203201.GA22079@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=security@kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.