From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: linux-kernel@vger.kernel.org, security@kernel.org,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH] power: disable hibernation if module loading is disabled
Date: Sat, 5 Mar 2011 12:24:18 +0100 [thread overview]
Message-ID: <201103051224.18621.rjw@sisk.pl> (raw)
In-Reply-To: <20110305103444.GA26773@albatros>
On Saturday, March 05, 2011, Vasiliy Kulikov wrote:
> On Fri, Mar 04, 2011 at 23:30 +0100, Rafael J. Wysocki wrote:
> > modules_disabled surely is not the right interface to disable hibernation
> > and I don't really think there's a bug because it doesn't work as you'd like
> > it to. In fact, there would be a bug if it did work that way.
>
> What do you mean here? Do you agree that you may read kernel image,
> slightly change it (including e.g. possible checksums, I didn't bother
> to check how much one should change), and write it back?
Yes, you can, but that's not the point. The point is that calling an interface
that disables all possible functionality modifying kernel memory
"modules_disabled" is completely dumb. Sorry, but that's how it goes.
As I said before, if you want to have such an interface, call it properly
and introduce it along with documentation instead of changing an existing
one in a backwards-incopmatible fashion that in addition is totally
confusing.
Moreover, how are you going to protect your "protect kernel memory from
modification" interface itself from root access?
next prev parent reply other threads:[~2011-03-05 11:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 16:11 [PATCH] power: disable hibernation if module loading is disabled Vasiliy Kulikov
2011-03-04 18:43 ` Kees Cook
2011-03-04 20:48 ` Rafael J. Wysocki
2011-03-04 20:48 ` Rafael J. Wysocki
2011-03-04 18:43 ` Kees Cook
2011-03-04 20:32 ` Pavel Machek
2011-03-04 21:52 ` Vasiliy Kulikov
2011-03-04 21:52 ` Vasiliy Kulikov
2011-03-04 20:32 ` Pavel Machek
2011-03-04 20:42 ` Rafael J. Wysocki
2011-03-04 21:10 ` Vasiliy Kulikov
2011-03-04 21:21 ` Rafael J. Wysocki
2011-03-04 21:21 ` Rafael J. Wysocki
2011-03-04 21:46 ` Vasiliy Kulikov
2011-03-04 21:46 ` Vasiliy Kulikov
2011-03-04 22:30 ` Rafael J. Wysocki
2011-03-04 22:30 ` Rafael J. Wysocki
2011-03-04 22:42 ` Pavel Machek
2011-03-04 22:42 ` Pavel Machek
2011-03-05 10:34 ` Vasiliy Kulikov
2011-03-05 11:24 ` Rafael J. Wysocki
2011-03-05 11:24 ` Rafael J. Wysocki [this message]
2011-03-08 6:58 ` Pavel Machek
2011-03-08 6:58 ` Pavel Machek
2011-03-05 10:34 ` Vasiliy Kulikov
2011-03-04 21:10 ` Vasiliy Kulikov
2011-03-04 20:42 ` Rafael J. Wysocki
2011-03-04 21:27 ` [Security] " Greg KH
2011-03-04 21:51 ` Vasiliy Kulikov
2011-03-04 21:51 ` Vasiliy Kulikov
2011-03-04 21:27 ` Greg KH
2011-03-06 19:36 ` david
2011-03-06 19:36 ` david
-- strict thread matches above, loose matches on Subject: below --
2011-03-04 16:11 Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103051224.18621.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=security@kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.