From: Stephen Hemminger <shemminger@vyatta.com>
To: Adam Majer <adamm@zombino.com>
Cc: "Pekka Savola (ipv6)" <pekkas@netcore.fi>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
James Morris <jmorris@namei.org>,
Stephen Hemminger <stephen.hemminger@vyatta.com>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state
Date: Sun, 6 Mar 2011 09:45:41 -0800 [thread overview]
Message-ID: <20110306094541.53390b55@nehalam> (raw)
In-Reply-To: <20110306080328.GA3850@mira.lan.galacticasoftware.com>
On Sun, 6 Mar 2011 02:03:28 -0600
Adam Majer <adamm@zombino.com> wrote:
> On Sat, Mar 05, 2011 at 10:43:03PM -0800, Stephen Hemminger wrote:
> > Why not set forwarding delay to zero? I don't think you are using STP?
> >
> > P.s: removing linux-kernel mailing list, since there is no point
> > in copying the whole world on this thread.
>
> I just sent patches where MAINTAINERS file told me to send it. ;)
>
> No, I'm not relying on STP. I think setting learning->forwarding delay
> to 0 could cause problems with STP like loops until the loop is
> detected.
>
> There may be a better spot where to insert the notification that the
> bridge is forwarding data, though I'm not exactly certain where. The
> patch will cause bridge to issue NETDEV_CHANGE notification for all
> topology changes. This may or may not be useful but shouldn't be
> harmful (I can't imagine these occur very often?) The IPv6 autoconf
> patch will only act on this if it doesn't have IPv6 address configured
> manually or via autoconf.
>
Since this a generic problem, it needs a better solution.
Sending NETDEV_CHANGE impacts lots of other pieces, and even
user space has similar problems.
--
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: Adam Majer <adamm@zombino.com>
Cc: Stephen Hemminger <stephen.hemminger@vyatta.com>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state
Date: Sun, 6 Mar 2011 09:45:41 -0800 [thread overview]
Message-ID: <20110306094541.53390b55@nehalam> (raw)
In-Reply-To: <20110306080328.GA3850@mira.lan.galacticasoftware.com>
On Sun, 6 Mar 2011 02:03:28 -0600
Adam Majer <adamm@zombino.com> wrote:
> On Sat, Mar 05, 2011 at 10:43:03PM -0800, Stephen Hemminger wrote:
> > Why not set forwarding delay to zero? I don't think you are using STP?
> >
> > P.s: removing linux-kernel mailing list, since there is no point
> > in copying the whole world on this thread.
>
> I just sent patches where MAINTAINERS file told me to send it. ;)
>
> No, I'm not relying on STP. I think setting learning->forwarding delay
> to 0 could cause problems with STP like loops until the loop is
> detected.
>
> There may be a better spot where to insert the notification that the
> bridge is forwarding data, though I'm not exactly certain where. The
> patch will cause bridge to issue NETDEV_CHANGE notification for all
> topology changes. This may or may not be useful but shouldn't be
> harmful (I can't imagine these occur very often?) The IPv6 autoconf
> patch will only act on this if it doesn't have IPv6 address configured
> manually or via autoconf.
>
Since this a generic problem, it needs a better solution.
Sending NETDEV_CHANGE impacts lots of other pieces, and even
user space has similar problems.
--
next prev parent reply other threads:[~2011-03-06 17:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 5:18 [Bridge] [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state Adam Majer
2011-03-06 5:18 ` Adam Majer
2011-03-06 5:20 ` [Bridge] [PATCH 2/2] Retry autoconfiguration on interface after NETDEV_CHANGE notification Adam Majer
2011-03-06 5:20 ` Adam Majer
2011-03-06 5:31 ` [Bridge] [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state Adam Majer
2011-03-06 5:31 ` Adam Majer
2011-03-06 6:43 ` [Bridge] " Stephen Hemminger
2011-03-06 6:43 ` Stephen Hemminger
2011-03-06 8:03 ` [Bridge] " Adam Majer
2011-03-06 8:03 ` Adam Majer
2011-03-06 17:45 ` Stephen Hemminger [this message]
2011-03-06 17:45 ` Stephen Hemminger
2011-03-07 0:25 ` [Bridge] " Adam Majer
2011-03-07 0:25 ` Adam Majer
2011-03-07 6:41 ` [Bridge] " Stephen Hemminger
2011-03-07 6:41 ` Stephen Hemminger
2011-03-07 7:44 ` [Bridge] " Nicolas de Pesloüan
2011-03-07 7:44 ` Nicolas de Pesloüan
2011-03-07 18:34 ` [Bridge] [PATCH] bridge: control carrier based on ports online Stephen Hemminger
2011-03-07 18:34 ` Stephen Hemminger
2011-03-07 20:48 ` [Bridge] " Nicolas de Pesloüan
2011-03-07 20:48 ` Nicolas de Pesloüan
2011-03-07 21:44 ` [Bridge] " Stephen Hemminger
2011-03-07 21:44 ` Stephen Hemminger
2011-03-07 21:51 ` [Bridge] " Nicolas de Pesloüan
2011-03-07 21:51 ` Nicolas de Pesloüan
2011-03-08 1:08 ` [Bridge] " Adam Majer
2011-03-08 1:08 ` Adam Majer
2011-03-14 21:29 ` [Bridge] " David Miller
2011-03-14 21:29 ` David Miller
2011-03-06 18:01 ` [Bridge] [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state Jan Ceuleers
2011-03-06 18:01 ` Jan Ceuleers
2011-03-09 15:09 ` [Bridge] " Américo Wang
2011-03-09 15:09 ` Américo Wang
2011-03-09 16:44 ` [Bridge] " Adam Majer
2011-03-09 16:44 ` Adam Majer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110306094541.53390b55@nehalam \
--to=shemminger@vyatta.com \
--cc=adamm@zombino.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=stephen.hemminger@vyatta.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.