All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Chen Gong <gong.chen@linux.intel.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>, Clark Williams <williams@redhat.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH] page-types.c: add a new argument of debugfs path
Date: Mon, 7 Mar 2011 19:39:37 +0800	[thread overview]
Message-ID: <20110307113937.GB5080@localhost> (raw)
In-Reply-To: <20110307184133.8A19.A69D9226@jp.fujitsu.com>

On Mon, Mar 07, 2011 at 05:42:39PM +0800, KOSAKI Motohiro wrote:
> > page-types.c doesn't supply a way to specify the debugfs path and
> > the original debugfs path is not usual on most machines. Add a
> > new argument to set the debugfs path easily.
> > 
> > Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
> 
> Hi
> 
> Why do we need to set debugfs path manually? Instead I'd suggested to
> read /proc/mount and detect it automatically.

Good idea! And could reuse tools/perf/util/debugfs.c for finding out
and even audo-mounting debugfs. 

Thanks,
Fengguang

WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Chen Gong <gong.chen@linux.intel.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>, Clark Williams <williams@redhat.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH] page-types.c: add a new argument of debugfs path
Date: Mon, 7 Mar 2011 19:39:37 +0800	[thread overview]
Message-ID: <20110307113937.GB5080@localhost> (raw)
In-Reply-To: <20110307184133.8A19.A69D9226@jp.fujitsu.com>

On Mon, Mar 07, 2011 at 05:42:39PM +0800, KOSAKI Motohiro wrote:
> > page-types.c doesn't supply a way to specify the debugfs path and
> > the original debugfs path is not usual on most machines. Add a
> > new argument to set the debugfs path easily.
> > 
> > Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
> 
> Hi
> 
> Why do we need to set debugfs path manually? Instead I'd suggested to
> read /proc/mount and detect it automatically.

Good idea! And could reuse tools/perf/util/debugfs.c for finding out
and even audo-mounting debugfs. 

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-03-07 11:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07  8:51 [PATCH] page-types.c: add a new argument of debugfs path Chen Gong
2011-03-07  8:51 ` Chen Gong
2011-03-07  9:42 ` KOSAKI Motohiro
2011-03-07  9:42   ` KOSAKI Motohiro
2011-03-07 11:39   ` Wu Fengguang [this message]
2011-03-07 11:39     ` Wu Fengguang
2011-03-08  5:01     ` [PATCH V2] page-types.c: auto debugfs mount for hwpoison operation Chen Gong
2011-03-08  5:01       ` Chen Gong
2011-03-08  6:08       ` KOSAKI Motohiro
2011-03-08  6:08         ` KOSAKI Motohiro
2011-03-08  7:27       ` Wu Fengguang
2011-03-08  7:27         ` Wu Fengguang
2011-03-12  0:29       ` Andrew Morton
2011-03-12  0:29         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110307113937.GB5080@localhost \
    --to=fengguang.wu@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=gong.chen@linux.intel.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=williams@redhat.com \
    --cc=xiaoguangrong@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.