From: Greg KH <greg@kroah.com>
To: Narendra_K@Dell.com
Cc: a.beregalov@gmail.com, linux-next@vger.kernel.org,
jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org,
linux-hotplug@vger.kernel.org, netdev@vger.kernel.org,
mjg@redhat.com, Matt_Domsch@Dell.com, Charles_Rose@Dell.com,
Jordan_Hargrave@Dell.com, Shyam_Iyer@Dell.com,
sfr@canb.auug.org.au
Subject: Re: [PATCH V4] Export ACPI _DSM provided firmware instance number
Date: Mon, 07 Mar 2011 19:56:16 +0000 [thread overview]
Message-ID: <20110307195616.GA14888@kroah.com> (raw)
In-Reply-To: <20110307200512.GA22450@fedora14-r610.oslab.blr.amer.dell.com>
On Mon, Mar 07, 2011 at 11:44:52AM -0800, Narendra_K@Dell.com wrote:
> --- a/drivers/pci/pci-label.c
> +++ b/drivers/pci/pci-label.c
> @@ -29,7 +29,9 @@
> #include <linux/nls.h>
> #include <linux/acpi.h>
> #include <linux/pci-acpi.h>
> +#ifdef CONFIG_ACPI
> #include <acpi/acpi_drivers.h>
> +#endif
You should never need a #ifdef in a .c file for an include file. If so,
something is really wrong.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Narendra_K@Dell.com
Cc: a.beregalov@gmail.com, linux-next@vger.kernel.org,
jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org,
linux-hotplug@vger.kernel.org, netdev@vger.kernel.org,
mjg@redhat.com, Matt_Domsch@Dell.com, Charles_Rose@Dell.com,
Jordan_Hargrave@Dell.com, Shyam_Iyer@Dell.com,
sfr@canb.auug.org.au
Subject: Re: [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs
Date: Mon, 7 Mar 2011 11:56:16 -0800 [thread overview]
Message-ID: <20110307195616.GA14888@kroah.com> (raw)
In-Reply-To: <20110307200512.GA22450@fedora14-r610.oslab.blr.amer.dell.com>
On Mon, Mar 07, 2011 at 11:44:52AM -0800, Narendra_K@Dell.com wrote:
> --- a/drivers/pci/pci-label.c
> +++ b/drivers/pci/pci-label.c
> @@ -29,7 +29,9 @@
> #include <linux/nls.h>
> #include <linux/acpi.h>
> #include <linux/pci-acpi.h>
> +#ifdef CONFIG_ACPI
> #include <acpi/acpi_drivers.h>
> +#endif
You should never need a #ifdef in a .c file for an include file. If so,
something is really wrong.
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-07 19:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 12:36 [PATCH V3] Export ACPI _DSM provided firmware instance number and string name to sysfs Narendra_K
2011-02-23 12:48 ` [PATCH V3] Export ACPI _DSM provided firmware instance number and Narendra_K
2011-02-23 12:44 ` [PATCH V3] Export ACPI _DSM provided firmware instance number Matthew Garrett
2011-02-23 12:44 ` [PATCH V3] Export ACPI _DSM provided firmware instance number and string name to sysfs Matthew Garrett
2011-02-23 13:00 ` Narendra_K
2011-02-23 13:12 ` [PATCH V3] Export ACPI _DSM provided firmware instance number Narendra_K
2011-03-20 10:15 ` [PATCH V3] Export ACPI _DSM provided firmware instance number and Alexander Beregalov
2011-03-20 10:15 ` [PATCH V3] Export ACPI _DSM provided firmware instance number and string name to sysfs Alexander Beregalov
2011-03-21 15:30 ` [PATCH V3] Export ACPI _DSM provided firmware instance number Narendra_K
2011-03-21 15:30 ` [PATCH V3] Export ACPI _DSM provided firmware instance number and string name to sysfs Narendra_K
2011-03-02 17:04 ` [PATCH V4] " Narendra_K
2011-03-02 17:16 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and Narendra_K
2011-03-04 16:28 ` [PATCH V4] Export ACPI _DSM provided firmware instance number Narendra_K
2011-03-04 16:28 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Narendra_K
2011-03-04 18:38 ` [PATCH V4] Export ACPI _DSM provided firmware instance number Jesse Barnes
2011-03-04 18:38 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Jesse Barnes
2011-03-04 18:43 ` [PATCH V4] Export ACPI _DSM provided firmware instance number Jesse Barnes
2011-03-04 18:43 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Jesse Barnes
2011-03-07 18:04 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and Alexander Beregalov
2011-03-07 18:04 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Alexander Beregalov
2011-03-07 19:44 ` [PATCH V4] Export ACPI _DSM provided firmware instance number Narendra_K
2011-03-07 19:44 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Narendra_K
2011-03-07 19:44 ` Narendra_K
2011-03-07 19:56 ` Greg KH [this message]
2011-03-07 19:56 ` Greg KH
2011-03-07 20:55 ` [PATCH V4] Export ACPI _DSM provided firmware instance number Narendra_K
2011-03-07 20:55 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Narendra_K
2011-03-07 20:55 ` Narendra_K
2011-03-10 22:05 ` Shyam_Iyer
2011-03-10 22:17 ` [PATCH V4] Export ACPI _DSM provided firmware instance number Shyam_Iyer
2011-03-10 22:05 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Shyam_Iyer
2011-03-16 17:41 ` [PATCH V4] Export ACPI _DSM provided firmware instance number Jesse Barnes
2011-03-16 17:41 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Jesse Barnes
2011-03-16 17:41 ` Jesse Barnes
2011-03-10 0:35 ` [PATCH V4] Export ACPI _DSM provided firmware instance number Jordan_Hargrave
2011-03-10 0:35 ` [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Jordan_Hargrave
2011-03-10 0:35 ` Jordan_Hargrave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307195616.GA14888@kroah.com \
--to=greg@kroah.com \
--cc=Charles_Rose@Dell.com \
--cc=Jordan_Hargrave@Dell.com \
--cc=Matt_Domsch@Dell.com \
--cc=Narendra_K@Dell.com \
--cc=Shyam_Iyer@Dell.com \
--cc=a.beregalov@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.