* [patch resend] V4L/DVB: tm6000: remove unneeded NULL check
@ 2011-03-07 21:13 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2011-03-07 21:13 UTC (permalink / raw)
To: kernel-janitors
We're testing the wrong variable here, and anyway list_entry() never
returns NULL. We already verified that the list is not empty.
This was added by: 721f507b694f "V4L/DVB (12842): tm6000: avoid kernel
panic while retrieving the filling buffer"
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
index b550340..e1c6ec8 100644
--- a/drivers/staging/tm6000/tm6000-video.c
+++ b/drivers/staging/tm6000/tm6000-video.c
@@ -179,9 +179,6 @@ static inline void get_next_buf(struct tm6000_dmaqueue *dma_q,
*buf = list_entry(dma_q->active.next,
struct tm6000_buffer, vb.queue);
- if (!buf)
- return;
-
/* Cleans up buffer - Usefull for testing for frame/URB loss */
outp = videobuf_to_vmalloc(&(*buf)->vb);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-03-07 21:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-07 21:13 [patch resend] V4L/DVB: tm6000: remove unneeded NULL check Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.