From: Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Minkyu Kang <mk7.kang-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH v3] misc: adds support the FSA9480 USB Switch
Date: Tue, 8 Mar 2011 16:02:27 -0500 [thread overview]
Message-ID: <20110308210227.GA12804@redhat.com> (raw)
In-Reply-To: <4D75D338.9070801-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On Tue, Mar 08, 2011 at 03:56:56PM +0900, Minkyu Kang wrote:
> +static DEVICE_ATTR(switch, S_IRUGO | S_IWUGO,
> + fsa9480_show_manualsw, fsa9480_set_manualsw);
This probably shouldn't be world writable if it's writing to hardware.
Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Minkyu Kang <mk7.kang@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>,
kyungmin.park@samsung.com, Ben Dooks <ben-i2c@fluff.org>
Subject: Re: [PATCH v3] misc: adds support the FSA9480 USB Switch
Date: Tue, 8 Mar 2011 16:02:27 -0500 [thread overview]
Message-ID: <20110308210227.GA12804@redhat.com> (raw)
In-Reply-To: <4D75D338.9070801@samsung.com>
On Tue, Mar 08, 2011 at 03:56:56PM +0900, Minkyu Kang wrote:
> +static DEVICE_ATTR(switch, S_IRUGO | S_IWUGO,
> + fsa9480_show_manualsw, fsa9480_set_manualsw);
This probably shouldn't be world writable if it's writing to hardware.
Dave
next prev parent reply other threads:[~2011-03-08 21:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 6:56 [PATCH v3] misc: adds support the FSA9480 USB Switch Minkyu Kang
[not found] ` <4D75D338.9070801-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2011-03-08 13:59 ` Greg KH
2011-03-08 13:59 ` Greg KH
[not found] ` <20110308135909.GA7519-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2011-03-08 23:59 ` Minkyu Kang
2011-03-08 23:59 ` Minkyu Kang
[not found] ` <AANLkTi=cgOJK=xGpbM8zaTVHcF+ZzjTCds+6dw3zAN_P-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-09 0:09 ` Greg KH
2011-03-09 0:09 ` Greg KH
[not found] ` <20110309000932.GA12470-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2011-03-09 0:41 ` Minkyu Kang
2011-03-09 0:41 ` Minkyu Kang
[not found] ` <AANLkTikvCvkSdOCTGVT_C7sWemzG8g_+fsSy_PQkwCfO-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-09 8:34 ` [PATCH v4] " Minkyu Kang
2011-03-09 8:34 ` Minkyu Kang
2011-06-29 10:14 ` [PATCH v5] " Donggeun Kim
2011-06-29 11:34 ` anish singh
2011-06-29 19:55 ` Andrew Morton
2011-03-08 21:02 ` Dave Jones [this message]
2011-03-08 21:02 ` [PATCH v3] " Dave Jones
[not found] ` <20110308210227.GA12804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-03-09 0:01 ` Minkyu Kang
2011-03-09 0:01 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308210227.GA12804@redhat.com \
--to=davej-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mk7.kang-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.