From: Yann Dirson <dirson@bertin.fr>
To: git list <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [RFC/PATCH] commit notes workflow
Date: Wed, 09 Mar 2011 09:13:07 +0100 [thread overview]
Message-ID: <20110309091307.4b759b7e@chalon.bertin.fr> (raw)
In-Reply-To: <20110225133056.GA1026@sigill.intra.peff.net>
That's a nice feature.
It may be good to extend the idea to support editing non-default notes
refs too. Maybe something like:
<commit msg>
--- Notes ---
<info for GIT_NOTES_REF>
--- Notes <whatever> ---
<info for notes/whatever>
In this case, if we want to allow the user to customize the mark, we
will want to allow formatting like "--- Notes %N ---", but then the
defaulting for GIT_NOTES_REF would not fit - would we want to force the
use of "--- Notes commits ---" or similar ? Maybe this would warrant a
separate mark for this default case:
--default-note-mark="---"
--note-mark="--- %N ---"
OTOH, using a single --note-mark and no special case for the default
notes ref seems more sane to me, since that shows the user when a
non-default GIT_NOTES_REF is in effect.
We may also want it to behave in a way similar to git-log, including
--show-notes[=<ref>] support to override the list of notes ref
to be considered.
--
Yann Dirson - Bertin Technologies
prev parent reply other threads:[~2011-03-09 8:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 13:30 [RFC/PATCH] commit notes workflow Jeff King
2011-02-25 15:58 ` Johan Herland
2011-03-01 21:59 ` Jeff King
2011-03-02 0:21 ` Johan Herland
2011-03-03 1:57 ` Sverre Rabbelier
2011-03-03 3:50 ` Junio C Hamano
2011-03-03 11:12 ` Sverre Rabbelier
2011-03-03 11:23 ` [PATCH] commit, status: #comment diff output in verbose mode Ian Ward Comfort
2011-03-03 11:25 ` Sverre Rabbelier
2011-03-07 23:39 ` [RFC/PATCH] commit notes workflow Jeff King
2011-03-07 23:39 ` [PATCH 1/2] notes: make expand_notes_ref globally accessible Jeff King
2011-03-08 8:25 ` Johan Herland
2011-03-07 23:41 ` [PATCH 2/2] commit: allow editing notes in commit message editor Jeff King
2011-03-08 9:15 ` Johan Herland
2011-03-08 12:39 ` [RFC/PATCH] commit notes workflow Michel Lespinasse
2011-03-02 7:01 ` Chris Packham
2011-03-02 12:45 ` Drew Northup
2011-03-02 16:24 ` Piotr Krukowiecki
2011-02-25 18:59 ` Junio C Hamano
2011-02-25 20:30 ` Drew Northup
2011-03-01 22:00 ` Jeff King
2011-03-01 22:18 ` Drew Northup
2011-03-01 22:23 ` Jeff King
2011-03-01 22:26 ` Drew Northup
2011-02-27 14:31 ` Michael J Gruber
2011-03-01 22:01 ` Jeff King
2011-03-09 8:13 ` Yann Dirson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309091307.4b759b7e@chalon.bertin.fr \
--to=dirson@bertin.fr \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.