From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] commit notes workflow
Date: Fri, 25 Feb 2011 10:59:59 -0800 [thread overview]
Message-ID: <7v4o7saqj4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110225133056.GA1026@sigill.intra.peff.net> (Jeff King's message of "Fri\, 25 Feb 2011 08\:30\:57 -0500")
Jeff King <peff@peff.net> writes:
> So your commit template looks like:
>
> subject
>
> commit message body
> ---
> notes data
>
> # usual template stuff
>
> I'm curious what people think. Do others find this useful? Does it seem
> harmful?
As long as this is done only under "commit --notes", I don't think it
should hurt innocent bystanders.
> It's yet another magic format to worry about when writing a commit
> message. But you don't need to care unless you use "--notes" (and I
> would probably add a config option, since I would always want this on
> personally).
Then --no-notes would also be necessary, but I think you would get it for
free these days ;-).
> I only turn on --edit when we launch an editor. It seems somehow more
> confusing to me that "git commit -F file" should split notes out (or
> worse, "git commit -m").
So if you see -F -m and there is no --edit, you don't split out notes at
the divider? That sounds like a sensible thing to me.
next prev parent reply other threads:[~2011-02-25 19:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 13:30 [RFC/PATCH] commit notes workflow Jeff King
2011-02-25 15:58 ` Johan Herland
2011-03-01 21:59 ` Jeff King
2011-03-02 0:21 ` Johan Herland
2011-03-03 1:57 ` Sverre Rabbelier
2011-03-03 3:50 ` Junio C Hamano
2011-03-03 11:12 ` Sverre Rabbelier
2011-03-03 11:23 ` [PATCH] commit, status: #comment diff output in verbose mode Ian Ward Comfort
2011-03-03 11:25 ` Sverre Rabbelier
2011-03-07 23:39 ` [RFC/PATCH] commit notes workflow Jeff King
2011-03-07 23:39 ` [PATCH 1/2] notes: make expand_notes_ref globally accessible Jeff King
2011-03-08 8:25 ` Johan Herland
2011-03-07 23:41 ` [PATCH 2/2] commit: allow editing notes in commit message editor Jeff King
2011-03-08 9:15 ` Johan Herland
2011-03-08 12:39 ` [RFC/PATCH] commit notes workflow Michel Lespinasse
2011-03-02 7:01 ` Chris Packham
2011-03-02 12:45 ` Drew Northup
2011-03-02 16:24 ` Piotr Krukowiecki
2011-02-25 18:59 ` Junio C Hamano [this message]
2011-02-25 20:30 ` Drew Northup
2011-03-01 22:00 ` Jeff King
2011-03-01 22:18 ` Drew Northup
2011-03-01 22:23 ` Jeff King
2011-03-01 22:26 ` Drew Northup
2011-02-27 14:31 ` Michael J Gruber
2011-03-01 22:01 ` Jeff King
2011-03-09 8:13 ` Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4o7saqj4.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.