More issues with xl on 4.1.0-rc

More issues with xl on 4.1.0-rc

[M A Young]

I have spotted another couple of bugs when testing with xl on 4.1.0-rc and 
a xen/next-2.6.38 based kernel.

If I use pygrub as a boot loader and run xl create -c host then 
the console disconnects once pygrub is finished. I can reconnect to the 
console session but it is a bit annoying to have to do so.

If I set vfb = [ 'sdl' ] in the configuration file, then I can type in the 
window produced, but the mouse doesn't work (the pointer stays fixed in 
the middle of the window). Alao clicking on the window doesn't trigger the 
"grab keyboard and mouse" mode, though I can manually trigger it and leave 
it using the ctrl-alt key combination.

 	Michael Young

Re: More issues with xl on 4.1.0-rc

[Stefano Stabellini]

On Thu, 3 Feb 2011, M A Young wrote:
> I have spotted another couple of bugs when testing with xl on 4.1.0-rc and 
> a xen/next-2.6.38 based kernel.
> 
> If I use pygrub as a boot loader and run xl create -c host then 
> the console disconnects once pygrub is finished. I can reconnect to the 
> console session but it is a bit annoying to have to do so.
> 
> If I set vfb = [ 'sdl' ] in the configuration file, then I can type in the 
> window produced, but the mouse doesn't work (the pointer stays fixed in 
> the middle of the window). Alao clicking on the window doesn't trigger the 
> "grab keyboard and mouse" mode, though I can manually trigger it and leave 
> it using the ctrl-alt key combination.
> 

Thank you very much for reporting these bugs.
I have just fixed the first one, but I cannot reproduce the second one
(however I am using X remoting because I don't have an X server on my
testbox).

Re: More issues with xl on 4.1.0-rc

[M A Young]

On Fri, 4 Feb 2011, Stefano Stabellini wrote:

> On Thu, 3 Feb 2011, M A Young wrote:
>> I have spotted another couple of bugs when testing with xl on 4.1.0-rc and
>> a xen/next-2.6.38 based kernel.
>>
>> If I use pygrub as a boot loader and run xl create -c host then
>> the console disconnects once pygrub is finished. I can reconnect to the
>> console session but it is a bit annoying to have to do so.
>>
>> If I set vfb = [ 'sdl' ] in the configuration file, then I can type in the
>> window produced, but the mouse doesn't work (the pointer stays fixed in
>> the middle of the window). Alao clicking on the window doesn't trigger the
>> "grab keyboard and mouse" mode, though I can manually trigger it and leave
>> it using the ctrl-alt key combination.
>>
>
> Thank you very much for reporting these bugs.
> I have just fixed the first one, but I cannot reproduce the second one
> (however I am using X remoting because I don't have an X server on my
> testbox).

Thanks for the first fix. The mouse problem is reproducible over remote X 
(ssh -X) and if I use vnc rather than sdl. Do you have any idea how we 
might debug this?

 	Michael Young

Re: More issues with xl on 4.1.0-rc

[Stefano Stabellini]

On Fri, 4 Feb 2011, M A Young wrote:
> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
> 
> > On Thu, 3 Feb 2011, M A Young wrote:
> >> I have spotted another couple of bugs when testing with xl on 4.1.0-rc and
> >> a xen/next-2.6.38 based kernel.
> >>
> >> If I use pygrub as a boot loader and run xl create -c host then
> >> the console disconnects once pygrub is finished. I can reconnect to the
> >> console session but it is a bit annoying to have to do so.
> >>
> >> If I set vfb = [ 'sdl' ] in the configuration file, then I can type in the
> >> window produced, but the mouse doesn't work (the pointer stays fixed in
> >> the middle of the window). Alao clicking on the window doesn't trigger the
> >> "grab keyboard and mouse" mode, though I can manually trigger it and leave
> >> it using the ctrl-alt key combination.
> >>
> >
> > Thank you very much for reporting these bugs.
> > I have just fixed the first one, but I cannot reproduce the second one
> > (however I am using X remoting because I don't have an X server on my
> > testbox).
> 
> Thanks for the first fix. The mouse problem is reproducible over remote X 
> (ssh -X) and if I use vnc rather than sdl. Do you have any idea how we 
> might debug this?

Does the mouse work if you just have the console and gpm in the guest?
What is the output of "xenstore-ls /local/domain/$DOMID/device/vkbd"?

Re: More issues with xl on 4.1.0-rc

[M A Young]

On Fri, 4 Feb 2011, Stefano Stabellini wrote:

> On Fri, 4 Feb 2011, M A Young wrote:
>> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
>>
>>> On Thu, 3 Feb 2011, M A Young wrote:
>>>> I have spotted another couple of bugs when testing with xl on 4.1.0-rc and
>>>> a xen/next-2.6.38 based kernel.
>>>>
>>>> If I set vfb = [ 'sdl' ] in the configuration file, then I can type in the
>>>> window produced, but the mouse doesn't work (the pointer stays fixed in
>>>> the middle of the window). Alao clicking on the window doesn't trigger the
>>>> "grab keyboard and mouse" mode, though I can manually trigger it and leave
>>>> it using the ctrl-alt key combination.
>>>
>>> ... I cannot reproduce the second one
>>> (however I am using X remoting because I don't have an X server on my
>>> testbox).
>>
>> Thanks for the first fix. The mouse problem is reproducible over remote X
>> (ssh -X) and if I use vnc rather than sdl. Do you have any idea how we
>> might debug this?
>
> Does the mouse work if you just have the console and gpm in the guest?
> What is the output of "xenstore-ls /local/domain/$DOMID/device/vkbd"?

The mouse mostly works with a console and gpm - I get a reverse video 
cursor which will move, cut and paste, though it isn't quite in step with 
where the pointer would be, eg. if I enter the window from the bottom the 
cursor appears more to the right than it should be.

 	Michael Young

Re: More issues with xl on 4.1.0-rc

[M A Young]

On Fri, 4 Feb 2011, M A Young wrote:

> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
>
>> On Fri, 4 Feb 2011, M A Young wrote:
>>> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
>>> 
>>>> On Thu, 3 Feb 2011, M A Young wrote:
>>>>> I have spotted another couple of bugs when testing with xl on 4.1.0-rc 
>>>>> and
>>>>> a xen/next-2.6.38 based kernel.
>>>>> 
>>>>> If I set vfb = [ 'sdl' ] in the configuration file, then I can type in 
>>>>> the
>>>>> window produced, but the mouse doesn't work (the pointer stays fixed in
>>>>> the middle of the window). Alao clicking on the window doesn't trigger 
>>>>> the
>>>>> "grab keyboard and mouse" mode, though I can manually trigger it and 
>>>>> leave
>>>>> it using the ctrl-alt key combination.
>>>> 
>>>> ... I cannot reproduce the second one
>>>> (however I am using X remoting because I don't have an X server on my
>>>> testbox).
>>> 
>>> Thanks for the first fix. The mouse problem is reproducible over remote X
>>> (ssh -X) and if I use vnc rather than sdl. Do you have any idea how we
>>> might debug this?
>> 
>> Does the mouse work if you just have the console and gpm in the guest?
>> What is the output of "xenstore-ls /local/domain/$DOMID/device/vkbd"?
>
> The mouse mostly works with a console and gpm - I get a reverse video cursor 
> which will move, cut and paste, though it isn't quite in step with where the 
> pointer would be, eg. if I enter the window from the bottom the cursor 
> appears more to the right than it should be.

Sorry, I forgot to add the output from
xenstore-ls /local/domain/6/device/vkbd/0
which is
backend = "/local/domain/0/backend/vkbd/6/0"
backend-id = "0"
state = "4"
page-ref = "284456"
event-channel = "14"
request-abs-pointer = "1"

 	Michael Young

Re: More issues with xl on 4.1.0-rc

[Stefano Stabellini]

On Fri, 4 Feb 2011, M A Young wrote:
> On Fri, 4 Feb 2011, M A Young wrote:
> 
> > On Fri, 4 Feb 2011, Stefano Stabellini wrote:
> >
> >> On Fri, 4 Feb 2011, M A Young wrote:
> >>> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
> >>> 
> >>>> On Thu, 3 Feb 2011, M A Young wrote:
> >>>>> I have spotted another couple of bugs when testing with xl on 4.1.0-rc 
> >>>>> and
> >>>>> a xen/next-2.6.38 based kernel.
> >>>>> 
> >>>>> If I set vfb = [ 'sdl' ] in the configuration file, then I can type in 
> >>>>> the
> >>>>> window produced, but the mouse doesn't work (the pointer stays fixed in
> >>>>> the middle of the window). Alao clicking on the window doesn't trigger 
> >>>>> the
> >>>>> "grab keyboard and mouse" mode, though I can manually trigger it and 
> >>>>> leave
> >>>>> it using the ctrl-alt key combination.
> >>>> 
> >>>> ... I cannot reproduce the second one
> >>>> (however I am using X remoting because I don't have an X server on my
> >>>> testbox).
> >>> 
> >>> Thanks for the first fix. The mouse problem is reproducible over remote X
> >>> (ssh -X) and if I use vnc rather than sdl. Do you have any idea how we
> >>> might debug this?
> >> 
> >> Does the mouse work if you just have the console and gpm in the guest?
> >> What is the output of "xenstore-ls /local/domain/$DOMID/device/vkbd"?
> >
> > The mouse mostly works with a console and gpm - I get a reverse video cursor 
> > which will move, cut and paste, though it isn't quite in step with where the 
> > pointer would be, eg. if I enter the window from the bottom the cursor 
> > appears more to the right than it should be.
> 

If you are getting mouse events in the guest's kernel, I think the basic
mechanism must be working correctly.
Could it be a problem with your xserver?

Otherwise you need to add some printf in qemu in
hw/xenfb.c:xenfb_mouse_event.




> Sorry, I forgot to add the output from
> xenstore-ls /local/domain/6/device/vkbd/0
> which is
> backend = "/local/domain/0/backend/vkbd/6/0"
> backend-id = "0"
> state = "4"
> page-ref = "284456"
> event-channel = "14"
> request-abs-pointer = "1"

looks all right

Problems with guest mouse Was: More issues with xl on 4.1.0-rc

[M A Young]

On Fri, 4 Feb 2011, Stefano Stabellini wrote:

> On Fri, 4 Feb 2011, M A Young wrote:
>> On Fri, 4 Feb 2011, M A Young wrote:
>>
>>> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
>>>
>>>> On Fri, 4 Feb 2011, M A Young wrote:
>>>>> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
>>>>>
>>>>>> On Thu, 3 Feb 2011, M A Young wrote:
>>>>>>> I have spotted another couple of bugs when testing with xl on 4.1.0-rc
>>>>>>> and
>>>>>>> a xen/next-2.6.38 based kernel.
>>>>>>>
>>>>>>> If I set vfb = [ 'sdl' ] in the configuration file, then I can type in
>>>>>>> the
>>>>>>> window produced, but the mouse doesn't work (the pointer stays fixed in
>>>>>>> the middle of the window). Alao clicking on the window doesn't trigger
>>>>>>> the
>>>>>>> "grab keyboard and mouse" mode, though I can manually trigger it and
>>>>>>> leave
>>>>>>> it using the ctrl-alt key combination.
>>>>>>
>>>>>> ... I cannot reproduce the second one
>>>>>> (however I am using X remoting because I don't have an X server on my
>>>>>> testbox).
>>>>>
>>>>> Thanks for the first fix. The mouse problem is reproducible over remote X
>>>>> (ssh -X) and if I use vnc rather than sdl. Do you have any idea how we
>>>>> might debug this?
>>>>
>>>> Does the mouse work if you just have the console and gpm in the guest?
>>>> What is the output of "xenstore-ls /local/domain/$DOMID/device/vkbd"?
>>>
>>> The mouse mostly works with a console and gpm - I get a reverse video cursor
>>> which will move, cut and paste, though it isn't quite in step with where the
>>> pointer would be, eg. if I enter the window from the bottom the cursor
>>> appears more to the right than it should be.
>>
>
> If you are getting mouse events in the guest's kernel, I think the basic
> mechanism must be working correctly.
> Could it be a problem with your xserver?
>
> Otherwise you need to add some printf in qemu in
> hw/xenfb.c:xenfb_mouse_event.

I am still having problems with this. My debugging output of 
xenfb_mouse_event looked the same as a different computer that didn't have 
the proble. Do you have any further debugging suggestions?

 	Michael Young

Re: Problems with guest mouse Was: More issues with xl on 4.1.0-rc

[Stefano Stabellini]

On Sun, 6 Mar 2011, M A Young wrote:
> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
> 
> > On Fri, 4 Feb 2011, M A Young wrote:
> >> On Fri, 4 Feb 2011, M A Young wrote:
> >>
> >>> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
> >>>
> >>>> On Fri, 4 Feb 2011, M A Young wrote:
> >>>>> On Fri, 4 Feb 2011, Stefano Stabellini wrote:
> >>>>>
> >>>>>> On Thu, 3 Feb 2011, M A Young wrote:
> >>>>>>> I have spotted another couple of bugs when testing with xl on 4.1.0-rc
> >>>>>>> and
> >>>>>>> a xen/next-2.6.38 based kernel.
> >>>>>>>
> >>>>>>> If I set vfb = [ 'sdl' ] in the configuration file, then I can type in
> >>>>>>> the
> >>>>>>> window produced, but the mouse doesn't work (the pointer stays fixed in
> >>>>>>> the middle of the window). Alao clicking on the window doesn't trigger
> >>>>>>> the
> >>>>>>> "grab keyboard and mouse" mode, though I can manually trigger it and
> >>>>>>> leave
> >>>>>>> it using the ctrl-alt key combination.
> >>>>>>
> >>>>>> ... I cannot reproduce the second one
> >>>>>> (however I am using X remoting because I don't have an X server on my
> >>>>>> testbox).
> >>>>>
> >>>>> Thanks for the first fix. The mouse problem is reproducible over remote X
> >>>>> (ssh -X) and if I use vnc rather than sdl. Do you have any idea how we
> >>>>> might debug this?
> >>>>
> >>>> Does the mouse work if you just have the console and gpm in the guest?
> >>>> What is the output of "xenstore-ls /local/domain/$DOMID/device/vkbd"?
> >>>
> >>> The mouse mostly works with a console and gpm - I get a reverse video cursor
> >>> which will move, cut and paste, though it isn't quite in step with where the
> >>> pointer would be, eg. if I enter the window from the bottom the cursor
> >>> appears more to the right than it should be.
> >>
> >
> > If you are getting mouse events in the guest's kernel, I think the basic
> > mechanism must be working correctly.
> > Could it be a problem with your xserver?
> >
> > Otherwise you need to add some printf in qemu in
> > hw/xenfb.c:xenfb_mouse_event.
> 
> I am still having problems with this. My debugging output of 
> xenfb_mouse_event looked the same as a different computer that didn't have 
> the proble. Do you have any further debugging suggestions?
 
Is there any difference in the VMs between the system that works and the
one that does not? In particular I am think about kernel or xorg
versions.

You could try to add some debug messages to
drivers/input/xen-kbdfront.c:input_handler in the guest kernel and see
if you are actually receiving the events you should be receiving.

Re: Problems with guest mouse Was: More issues with xl on 4.1.0-rc

[M A Young]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 672 bytes --]

On Mon, 7 Mar 2011, Stefano Stabellini wrote:

> On Sun, 6 Mar 2011, M A Young wrote:
>
> Is there any difference in the VMs between the system that works and the
> one that does not? In particular I am think about kernel or xorg
> versions.

I think this could be it. The mouse doesn't work on newer VMs but does 
work on older ones (I am not sure my earlier test results quite fitted 
that pattern but I could be mis-remembering or have been mis-testing).

I am attaching the Xorg log files from a working guest where the mouse 
works and one where it doesn't. In particular abssolute axis support 
doesn't seem to have been set up in the problem guest.

 	Michael Young

[-- Attachment #2: good Xorg --]
[-- Type: TEXT/PLAIN, Size: 11291 bytes --]


X.Org X Server 1.8.2
Release Date: 2010-07-01
X Protocol Version 11, Revision 0
Build Operating System: x86-17 2.6.32-44.el6.x86_64 
Current Operating System: Linux austen3 2.6.34.7-66.fc13.x86_64 #1 SMP Wed Dec 15 07:04:30 UTC 2010 x86_64
Kernel command line: ro root=UUID=fcb47974-dd00-4990-bcee-e2b50a0f184b rhgb quiet 
Build Date: 13 September 2010  07:04:16PM
Build ID: xorg-x11-server 1.8.2-4.fc13 
Current version of pixman: 0.18.0
	Before reporting problems, check http://bodhi.fedoraproject.org/
	to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
	(++) from command line, (!!) notice, (II) informational,
	(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(==) Log file: "/var/log/Xorg.0.log", Time: Mon Mar  7 18:52:57 2011
(==) Using config directory: "/etc/X11/xorg.conf.d"
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
(==) No Layout section.  Using the first Screen section.
(==) No screen section available. Using defaults.
(**) |-->Screen "Default Screen Section" (0)
(**) |   |-->Monitor "<default monitor>"
(==) No monitor specified for screen "Default Screen Section".
	Using a default monitor configuration.
(==) Automatically adding devices
(==) Automatically enabling devices
(==) FontPath set to:
	catalogue:/etc/X11/fontpath.d,
	built-ins
(==) ModulePath set to "/usr/lib64/xorg/modules"
(II) The server relies on udev to provide the list of input devices.
	If no devices become available, reconfigure udev or disable AutoAddDevices.
(II) 
***************************************************************
***************************************************************
** Fedora switched to udev-based device detection with       **
** xorg-x11-server-1.7.99.901-1. Custom HAL configuration    **
** stored in /etc/hal/fdi/policy will not be seen by this    **
** server version. If you have such configuration you will   **
** need to update it to the new format.                      **
** For more information, see the Fedora wiki page            **
** https://fedoraproject.org/wiki/Input_device_configuration **
***************************************************************
***************************************************************
(II) Loader magic: 0x7ced20
(II) Module ABI versions:
	X.Org ANSI C Emulation: 0.4
	X.Org Video Driver: 7.0
	X.Org XInput driver : 9.0
	X.Org Server Extension : 3.0
(II) LoadModule: "extmod"
(II) Loading /usr/lib64/xorg/modules/extensions/libextmod.so
(II) Module extmod: vendor="X.Org Foundation"
	compiled for 1.8.2, module version = 1.0.0
	Module class: X.Org Server Extension
	ABI class: X.Org Server Extension, version 3.0
(II) Loading extension SELinux
(II) Loading extension MIT-SCREEN-SAVER
(II) Loading extension XFree86-VidModeExtension
(II) Loading extension XFree86-DGA
(II) Loading extension DPMS
(II) Loading extension XVideo
(II) Loading extension XVideo-MotionCompensation
(II) Loading extension X-Resource
(II) LoadModule: "dbe"
(II) Loading /usr/lib64/xorg/modules/extensions/libdbe.so
(II) Module dbe: vendor="X.Org Foundation"
	compiled for 1.8.2, module version = 1.0.0
	Module class: X.Org Server Extension
	ABI class: X.Org Server Extension, version 3.0
(II) Loading extension DOUBLE-BUFFER
(II) LoadModule: "glx"
(II) Loading /usr/lib64/xorg/modules/extensions/libglx.so
(II) Module glx: vendor="X.Org Foundation"
	compiled for 1.8.2, module version = 1.0.0
	ABI class: X.Org Server Extension, version 3.0
(==) AIGLX enabled
(II) Loading extension GLX
(II) LoadModule: "record"
(II) Loading /usr/lib64/xorg/modules/extensions/librecord.so
(II) Module record: vendor="X.Org Foundation"
	compiled for 1.8.2, module version = 1.13.0
	Module class: X.Org Server Extension
	ABI class: X.Org Server Extension, version 3.0
(II) Loading extension RECORD
(II) LoadModule: "dri"
(II) Loading /usr/lib64/xorg/modules/extensions/libdri.so
(II) Module dri: vendor="X.Org Foundation"
	compiled for 1.8.2, module version = 1.0.0
	ABI class: X.Org Server Extension, version 3.0
(II) Loading extension XFree86-DRI
(II) LoadModule: "dri2"
(II) Loading /usr/lib64/xorg/modules/extensions/libdri2.so
(II) Module dri2: vendor="X.Org Foundation"
	compiled for 1.8.2, module version = 1.2.0
	ABI class: X.Org Server Extension, version 3.0
(II) Loading extension DRI2
Primary device is not PCI
(==) Matched vesa as autoconfigured driver 0
(==) Matched fbdev as autoconfigured driver 1
(==) Assigned the driver to the xf86ConfigLayout
(II) LoadModule: "vesa"
(II) Loading /usr/lib64/xorg/modules/drivers/vesa_drv.so
(II) Module vesa: vendor="X.Org Foundation"
	compiled for 1.8.0, module version = 2.3.0
	Module class: X.Org Video Driver
	ABI class: X.Org Video Driver, version 7.0
(II) LoadModule: "fbdev"
(II) Loading /usr/lib64/xorg/modules/drivers/fbdev_drv.so
(II) Module fbdev: vendor="X.Org Foundation"
	compiled for 1.7.99.3, module version = 0.4.1
	ABI class: X.Org Video Driver, version 7.0
(II) VESA: driver for VESA chipsets: vesa
(II) FBDEV: driver for framebuffer: fbdev
(++) using VT number 1

(WW) Falling back to old probe method for vesa
(WW) Falling back to old probe method for fbdev
(II) Loading sub module "fbdevhw"
(II) LoadModule: "fbdevhw"
(II) Loading /usr/lib64/xorg/modules/linux/libfbdevhw.so
(II) Module fbdevhw: vendor="X.Org Foundation"
	compiled for 1.8.2, module version = 0.0.2
	ABI class: X.Org Video Driver, version 7.0
(II) FBDEV(0): using default device
(II) Running in FRAMEBUFFER Mode
(II) FBDEV(0): Creating default Display subsection in Screen section
	"Default Screen Section" for depth/fbbpp 24/32
(==) FBDEV(0): Depth 24, (==) framebuffer bpp 32
(==) FBDEV(0): RGB weight 888
(==) FBDEV(0): Default visual is TrueColor
(==) FBDEV(0): Using gamma correction (1.0, 1.0, 1.0)
(II) FBDEV(0): hardware: xen (video memory: 2048kB)
(II) FBDEV(0): checking modes against framebuffer device...
(II) FBDEV(0): checking modes against monitor...
(--) FBDEV(0): Virtual size is 800x600 (pitch 800)
(**) FBDEV(0):  Built-in mode "current"
(==) FBDEV(0): DPI set to (96, 96)
(II) Loading sub module "fb"
(II) LoadModule: "fb"
(II) Loading /usr/lib64/xorg/modules/libfb.so
(II) Module fb: vendor="X.Org Foundation"
	compiled for 1.8.2, module version = 1.0.0
	ABI class: X.Org ANSI C Emulation, version 0.4
(**) FBDEV(0): using shadow framebuffer
(II) Loading sub module "shadow"
(II) LoadModule: "shadow"
(II) Loading /usr/lib64/xorg/modules/libshadow.so
(II) Module shadow: vendor="X.Org Foundation"
	compiled for 1.8.2, module version = 1.1.0
	ABI class: X.Org ANSI C Emulation, version 0.4
(II) UnloadModule: "vesa"
(II) Unloading /usr/lib64/xorg/modules/drivers/vesa_drv.so
(==) Depth 24 pixmap format is 32 bpp
(EE) FBDEV(0): FBIOBLANK: Invalid argument
(==) FBDEV(0): Backing store disabled
(==) FBDEV(0): DPMS enabled
(==) RandR enabled
(II) Initializing built-in extension Generic Event Extension
(II) Initializing built-in extension SHAPE
(II) Initializing built-in extension MIT-SHM
(II) Initializing built-in extension XInputExtension
(II) Initializing built-in extension XTEST
(II) Initializing built-in extension BIG-REQUESTS
(II) Initializing built-in extension SYNC
(II) Initializing built-in extension XKEYBOARD
(II) Initializing built-in extension XC-MISC
(II) Initializing built-in extension XINERAMA
(II) Initializing built-in extension XFIXES
(II) Initializing built-in extension RENDER
(II) Initializing built-in extension RANDR
(II) Initializing built-in extension COMPOSITE
(II) Initializing built-in extension DAMAGE
(II) SELinux: Disabled by boolean
(II) AIGLX: Screen 0 is not DRI2 capable
(II) AIGLX: Screen 0 is not DRI capable
(II) AIGLX: Loaded and initialized /usr/lib64/dri/swrast_dri.so
(II) GLX: Initialized DRISWRAST GL provider for screen 0
(II) config/udev: Adding input device Xen Virtual Keyboard (/dev/input/event0)
(**) Xen Virtual Keyboard: Applying InputClass "evdev keyboard catchall"
(**) Xen Virtual Keyboard: Applying InputClass "system-setup-keyboard"
(II) LoadModule: "evdev"
(II) Loading /usr/lib64/xorg/modules/input/evdev_drv.so
(II) Module evdev: vendor="X.Org Foundation"
	compiled for 1.7.99.901, module version = 2.4.0
	Module class: X.Org XInput Driver
	ABI class: X.Org XInput driver, version 9.0
(**) Xen Virtual Keyboard: always reports core events
(**) Xen Virtual Keyboard: Device: "/dev/input/event0"
(II) Xen Virtual Keyboard: Found keys
(II) Xen Virtual Keyboard: Configuring as keyboard
(II) XINPUT: Adding extended input device "Xen Virtual Keyboard" (type: KEYBOARD)
(**) Option "xkb_rules" "evdev"
(**) Option "xkb_model" "pc105"
(**) Option "xkb_layout" "gb"
(**) Option "xkb_options" "terminate:ctrl_alt_bksp,"
(II) config/udev: Adding input device Xen Virtual Keyboard (/dev/input/js0)
(**) Xen Virtual Keyboard: Applying InputClass "system-setup-keyboard"
(II) No input driver/identifier specified (ignoring)
(II) config/udev: Adding input device Xen Virtual Pointer (/dev/input/event1)
(**) Xen Virtual Pointer: Applying InputClass "evdev pointer catchall"
(**) Xen Virtual Pointer: Applying InputClass "Xen Virtual Pointer axis blacklist"
(**) Xen Virtual Pointer: always reports core events
(**) Xen Virtual Pointer: Device: "/dev/input/event1"
(**) Option "IgnoreRelativeAxes" "off"
(**) Option "IgnoreAbsoluteAxes" "off"
(II) Xen Virtual Pointer: Found 12 mouse buttons
(II) Xen Virtual Pointer: Found scroll wheel(s)
(II) Xen Virtual Pointer: Found relative axes
(II) Xen Virtual Pointer: Found x and y relative axes
(II) Xen Virtual Pointer: Found absolute axes
(II) Xen Virtual Pointer: Found x and y absolute axes
(II) Xen Virtual Pointer: Configuring as mouse
(**) Xen Virtual Pointer: YAxisMapping: buttons 4 and 5
(**) Xen Virtual Pointer: EmulateWheelButton: 4, EmulateWheelInertia: 10, EmulateWheelTimeout: 200
(II) XINPUT: Adding extended input device "Xen Virtual Pointer" (type: MOUSE)
(**) Xen Virtual Pointer: (accel) keeping acceleration scheme 1
(**) Xen Virtual Pointer: (accel) acceleration profile 0
(**) Xen Virtual Pointer: (accel) acceleration factor: 2.000
(**) Xen Virtual Pointer: (accel) acceleration threshold: 4
(II) Xen Virtual Pointer: initialized for relative axes.
(**) Xen Virtual Pointer: (accel) keeping acceleration scheme 1
(**) Xen Virtual Pointer: (accel) acceleration profile 0
(**) Xen Virtual Pointer: (accel) acceleration factor: 2.000
(**) Xen Virtual Pointer: (accel) acceleration threshold: 4
(II) Xen Virtual Pointer: initialized for absolute axes.
(II) config/udev: Adding input device Xen Virtual Pointer (/dev/input/js1)
(**) Xen Virtual Pointer: Applying InputClass "Xen Virtual Pointer axis blacklist"
(II) No input driver/identifier specified (ignoring)
(II) config/udev: Adding input device Xen Virtual Pointer (/dev/input/mouse0)
(**) Xen Virtual Pointer: Applying InputClass "Xen Virtual Pointer axis blacklist"
(II) No input driver/identifier specified (ignoring)
(EE) FBDEV(0): FBIOBLANK: Invalid argument
(II) Xen Virtual Keyboard: Close
(II) UnloadModule: "evdev"
(II) Xen Virtual Pointer: Close
(II) UnloadModule: "evdev"

[-- Attachment #3: bad Xorg --]
[-- Type: TEXT/PLAIN, Size: 10546 bytes --]


This is a pre-release version of the X server from Fedora Project.
It is not supported in any way.
Bugs may be filed in the bugzilla at http://bugs.freedesktop.org/.
Select the "xorg" product for bugs you find in this release.
Before reporting bugs in pre-release versions please check the
latest version in the X.Org Foundation git repository.
See http://wiki.x.org/wiki/GitPage for git access instructions.

X.Org X Server 1.9.99.1
Release Date: 2010-10-01
X Protocol Version 11, Revision 0
Build Operating System: x86-02 2.6.32-71.14.1.el6.x86_64 
Current Operating System: Linux localhost.localdomain 2.6.38-0.rc6.git6.1.fc15.x86_64 #1 SMP Sat Feb 26 01:14:56 UTC 2011 x86_64
Kernel command line: ro root=/dev/mapper/VolGroup-lv_root rd_LVM_LV=VolGroup/lv_root rd_LVM_LV=VolGroup/lv_swap rd_NO_LUKS rd_NO_MD rd_NO_DM LANG=en_US.UTF-8 SYSFONT=latarcyrheb-sun16 KEYTABLE=us console=hvc0 rhgb quiet 
Build Date: 25 February 2011  03:08:51AM
Build ID: xorg-x11-server 1.9.99.1-6.20101201.fc15 
Current version of pixman: 0.20.2
	Before reporting problems, check http://wiki.x.org
	to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
	(++) from command line, (!!) notice, (II) informational,
	(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(==) Log file: "/var/log/Xorg.0.log", Time: Tue Mar  8 10:44:10 2011
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
(==) No Layout section.  Using the first Screen section.
(==) No screen section available. Using defaults.
(**) |-->Screen "Default Screen Section" (0)
(**) |   |-->Monitor "<default monitor>"
(==) No monitor specified for screen "Default Screen Section".
	Using a default monitor configuration.
(==) Automatically adding devices
(==) Automatically enabling devices
(==) FontPath set to:
	catalogue:/etc/X11/fontpath.d,
	built-ins
(==) ModulePath set to "/usr/lib64/xorg/modules"
(II) The server relies on udev to provide the list of input devices.
	If no devices become available, reconfigure udev or disable AutoAddDevices.
(II) Loader magic: 0x7d0640
(II) Module ABI versions:
	X.Org ANSI C Emulation: 0.4
	X.Org Video Driver: 9.0
	X.Org XInput driver : 12.0
	X.Org Server Extension : 4.0
(II) LoadModule: "extmod"
(II) Loading /usr/lib64/xorg/modules/extensions/libextmod.so
(II) Module extmod: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 1.0.0
	Module class: X.Org Server Extension
	ABI class: X.Org Server Extension, version 4.0
(II) Loading extension SELinux
(II) Loading extension MIT-SCREEN-SAVER
(II) Loading extension XFree86-VidModeExtension
(II) Loading extension XFree86-DGA
(II) Loading extension DPMS
(II) Loading extension XVideo
(II) Loading extension XVideo-MotionCompensation
(II) Loading extension X-Resource
(II) LoadModule: "dbe"
(II) Loading /usr/lib64/xorg/modules/extensions/libdbe.so
(II) Module dbe: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 1.0.0
	Module class: X.Org Server Extension
	ABI class: X.Org Server Extension, version 4.0
(II) Loading extension DOUBLE-BUFFER
(II) LoadModule: "glx"
(II) Loading /usr/lib64/xorg/modules/extensions/libglx.so
(II) Module glx: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 1.0.0
	ABI class: X.Org Server Extension, version 4.0
(==) AIGLX enabled
(II) Loading extension GLX
(II) LoadModule: "record"
(II) Loading /usr/lib64/xorg/modules/extensions/librecord.so
(II) Module record: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 1.13.0
	Module class: X.Org Server Extension
	ABI class: X.Org Server Extension, version 4.0
(II) Loading extension RECORD
(II) LoadModule: "dri"
(II) Loading /usr/lib64/xorg/modules/extensions/libdri.so
(II) Module dri: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 1.0.0
	ABI class: X.Org Server Extension, version 4.0
(II) Loading extension XFree86-DRI
(II) LoadModule: "dri2"
(II) Loading /usr/lib64/xorg/modules/extensions/libdri2.so
(II) Module dri2: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 1.2.0
	ABI class: X.Org Server Extension, version 4.0
(II) Loading extension DRI2
(==) Matched vesa as autoconfigured driver 0
(==) Matched fbdev as autoconfigured driver 1
(==) Assigned the driver to the xf86ConfigLayout
(II) LoadModule: "vesa"
(II) Loading /usr/lib64/xorg/modules/drivers/vesa_drv.so
(II) Module vesa: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 2.3.0
	Module class: X.Org Video Driver
	ABI class: X.Org Video Driver, version 9.0
(II) LoadModule: "fbdev"
(II) Loading /usr/lib64/xorg/modules/drivers/fbdev_drv.so
(II) Module fbdev: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 0.4.1
	ABI class: X.Org Video Driver, version 9.0
(II) VESA: driver for VESA chipsets: vesa
(II) FBDEV: driver for framebuffer: fbdev
(--) using VT number 7

(WW) Falling back to old probe method for vesa
(WW) Falling back to old probe method for fbdev
(II) Loading sub module "fbdevhw"
(II) LoadModule: "fbdevhw"
(II) Loading /usr/lib64/xorg/modules/libfbdevhw.so
(II) Module fbdevhw: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 0.0.2
	ABI class: X.Org Video Driver, version 9.0
(II) Loading /usr/lib64/xorg/modules/drivers/fbdev_drv.so
(II) Loading /usr/lib64/xorg/modules/libfbdevhw.so
(II) FBDEV(0): using default device
(II) FBDEV(0): Creating default Display subsection in Screen section
	"Default Screen Section" for depth/fbbpp 24/32
(==) FBDEV(0): Depth 24, (==) framebuffer bpp 32
(==) FBDEV(0): RGB weight 888
(==) FBDEV(0): Default visual is TrueColor
(==) FBDEV(0): Using gamma correction (1.0, 1.0, 1.0)
(II) FBDEV(0): hardware: xen (video memory: 2048kB)
(II) FBDEV(0): checking modes against framebuffer device...
(II) FBDEV(0): checking modes against monitor...
(--) FBDEV(0): Virtual size is 800x600 (pitch 800)
(**) FBDEV(0):  Built-in mode "current"
(==) FBDEV(0): DPI set to (96, 96)
(II) Loading sub module "fb"
(II) LoadModule: "fb"
(II) Loading /usr/lib64/xorg/modules/libfb.so
(II) Module fb: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 1.0.0
	ABI class: X.Org ANSI C Emulation, version 0.4
(**) FBDEV(0): using shadow framebuffer
(II) Loading sub module "shadow"
(II) LoadModule: "shadow"
(II) Loading /usr/lib64/xorg/modules/libshadow.so
(II) Module shadow: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 1.1.0
	ABI class: X.Org ANSI C Emulation, version 0.4
(II) UnloadModule: "vesa"
(II) Unloading vesa
(==) Depth 24 pixmap format is 32 bpp
(EE) FBDEV(0): FBIOBLANK: Invalid argument
(==) FBDEV(0): Backing store disabled
(==) FBDEV(0): DPMS enabled
(==) RandR enabled
(II) Initializing built-in extension Generic Event Extension
(II) Initializing built-in extension SHAPE
(II) Initializing built-in extension MIT-SHM
(II) Initializing built-in extension XInputExtension
(II) Initializing built-in extension XTEST
(II) Initializing built-in extension BIG-REQUESTS
(II) Initializing built-in extension SYNC
(II) Initializing built-in extension XKEYBOARD
(II) Initializing built-in extension XC-MISC
(II) Initializing built-in extension XINERAMA
(II) Initializing built-in extension XFIXES
(II) Initializing built-in extension RENDER
(II) Initializing built-in extension RANDR
(II) Initializing built-in extension COMPOSITE
(II) Initializing built-in extension DAMAGE
(II) SELinux: Disabled by boolean
(II) AIGLX: Screen 0 is not DRI2 capable
(II) AIGLX: Screen 0 is not DRI capable
(II) AIGLX: Loaded and initialized /usr/lib64/dri/swrast_dri.so
(II) GLX: Initialized DRISWRAST GL provider for screen 0
(II) config/udev: Adding input device Xen Virtual Keyboard (/dev/input/event0)
(**) Xen Virtual Keyboard: Applying InputClass "evdev keyboard catchall"
(II) LoadModule: "evdev"
(II) Loading /usr/lib64/xorg/modules/input/evdev_drv.so
(II) Module evdev: vendor="X.Org Foundation"
	compiled for 1.9.99.1, module version = 2.6.0
	Module class: X.Org XInput Driver
	ABI class: X.Org XInput driver, version 12.0
(II) Loading /usr/lib64/xorg/modules/input/evdev_drv.so
(**) Xen Virtual Keyboard: always reports core events
(**) Xen Virtual Keyboard: Device: "/dev/input/event0"
(--) Xen Virtual Keyboard: Found keys
(II) Xen Virtual Keyboard: Configuring as keyboard
(**) Option "config_info" "udev:/sys/devices/virtual/input/input0/event0"
(II) XINPUT: Adding extended input device "Xen Virtual Keyboard" (type: KEYBOARD)
(**) Option "xkb_rules" "evdev"
(**) Option "xkb_model" "evdev"
(**) Option "xkb_layout" "us"
(II) config/udev: Adding input device Xen Virtual Keyboard (/dev/input/js0)
(II) No input driver/identifier specified (ignoring)
(II) config/udev: Adding input device Xen Virtual Pointer (/dev/input/event1)
(**) Xen Virtual Pointer: Applying InputClass "evdev pointer catchall"
(II) Loading /usr/lib64/xorg/modules/input/evdev_drv.so
(**) Xen Virtual Pointer: always reports core events
(**) Xen Virtual Pointer: Device: "/dev/input/event1"
(--) Xen Virtual Pointer: Found 12 mouse buttons
(--) Xen Virtual Pointer: Found scroll wheel(s)
(--) Xen Virtual Pointer: Found relative axes
(--) Xen Virtual Pointer: Found x and y relative axes
(--) Xen Virtual Pointer: Found absolute axes
(--) Xen Virtual Pointer: Found x and y absolute axes
(II) Xen Virtual Pointer: Configuring as mouse
(II) Xen Virtual Pointer: Adding scrollwheel support
(**) Xen Virtual Pointer: YAxisMapping: buttons 4 and 5
(**) Xen Virtual Pointer: EmulateWheelButton: 4, EmulateWheelInertia: 10, EmulateWheelTimeout: 200
(**) Option "config_info" "udev:/sys/devices/virtual/input/input1/event1"
(II) XINPUT: Adding extended input device "Xen Virtual Pointer" (type: MOUSE)
(II) Xen Virtual Pointer: initialized for relative axes.
(WW) Xen Virtual Pointer: ignoring absolute axes.
(**) Xen Virtual Pointer: (accel) keeping acceleration scheme 1
(**) Xen Virtual Pointer: (accel) acceleration profile 0
(**) Xen Virtual Pointer: (accel) acceleration factor: 2.000
(**) Xen Virtual Pointer: (accel) acceleration threshold: 4
(II) config/udev: Adding input device Xen Virtual Pointer (/dev/input/js1)
(II) No input driver/identifier specified (ignoring)
(II) config/udev: Adding input device Xen Virtual Pointer (/dev/input/mouse0)
(II) No input driver/identifier specified (ignoring)
(EE) FBDEV(0): FBIOBLANK: Invalid argument

[-- Attachment #4: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: Re: Problems with guest mouse Was: More issues with xl on 4.1.0-rc

[John Haxby]

On 08/03/11 22:03, M A Young wrote:
> On Mon, 7 Mar 2011, Stefano Stabellini wrote:
>
>> On Sun, 6 Mar 2011, M A Young wrote:
>>
>> Is there any difference in the VMs between the system that works and the
>> one that does not? In particular I am think about kernel or xorg
>> versions.
>
> I think this could be it. The mouse doesn't work on newer VMs but does
> work on older ones (I am not sure my earlier test results quite fitted
> that pattern but I could be mis-remembering or have been mis-testing).


I thought this sounded familiar.  In the bad log you have

(==) Using system config directory "/usr/share/X11/xorg.conf.d"
...
(II) config/udev: Adding input device Xen Virtual Pointer
(/dev/input/event1)
(**) Xen Virtual Pointer: Applying InputClass "evdev pointer catchall"
(II) Loading /usr/lib64/xorg/modules/input/evdev_drv.so
(**) Xen Virtual Pointer: always reports core events
(**) Xen Virtual Pointer: Device: "/dev/input/event1"
(--) Xen Virtual Pointer: Found 12 mouse buttons
(--) Xen Virtual Pointer: Found scroll wheel(s)
(--) Xen Virtual Pointer: Found relative axes
(--) Xen Virtual Pointer: Found x and y relative axes
(--) Xen Virtual Pointer: Found absolute axes
(--) Xen Virtual Pointer: Found x and y absolute axes
(II) Xen Virtual Pointer: Configuring as mouse
(II) Xen Virtual Pointer: Adding scrollwheel support
(**) Xen Virtual Pointer: YAxisMapping: buttons 4 and 5
(**) Xen Virtual Pointer: EmulateWheelButton: 4, EmulateWheelInertia:
10, EmulateWheelTimeout: 200
(**) Option "config_info" "udev:/sys/devices/virtual/input/input1/event1"
(II) XINPUT: Adding extended input device "Xen Virtual Pointer" (type:
MOUSE)
(II) Xen Virtual Pointer: initialized for relative axes.
(WW) Xen Virtual Pointer: ignoring absolute axes.
(**) Xen Virtual Pointer: (accel) keeping acceleration scheme 1
(**) Xen Virtual Pointer: (accel) acceleration profile 0
(**) Xen Virtual Pointer: (accel) acceleration factor: 2.000
(**) Xen Virtual Pointer: (accel) acceleration threshold: 4


The critical bit it "ignoring absolute axes".   If you look at the evdev
man page it says

                                                                  The X
              server cannot deal with devices that have  both  relative
              and  absolute  axes.  Evdev  tries  to guess wich axes to
              ignore given the device type and disables  absolute  axes
              for  mice and relative axes for tablets, touchscreens and
              touchpad.

Your "good" log file indicates that something was done about this in the
configuration, but the easiest thing to do is to put this in
/usr/share/X11/xorg.conf.d/xen.conf (that file doesn't exist):

Section "InputClass"
    Identifier "Xen Virtual Pointer"
    MatchProduct "Xen Virtual Pointer"
    Option "IgnoreRelativeAxes" "True"
EndSection

When you start up the X server the log file will show that this option
has been taken and all will be sweetness and light.

The underlying problem seems to be that the xen virtual mouse driver is
advertising both relative and absolute axes (duh) but the back end is
only supplying absolute axes.

I haven't had the time to look since I discovered this a week ago -- but
I think that the front end shouldn't be advertising relative axes if the
back end is supplying absolute ones.   Perhaps now I should actually
look ...

jch

Re: Re: Problems with guest mouse Was: More issues with xl on 4.1.0-rc

[Olaf Hering]

On Wed, Mar 09, John Haxby wrote:

> (II) Xen Virtual Pointer: initialized for relative axes.
> (WW) Xen Virtual Pointer: ignoring absolute axes.

The bug is in the PV driver, it should send either absolute or relative,
but not advertise both to the kernel evdev driver. The current
xorg-input driver gets confused if both are advertised (it may have a
reason to do it that way for real hardware).

I have a kernel patch which I will send out later this week.

Olaf

Re: Re: Problems with guest mouse Was: More issues with xl on 4.1.0-rc

[M A Young]

On Wed, 9 Mar 2011, John Haxby wrote:

> Your "good" log file indicates that something was done about this in the
> configuration, but the easiest thing to do is to put this in
> /usr/share/X11/xorg.conf.d/xen.conf (that file doesn't exist):
>
> Section "InputClass"
>    Identifier "Xen Virtual Pointer"
>    MatchProduct "Xen Virtual Pointer"
>    Option "IgnoreRelativeAxes" "True"
> EndSection

In my case (on the vm I have tested so far) I needed

     Option "IgnoreAbsoluteAxes" "False"

which made it work, because the X server guesses correctly, though adding
     Option "IgnoreRelativeAxes" "True"
and/or
     Option "Mode" "Absolute"
as well stops the guesswork.

 	Michael Young

Re: Re: Problems with guest mouse Was: More issues with xl on 4.1.0-rc

[Stefano Stabellini]

On Wed, 9 Mar 2011, Olaf Hering wrote:
> On Wed, Mar 09, John Haxby wrote:
> 
> > (II) Xen Virtual Pointer: initialized for relative axes.
> > (WW) Xen Virtual Pointer: ignoring absolute axes.
> 
> The bug is in the PV driver, it should send either absolute or relative,
> but not advertise both to the kernel evdev driver. The current
> xorg-input driver gets confused if both are advertised (it may have a
> reason to do it that way for real hardware).
> 
> I have a kernel patch which I will send out later this week.

Ok, I count on you :)

Re: Re: Problems with guest mouse Was: More issues with xl on 4.1.0-rc

[Olaf Hering]

On Wed, Mar 09, Stefano Stabellini wrote:

> On Wed, 9 Mar 2011, Olaf Hering wrote:
> > On Wed, Mar 09, John Haxby wrote:
> > 
> > > (II) Xen Virtual Pointer: initialized for relative axes.
> > > (WW) Xen Virtual Pointer: ignoring absolute axes.
> > 
> > The bug is in the PV driver, it should send either absolute or relative,
> > but not advertise both to the kernel evdev driver. The current
> > xorg-input driver gets confused if both are advertised (it may have a
> > reason to do it that way for real hardware).
> > 
> > I have a kernel patch which I will send out later this week.
> 
> Ok, I count on you :)

I just sent a patch for linux-2.6.18.hg:
fbfront: advertise either absolute or relative coordinates

The code in linux-2.6-xen.git looks identical, please try this patch.

Olaf

Re: Re: Problems with guest mouse Was: More issues with xl on 4.1.0-rc

[Stefano Stabellini]

On Thu, 10 Mar 2011, Olaf Hering wrote:
> On Wed, Mar 09, Stefano Stabellini wrote:
> 
> > On Wed, 9 Mar 2011, Olaf Hering wrote:
> > > On Wed, Mar 09, John Haxby wrote:
> > > 
> > > > (II) Xen Virtual Pointer: initialized for relative axes.
> > > > (WW) Xen Virtual Pointer: ignoring absolute axes.
> > > 
> > > The bug is in the PV driver, it should send either absolute or relative,
> > > but not advertise both to the kernel evdev driver. The current
> > > xorg-input driver gets confused if both are advertised (it may have a
> > > reason to do it that way for real hardware).
> > > 
> > > I have a kernel patch which I will send out later this week.
> > 
> > Ok, I count on you :)
> 
> I just sent a patch for linux-2.6.18.hg:
> fbfront: advertise either absolute or relative coordinates
> 
> The code in linux-2.6-xen.git looks identical, please try this patch.
 
yes, porting it to an upstream kernel should be trivial