From: "Henrik Rydberg" <rydberg@euromail.se>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] Input: wm831x-ts - Default pressure measurements on
Date: Wed, 9 Mar 2011 15:11:39 +0100 [thread overview]
Message-ID: <20110309141139.GA5482@polaris.bitmath.org> (raw)
In-Reply-To: <1299679112-15245-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark,
> tslib expects pressure measurements so enable them by default for better
> compatibility.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
I cannot speak for the rationale of this patch, but logically,
> drivers/input/touchscreen/wm831x-ts.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/wm831x-ts.c b/drivers/input/touchscreen/wm831x-ts.c
> index 3c397c8..560200d 100644
> --- a/drivers/input/touchscreen/wm831x-ts.c
> +++ b/drivers/input/touchscreen/wm831x-ts.c
> @@ -259,7 +259,10 @@ static __devinit int wm831x_ts_probe(struct platform_device *pdev)
> else
> wm831x_ts->pd_irq = platform_get_irq_byname(pdev, "TCHPD");
>
> - wm831x_ts->pressure = pdata && pdata->pressure;
> + if (pdata)
> + wm831x_ts->pressure = pdata->pressure;
> + else
> + wm831x_ts->pressure = true;
wm831x_ts->pressure = !pdata || pdata->pressure;
should suffice.
Henrik
next prev parent reply other threads:[~2011-03-09 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 13:58 [PATCH] Input: wm831x-ts - Default pressure measurements on Mark Brown
2011-03-09 14:11 ` Henrik Rydberg [this message]
2011-03-09 14:28 ` Mark Brown
2011-03-09 14:40 ` Henrik Rydberg
2011-03-13 6:28 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309141139.GA5482@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.