All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] Input: wm831x-ts - Default pressure measurements on
Date: Wed, 9 Mar 2011 15:40:18 +0100	[thread overview]
Message-ID: <20110309144018.GA5881@polaris.bitmath.org> (raw)
In-Reply-To: <20110309142813.GA24877@opensource.wolfsonmicro.com>

On Wed, Mar 09, 2011 at 02:28:13PM +0000, Mark Brown wrote:
> On Wed, Mar 09, 2011 at 03:11:39PM +0100, Henrik Rydberg wrote:
> 
> > > -	wm831x_ts->pressure = pdata && pdata->pressure;
> > > +	if (pdata)
> > > +		wm831x_ts->pressure = pdata->pressure;
> > > +	else
> > > +		wm831x_ts->pressure = true;
> 
> > wm831x_ts->pressure = !pdata || pdata->pressure;
> 
> > should suffice.
> 
> It does have some substantial drawbacks in terms of legibility, though.

I suppose that is in the eye of the beholder.

Henrik

  reply	other threads:[~2011-03-09 14:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09 13:58 [PATCH] Input: wm831x-ts - Default pressure measurements on Mark Brown
2011-03-09 14:11 ` Henrik Rydberg
2011-03-09 14:28   ` Mark Brown
2011-03-09 14:40     ` Henrik Rydberg [this message]
2011-03-13  6:28       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110309144018.GA5881@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.