From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: ian.campbell@citrix.com, akpm@linux-foundation.org,
andi.kleen@intel.com, haicheng.li@linux.intel.com,
fengguang.wu@intel.com, jeremy@goop.org,
dan.magenheimer@oracle.com, v.tolstov@selfip.ru, pasik@iki.fi,
dave@linux.vnet.ibm.com, wdauchy@gmail.com, rientjes@google.com,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [Xen-devel] [PATCH R4 7/7] xen/balloon: Memory hotplug support for Xen balloon driver
Date: Wed, 9 Mar 2011 15:14:03 -0500 [thread overview]
Message-ID: <20110309201403.GJ8049@dumpdata.com> (raw)
In-Reply-To: <20110308215049.GH27331@router-fw-old.local.net-space.pl>
> - credit = current_target() - balloon_stats.current_pages;
> + credit = current_credit();
>
> - if (credit > 0)
> - state = increase_reservation(credit);
> + if (credit > 0) {
> + if (balloon_is_inflated())
> + state = increase_reservation(credit);
> + else
> + state = reserve_additional_memory(credit);
> + }
This code manipulation of where the current_target becomes current_credit
(and that logic) should be split off in its own patch.
Otherwise all the patches that touch Xen code look good.
>
> if (credit < 0)
> state = decrease_reservation(-credit);
> @@ -458,6 +594,14 @@ static int __init balloon_init(void)
> balloon_stats.retry_count = 1;
> balloon_stats.max_retry_count = 16;
>
> +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> + balloon_stats.hotplug_pages = 0;
> + balloon_stats.balloon_hotplug = 0;
> +
> + register_online_page_notifier(&xen_online_page_nb);
> + register_memory_notifier(&xen_memory_nb);
> +#endif
> +
> register_balloon(&balloon_sysdev);
>
> /*
> --
> 1.5.6.5
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: ian.campbell@citrix.com, akpm@linux-foundation.org,
andi.kleen@intel.com, haicheng.li@linux.intel.com,
fengguang.wu@intel.com, jeremy@goop.org,
dan.magenheimer@oracle.com, v.tolstov@selfip.ru, pasik@iki.fi,
dave@linux.vnet.ibm.com, wdauchy@gmail.com, rientjes@google.com,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [Xen-devel] [PATCH R4 7/7] xen/balloon: Memory hotplug support for Xen balloon driver
Date: Wed, 9 Mar 2011 15:14:03 -0500 [thread overview]
Message-ID: <20110309201403.GJ8049@dumpdata.com> (raw)
In-Reply-To: <20110308215049.GH27331@router-fw-old.local.net-space.pl>
> - credit = current_target() - balloon_stats.current_pages;
> + credit = current_credit();
>
> - if (credit > 0)
> - state = increase_reservation(credit);
> + if (credit > 0) {
> + if (balloon_is_inflated())
> + state = increase_reservation(credit);
> + else
> + state = reserve_additional_memory(credit);
> + }
This code manipulation of where the current_target becomes current_credit
(and that logic) should be split off in its own patch.
Otherwise all the patches that touch Xen code look good.
>
> if (credit < 0)
> state = decrease_reservation(-credit);
> @@ -458,6 +594,14 @@ static int __init balloon_init(void)
> balloon_stats.retry_count = 1;
> balloon_stats.max_retry_count = 16;
>
> +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> + balloon_stats.hotplug_pages = 0;
> + balloon_stats.balloon_hotplug = 0;
> +
> + register_online_page_notifier(&xen_online_page_nb);
> + register_memory_notifier(&xen_memory_nb);
> +#endif
> +
> register_balloon(&balloon_sysdev);
>
> /*
> --
> 1.5.6.5
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-09 20:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 21:50 [PATCH R4 7/7] xen/balloon: Memory hotplug support for Xen balloon driver Daniel Kiper
2011-03-08 21:50 ` Daniel Kiper
2011-03-09 0:02 ` Dave Hansen
2011-03-09 0:02 ` Dave Hansen
2011-03-10 9:02 ` Daniel Kiper
2011-03-10 9:02 ` Daniel Kiper
2011-03-10 14:59 ` Dave Hansen
2011-03-10 14:59 ` Dave Hansen
2011-03-09 20:14 ` Konrad Rzeszutek Wilk [this message]
2011-03-09 20:14 ` [Xen-devel] " Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309201403.GJ8049@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=dan.magenheimer@oracle.com \
--cc=dave@linux.vnet.ibm.com \
--cc=dkiper@net-space.pl \
--cc=fengguang.wu@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasik@iki.fi \
--cc=rientjes@google.com \
--cc=v.tolstov@selfip.ru \
--cc=wdauchy@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.