From: Tony Lindgren <tony@atomide.com>
To: Sricharan R <r.sricharan@ti.com>
Cc: linux-omap@vger.kernel.org, Benoit Cousson <b-cousson@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
paul@pswan.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag)
Date: Wed, 9 Mar 2011 12:32:00 -0800 [thread overview]
Message-ID: <20110309203200.GP26463@atomide.com> (raw)
In-Reply-To: <b76e32aff88265d31cc1b7b2fc502a32@mail.gmail.com>
* Sricharan R <r.sricharan@ti.com> [110309 03:47]:
>
> Btw,I have fixed the comments on the below patches that
> I sent for configuring the serial pads.
>
> 4430sdp:
> http://marc.info/?l=linux-omap&m=129900334420003&w=2
>
> omap4panda:
> http://marc.info/?l=linux-omap&m=129900338520082&w=2
>
> 3430sdp:
> http://marc.info/?l=linux-omap&m=129619117726479&w=2
>
> Can you please check if they are ok?
Look OK to me, but let's make things a bit easier to read
and maintain with the following patch. Can you please
update your patches to use this macro?
Each line then just becomes something like:
OMAP_MUX_STATIC("uart3_tx_irtx.uart3_tx_irtx",
OMAP_PIN_OUTPUT | OMAP_MUX_MODE0),
Regards,
Tony
From: Tony Lindgren <tony@atomide.com>
Date: Wed, 9 Mar 2011 12:14:04 -0800
Subject: [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init
Add macro for defining static pins in the board file.
We can now start implementing pin multiplexing in the platform init
code for devices that call omap_hwmod_mux_init. Currently that is
only implemented for serial.c.
Signed-off-by: Tony Lindgren <tony@atomide.com>
--- a/arch/arm/mach-omap2/mux.h
+++ b/arch/arm/mach-omap2/mux.h
@@ -186,6 +186,12 @@ struct omap_device_pad {
struct omap_hwmod_mux_info;
+#define OMAP_MUX_STATIC(signal, mode) \
+{ \
+ .name = (signal), \
+ .enable = (mode), \
+}
+
#if defined(CONFIG_OMAP_MUX)
/**
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag)
Date: Wed, 9 Mar 2011 12:32:00 -0800 [thread overview]
Message-ID: <20110309203200.GP26463@atomide.com> (raw)
In-Reply-To: <b76e32aff88265d31cc1b7b2fc502a32@mail.gmail.com>
* Sricharan R <r.sricharan@ti.com> [110309 03:47]:
>
> Btw,I have fixed the comments on the below patches that
> I sent for configuring the serial pads.
>
> 4430sdp:
> http://marc.info/?l=linux-omap&m=129900334420003&w=2
>
> omap4panda:
> http://marc.info/?l=linux-omap&m=129900338520082&w=2
>
> 3430sdp:
> http://marc.info/?l=linux-omap&m=129619117726479&w=2
>
> Can you please check if they are ok?
Look OK to me, but let's make things a bit easier to read
and maintain with the following patch. Can you please
update your patches to use this macro?
Each line then just becomes something like:
OMAP_MUX_STATIC("uart3_tx_irtx.uart3_tx_irtx",
OMAP_PIN_OUTPUT | OMAP_MUX_MODE0),
Regards,
Tony
From: Tony Lindgren <tony@atomide.com>
Date: Wed, 9 Mar 2011 12:14:04 -0800
Subject: [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init
Add macro for defining static pins in the board file.
We can now start implementing pin multiplexing in the platform init
code for devices that call omap_hwmod_mux_init. Currently that is
only implemented for serial.c.
Signed-off-by: Tony Lindgren <tony@atomide.com>
--- a/arch/arm/mach-omap2/mux.h
+++ b/arch/arm/mach-omap2/mux.h
@@ -186,6 +186,12 @@ struct omap_device_pad {
struct omap_hwmod_mux_info;
+#define OMAP_MUX_STATIC(signal, mode) \
+{ \
+ .name = (signal), \
+ .enable = (mode), \
+}
+
#if defined(CONFIG_OMAP_MUX)
/**
next prev parent reply other threads:[~2011-03-09 20:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 4:35 [PATCH] omap2+: mux: Remove the use of IDLE flag sricharan
2011-03-08 16:40 ` Tony Lindgren
2011-03-09 7:49 ` Sricharan R
2011-03-09 7:49 ` Sricharan R
2011-03-09 11:49 ` Sricharan R
2011-03-09 11:49 ` Sricharan R
2011-03-09 20:32 ` Tony Lindgren [this message]
2011-03-09 20:32 ` [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) Tony Lindgren
2011-03-10 4:26 ` Sricharan R
2011-03-10 4:26 ` Sricharan R
2011-03-11 6:13 ` Sricharan R
2011-03-11 6:13 ` Sricharan R
2011-03-11 19:35 ` Tony Lindgren
2011-03-11 19:35 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309203200.GP26463@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pswan.com \
--cc=r.sricharan@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.