* [Bridge] [PATCH] bridge: skip forwarding delay if not using STP
@ 2011-03-10 15:57 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2011-03-10 15:57 UTC (permalink / raw)
To: David Miller; +Cc: netdev, bridge
f Spanning Tree Protocol is not enabled, there is no good reason for
the bridge code to wait for the forwarding delay period before enabling
the link. The purpose of the forwarding delay is to allow STP to
learn about other bridges before nominating itself.
The only possible impact is that when starting up a new port
the bridge may flood a packet now, where previously it might have
seen traffic from the other host and preseeded the forwarding table.
Includes change for local variable br already available in that func.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/bridge/br_stp.c 2011-03-07 14:56:45.660973568 -0800
+++ b/net/bridge/br_stp.c 2011-03-07 14:57:47.373590362 -0800
@@ -375,12 +375,12 @@ static void br_make_forwarding(struct ne
if (p->state != BR_STATE_BLOCKING)
return;
- if (br->forward_delay == 0) {
+ if (br->stp_enabled == BR_NO_STP || br->forward_delay == 0) {
p->state = BR_STATE_FORWARDING;
br_topology_change_detection(br);
del_timer(&p->forward_delay_timer);
}
- else if (p->br->stp_enabled == BR_KERNEL_STP)
+ else if (br->stp_enabled == BR_KERNEL_STP)
p->state = BR_STATE_LISTENING;
else
p->state = BR_STATE_LEARNING;
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] bridge: skip forwarding delay if not using STP
@ 2011-03-10 15:57 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2011-03-10 15:57 UTC (permalink / raw)
To: David Miller; +Cc: bridge, netdev
f Spanning Tree Protocol is not enabled, there is no good reason for
the bridge code to wait for the forwarding delay period before enabling
the link. The purpose of the forwarding delay is to allow STP to
learn about other bridges before nominating itself.
The only possible impact is that when starting up a new port
the bridge may flood a packet now, where previously it might have
seen traffic from the other host and preseeded the forwarding table.
Includes change for local variable br already available in that func.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/bridge/br_stp.c 2011-03-07 14:56:45.660973568 -0800
+++ b/net/bridge/br_stp.c 2011-03-07 14:57:47.373590362 -0800
@@ -375,12 +375,12 @@ static void br_make_forwarding(struct ne
if (p->state != BR_STATE_BLOCKING)
return;
- if (br->forward_delay == 0) {
+ if (br->stp_enabled == BR_NO_STP || br->forward_delay == 0) {
p->state = BR_STATE_FORWARDING;
br_topology_change_detection(br);
del_timer(&p->forward_delay_timer);
}
- else if (p->br->stp_enabled == BR_KERNEL_STP)
+ else if (br->stp_enabled == BR_KERNEL_STP)
p->state = BR_STATE_LISTENING;
else
p->state = BR_STATE_LEARNING;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Bridge] [PATCH] bridge: skip forwarding delay if not using STP
2011-03-10 15:57 ` Stephen Hemminger
@ 2011-03-14 22:07 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-03-14 22:07 UTC (permalink / raw)
To: shemminger; +Cc: netdev, bridge
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 10 Mar 2011 07:57:04 -0800
> If Spanning Tree Protocol is not enabled, there is no good reason for
> the bridge code to wait for the forwarding delay period before enabling
> the link. The purpose of the forwarding delay is to allow STP to
> learn about other bridges before nominating itself.
>
> The only possible impact is that when starting up a new port
> the bridge may flood a packet now, where previously it might have
> seen traffic from the other host and preseeded the forwarding table.
>
> Includes change for local variable br already available in that func.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied to net-2.6, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bridge: skip forwarding delay if not using STP
@ 2011-03-14 22:07 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-03-14 22:07 UTC (permalink / raw)
To: shemminger; +Cc: bridge, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 10 Mar 2011 07:57:04 -0800
> If Spanning Tree Protocol is not enabled, there is no good reason for
> the bridge code to wait for the forwarding delay period before enabling
> the link. The purpose of the forwarding delay is to allow STP to
> learn about other bridges before nominating itself.
>
> The only possible impact is that when starting up a new port
> the bridge may flood a packet now, where previously it might have
> seen traffic from the other host and preseeded the forwarding table.
>
> Includes change for local variable br already available in that func.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied to net-2.6, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-14 22:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-10 15:57 [Bridge] [PATCH] bridge: skip forwarding delay if not using STP Stephen Hemminger
2011-03-10 15:57 ` Stephen Hemminger
2011-03-14 22:07 ` [Bridge] " David Miller
2011-03-14 22:07 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.