All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Reisner <philipp.reisner@linbit.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [GIT PULL] DRBD bits for 2.6.39
Date: Thu, 10 Mar 2011 13:10:38 +0100	[thread overview]
Message-ID: <201103101310.39012.philipp.reisner@linbit.com> (raw)
In-Reply-To: <4D78B54B.2060803@kernel.dk>

[...]
> 
> Now that I have your attention... Did you look at the plugging changes?

You always have it :)
I looked at the changes, and I noticed that we no longer get the unplug
events. 

> As Christoph mentioned, you seem to be passing plugging information on
> the wire. What is the reason for that? With the on-stack plugging, these
> events are not seen by the block device anymore.
> 

Imagine DRBD in synchronous mode (protocol C in DRBD speak) on an older
kernel. We mirror a write, in order to get the write-ack packet from the
peer, the peer needs to unplug as well. -> Send the unplug events via the
wire.

Now, it we would connect a current-head-of-git DRBD on one node to
a older one (which still needs unplug packets to respond quickly),
we would have a tar pit block device. (At least for single synchronous
writes)

We are in brainstorming mode right now here.
One idea is to have a timer, that gets touched with every request we get
in, in case it expires, we send out a unplug event over the wire.

But having the unplug events would be more elegant of course...

Best,
 Phil
-- 
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com

DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.

WARNING: multiple messages have this Message-ID (diff)
From: Philipp Reisner <philipp.reisner@linbit.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [GIT PULL] DRBD bits for 2.6.39
Date: Thu, 10 Mar 2011 13:10:38 +0100	[thread overview]
Message-ID: <201103101310.39012.philipp.reisner@linbit.com> (raw)
In-Reply-To: <4D78B54B.2060803@kernel.dk>

[...]
> 
> Now that I have your attention... Did you look at the plugging changes?

You always have it :)
I looked at the changes, and I noticed that we no longer get the unplug
events. 

> As Christoph mentioned, you seem to be passing plugging information on
> the wire. What is the reason for that? With the on-stack plugging, these
> events are not seen by the block device anymore.
> 

Imagine DRBD in synchronous mode (protocol C in DRBD speak) on an older
kernel. We mirror a write, in order to get the write-ack packet from the
peer, the peer needs to unplug as well. -> Send the unplug events via the
wire.

Now, it we would connect a current-head-of-git DRBD on one node to
a older one (which still needs unplug packets to respond quickly),
we would have a tar pit block device. (At least for single synchronous
writes)

We are in brainstorming mode right now here.
One idea is to have a timer, that gets touched with every request we get
in, in case it expires, we send out a unplug event over the wire.

But having the unplug events would be more elegant of course...

Best,
 Phil
-- 
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com

DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.

  reply	other threads:[~2011-03-10 12:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09 14:23 [Drbd-dev] [GIT PULL] DRBD bits for 2.6.39 Philipp Reisner
2011-03-09 14:23 ` Philipp Reisner
2011-03-10  9:50 ` [Drbd-dev] " Jens Axboe
2011-03-10  9:50   ` Jens Axboe
2011-03-10 11:00   ` [Drbd-dev] " Philipp Reisner
2011-03-10 11:00     ` Philipp Reisner
2011-03-10 11:26     ` [Drbd-dev] " Jens Axboe
2011-03-10 11:26       ` Jens Axboe
2011-03-10 12:10       ` Philipp Reisner [this message]
2011-03-10 12:10         ` Philipp Reisner
2011-03-10 13:16         ` [Drbd-dev] " Jens Axboe
2011-03-10 13:16           ` Jens Axboe
2011-03-10 15:04           ` [Drbd-dev] " Philipp Reisner
2011-03-10 15:04             ` Philipp Reisner
2011-03-10 15:20             ` [Drbd-dev] " Jens Axboe
2011-03-10 15:20               ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103101310.39012.philipp.reisner@linbit.com \
    --to=philipp.reisner@linbit.com \
    --cc=axboe@kernel.dk \
    --cc=drbd-dev@lists.linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.