* [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 @ 2011-02-25 5:19 ` Keng-Yu Lin 0 siblings, 0 replies; 17+ messages in thread From: Keng-Yu Lin @ 2011-02-25 5:19 UTC (permalink / raw) To: Corentin Chary, Matthew Garrett, acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: tyson.chen-Z7WLFzj8eWMS+FvcfC7Uqw, Keng-Yu Lin Signed-off-by: Keng-Yu Lin <keng-yu.lin-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> --- drivers/platform/x86/eeepc-wmi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) https://bugs.freedesktop.org/show_bug.cgi?id=31333 diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c index d399775..da00cbc 100644 --- a/drivers/platform/x86/eeepc-wmi.c +++ b/drivers/platform/x86/eeepc-wmi.c @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { { KE_KEY, 0x32, { KEY_MUTE } }, { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ { KE_KEY, 0x5d, { KEY_WLAN } }, - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ + { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */ { KE_KEY, 0x82, { KEY_CAMERA } }, { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, { KE_KEY, 0x88, { KEY_WLAN } }, -- 1.7.1 ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 @ 2011-02-25 5:19 ` Keng-Yu Lin 0 siblings, 0 replies; 17+ messages in thread From: Keng-Yu Lin @ 2011-02-25 5:19 UTC (permalink / raw) To: Corentin Chary, Matthew Garrett, acpi4asus-user, platform-driver-x86, linux-kernel Cc: tyson.chen, Keng-Yu Lin Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com> --- drivers/platform/x86/eeepc-wmi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) https://bugs.freedesktop.org/show_bug.cgi?id=31333 diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c index d399775..da00cbc 100644 --- a/drivers/platform/x86/eeepc-wmi.c +++ b/drivers/platform/x86/eeepc-wmi.c @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { { KE_KEY, 0x32, { KEY_MUTE } }, { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ { KE_KEY, 0x5d, { KEY_WLAN } }, - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ + { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */ { KE_KEY, 0x82, { KEY_CAMERA } }, { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, { KE_KEY, 0x88, { KEY_WLAN } }, -- 1.7.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 2011-02-25 5:19 ` Keng-Yu Lin (?) @ 2011-02-25 6:52 ` Corentin Chary 2011-02-25 7:18 ` Dmitry Torokhov 2011-02-25 14:12 ` Matthew Garrett -1 siblings, 2 replies; 17+ messages in thread From: Corentin Chary @ 2011-02-25 6:52 UTC (permalink / raw) To: Keng-Yu Lin Cc: Matthew Garrett, acpi4asus-user, platform-driver-x86, linux-kernel, tyson.chen, Dmitry Torokhov On Fri, Feb 25, 2011 at 6:19 AM, Keng-Yu Lin <keng-yu.lin@canonical.com> wrote: > Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com> > --- > drivers/platform/x86/eeepc-wmi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > https://bugs.freedesktop.org/show_bug.cgi?id=31333 > > diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c > index d399775..da00cbc 100644 > --- a/drivers/platform/x86/eeepc-wmi.c > +++ b/drivers/platform/x86/eeepc-wmi.c > @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { > { KE_KEY, 0x32, { KEY_MUTE } }, > { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ > { KE_KEY, 0x5d, { KEY_WLAN } }, > - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ > + { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */ > { KE_KEY, 0x82, { KEY_CAMERA } }, > { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, > { KE_KEY, 0x88, { KEY_WLAN } }, Hum, I'm not very comfortable with this patch now that we got KEY_TOUCHPAD_TOGGLE. I know, it doesn't work with current Xorg, but if we continue to workaround that, it'll never be fixed. Dmitry, Matthew, any advice ? -- Corentin Chary http://xf.iksaif.net ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 2011-02-25 6:52 ` Corentin Chary @ 2011-02-25 7:18 ` Dmitry Torokhov 2011-02-25 9:22 ` Keng-Yü Lin 2011-02-25 15:14 ` Chris Bagwell 2011-02-25 14:12 ` Matthew Garrett 1 sibling, 2 replies; 17+ messages in thread From: Dmitry Torokhov @ 2011-02-25 7:18 UTC (permalink / raw) To: Corentin Chary Cc: Keng-Yu Lin, Matthew Garrett, acpi4asus-user, platform-driver-x86, linux-kernel, tyson.chen On Fri, Feb 25, 2011 at 07:52:11AM +0100, Corentin Chary wrote: > On Fri, Feb 25, 2011 at 6:19 AM, Keng-Yu Lin <keng-yu.lin@canonical.com> wrote: > > Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com> > > --- > > drivers/platform/x86/eeepc-wmi.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > https://bugs.freedesktop.org/show_bug.cgi?id=31333 > > > > diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c > > index d399775..da00cbc 100644 > > --- a/drivers/platform/x86/eeepc-wmi.c > > +++ b/drivers/platform/x86/eeepc-wmi.c > > @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { > > { KE_KEY, 0x32, { KEY_MUTE } }, > > { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ > > { KE_KEY, 0x5d, { KEY_WLAN } }, > > - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ > > + { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */ > > { KE_KEY, 0x82, { KEY_CAMERA } }, > > { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, > > { KE_KEY, 0x88, { KEY_WLAN } }, > > Hum, I'm not very comfortable with this patch now that we got > KEY_TOUCHPAD_TOGGLE. > I know, it doesn't work with current Xorg, but if we continue to > workaround that, it'll never be fixed. > > Dmitry, Matthew, any advice ? I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace should use udev's key re-mapping facilities while X is unable to process keycodes above 255 to adjust to the keycode du jour. If all kernel drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much easier (the utility would simply check capabilities for KEY_TOUCHPAD_TOGGLE and do the remap). Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 2011-02-25 7:18 ` Dmitry Torokhov @ 2011-02-25 9:22 ` Keng-Yü Lin [not found] ` <AANLkTim6pxadoTSsNqYV_gmRGOwyFRvfErSvcwRtaavy-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2011-02-25 9:53 ` Martin Pitt 2011-02-25 15:14 ` Chris Bagwell 1 sibling, 2 replies; 17+ messages in thread From: Keng-Yü Lin @ 2011-02-25 9:22 UTC (permalink / raw) To: Dmitry Torokhov, Martin Pitt Cc: Corentin Chary, Matthew Garrett, acpi4asus-user, platform-driver-x86, linux-kernel, tyson.chen On Fri, Feb 25, 2011 at 3:18 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace > should use udev's key re-mapping facilities while X is unable to process > keycodes above 255 to adjust to the keycode du jour. If all kernel > drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much > easier (the utility would simply check capabilities for > KEY_TOUCHPAD_TOGGLE and do the remap). Can udev re-map a key code to another? Am I correct that udev can only re-map a scan code to a specified key code. ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <AANLkTim6pxadoTSsNqYV_gmRGOwyFRvfErSvcwRtaavy-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 2011-02-25 9:22 ` Keng-Yü Lin @ 2011-02-25 9:33 ` Dmitry Torokhov 2011-02-25 9:53 ` Martin Pitt 1 sibling, 0 replies; 17+ messages in thread From: Dmitry Torokhov @ 2011-02-25 9:33 UTC (permalink / raw) To: Keng-Yü Lin Cc: Martin Pitt, acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, linux-kernel-u79uwXL29TY76Z2rM5mHXA, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA, tyson.chen-Z7WLFzj8eWMS+FvcfC7Uqw, Corentin Chary, Matthew Garrett On Fri, Feb 25, 2011 at 05:22:43PM +0800, Keng-Yü Lin wrote: > On Fri, Feb 25, 2011 at 3:18 PM, Dmitry Torokhov > <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace > > should use udev's key re-mapping facilities while X is unable to process > > keycodes above 255 to adjust to the keycode du jour. If all kernel > > drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much > > easier (the utility would simply check capabilities for > > KEY_TOUCHPAD_TOGGLE and do the remap). > > Can udev re-map a key code to another? Not directly. > > Am I correct that udev can only re-map a scan code to a specified key code. Right, so once you determined via capabilities that device emits KEY_TOUCHPAD_TOGGLE you query the keymap (using EVIOCGKEYCODE2; by index) and replace all entries that are mapped to KEY_TOUCHPAD_TOGGLE to whatever you want. Thanks. -- Dmitry ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 @ 2011-02-25 9:33 ` Dmitry Torokhov 0 siblings, 0 replies; 17+ messages in thread From: Dmitry Torokhov @ 2011-02-25 9:33 UTC (permalink / raw) To: Keng-Yü Lin Cc: Martin Pitt, Corentin Chary, Matthew Garrett, acpi4asus-user, platform-driver-x86, linux-kernel, tyson.chen On Fri, Feb 25, 2011 at 05:22:43PM +0800, Keng-Yü Lin wrote: > On Fri, Feb 25, 2011 at 3:18 PM, Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace > > should use udev's key re-mapping facilities while X is unable to process > > keycodes above 255 to adjust to the keycode du jour. If all kernel > > drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much > > easier (the utility would simply check capabilities for > > KEY_TOUCHPAD_TOGGLE and do the remap). > > Can udev re-map a key code to another? Not directly. > > Am I correct that udev can only re-map a scan code to a specified key code. Right, so once you determined via capabilities that device emits KEY_TOUCHPAD_TOGGLE you query the keymap (using EVIOCGKEYCODE2; by index) and replace all entries that are mapped to KEY_TOUCHPAD_TOGGLE to whatever you want. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 2011-02-25 9:22 ` Keng-Yü Lin [not found] ` <AANLkTim6pxadoTSsNqYV_gmRGOwyFRvfErSvcwRtaavy-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2011-02-25 9:53 ` Martin Pitt 1 sibling, 0 replies; 17+ messages in thread From: Martin Pitt @ 2011-02-25 9:53 UTC (permalink / raw) To: Keng-Yü Lin Cc: Dmitry Torokhov, Corentin Chary, Matthew Garrett, acpi4asus-user, platform-driver-x86, linux-kernel, tyson.chen Keng-Yü Lin [2011-02-25 17:22 +0800]: > Can udev re-map a key code to another? Not directly, as udev itself doesn't actually process the input events. It just pokes the scan code -> keycode map into the kernel. What it can do is to re-map an existing key (scan code) to a different key code, which provides the same effect in most cases. Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 2011-02-25 7:18 ` Dmitry Torokhov 2011-02-25 9:22 ` Keng-Yü Lin @ 2011-02-25 15:14 ` Chris Bagwell 2011-02-25 22:25 ` Joey Lee 2011-03-01 3:29 ` Keng-Yü Lin 1 sibling, 2 replies; 17+ messages in thread From: Chris Bagwell @ 2011-02-25 15:14 UTC (permalink / raw) To: Dmitry Torokhov Cc: Corentin Chary, Keng-Yu Lin, Matthew Garrett, acpi4asus-user, platform-driver-x86, linux-kernel, tyson.chen On Fri, Feb 25, 2011 at 1:18 AM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Fri, Feb 25, 2011 at 07:52:11AM +0100, Corentin Chary wrote: >> On Fri, Feb 25, 2011 at 6:19 AM, Keng-Yu Lin <keng-yu.lin@canonical.com> wrote: >> > Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com> >> > --- >> > drivers/platform/x86/eeepc-wmi.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > https://bugs.freedesktop.org/show_bug.cgi?id=31333 >> > >> > diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c >> > index d399775..da00cbc 100644 >> > --- a/drivers/platform/x86/eeepc-wmi.c >> > +++ b/drivers/platform/x86/eeepc-wmi.c >> > @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { >> > { KE_KEY, 0x32, { KEY_MUTE } }, >> > { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ >> > { KE_KEY, 0x5d, { KEY_WLAN } }, >> > - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ >> > + { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */ >> > { KE_KEY, 0x82, { KEY_CAMERA } }, >> > { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, >> > { KE_KEY, 0x88, { KEY_WLAN } }, >> >> Hum, I'm not very comfortable with this patch now that we got >> KEY_TOUCHPAD_TOGGLE. >> I know, it doesn't work with current Xorg, but if we continue to >> workaround that, it'll never be fixed. >> >> Dmitry, Matthew, any advice ? > > I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace > should use udev's key re-mapping facilities while X is unable to process > keycodes above 255 to adjust to the keycode du jour. If all kernel > drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much > easier (the utility would simply check capabilities for > KEY_TOUCHPAD_TOGGLE and do the remap). I submitted last month a patch to udev to do the scancode-to-F21 mapping. So that part should be covered for near term. I also agree if we are going to change kernel side, we should change to KEY_TOUCHPAD_TOGGLE in both eeepc-laptop and eeepc-wmi. http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=0d8b6be5f5238360d2d8e220d6da280f842c5358 Chris ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 2011-02-25 15:14 ` Chris Bagwell @ 2011-02-25 22:25 ` Joey Lee 2011-03-01 3:29 ` Keng-Yü Lin 1 sibling, 0 replies; 17+ messages in thread From: Joey Lee @ 2011-02-25 22:25 UTC (permalink / raw) To: chris Cc: keng-yu.lin, tyson.chen, corentin.chary, dmitry.torokhov, acpi4asus-user, Joey Lee, mjg, linux-kernel, platform-driver-x86 於 五，2011-02-25 於 09:14 -0600，Chris Bagwell 提到： > On Fri, Feb 25, 2011 at 1:18 AM, Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > On Fri, Feb 25, 2011 at 07:52:11AM +0100, Corentin Chary wrote: > >> On Fri, Feb 25, 2011 at 6:19 AM, Keng-Yu Lin <keng-yu.lin@canonical.com> wrote: > >> > Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com> > >> > --- > >> > drivers/platform/x86/eeepc-wmi.c | 2 +- > >> > 1 files changed, 1 insertions(+), 1 deletions(-) > >> > > >> > https://bugs.freedesktop.org/show_bug.cgi?id=31333 > >> > > >> > diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c > >> > index d399775..da00cbc 100644 > >> > --- a/drivers/platform/x86/eeepc-wmi.c > >> > +++ b/drivers/platform/x86/eeepc-wmi.c > >> > @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { > >> > { KE_KEY, 0x32, { KEY_MUTE } }, > >> > { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ > >> > { KE_KEY, 0x5d, { KEY_WLAN } }, > >> > - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ > >> > + { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */ > >> > { KE_KEY, 0x82, { KEY_CAMERA } }, > >> > { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, > >> > { KE_KEY, 0x88, { KEY_WLAN } }, > >> > >> Hum, I'm not very comfortable with this patch now that we got > >> KEY_TOUCHPAD_TOGGLE. > >> I know, it doesn't work with current Xorg, but if we continue to > >> workaround that, it'll never be fixed. > >> > >> Dmitry, Matthew, any advice ? > > > > I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace > > should use udev's key re-mapping facilities while X is unable to process > > keycodes above 255 to adjust to the keycode du jour. If all kernel > > drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much > > easier (the utility would simply check capabilities for > > KEY_TOUCHPAD_TOGGLE and do the remap). > > I submitted last month a patch to udev to do the scancode-to-F21 > mapping. So that part should be covered for near term. > > I also agree if we are going to change kernel side, we should change > to KEY_TOUCHPAD_TOGGLE in both eeepc-laptop and eeepc-wmi. > > http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=0d8b6be5f5238360d2d8e220d6da280f842c5358 > Found acer-wmi also have Touchpad toggle but mapping to F22 {KE_KEY, 0x82, {KEY_F22} }, /* Touch Pad On/Off */ Will also send patch to udev keymap first, then change the wmi driver mapping to KEY_TOUCHPAD_TOGGLE. Thank's Joey Lee ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 @ 2011-02-25 22:25 ` Joey Lee 0 siblings, 0 replies; 17+ messages in thread From: Joey Lee @ 2011-02-25 22:25 UTC (permalink / raw) To: chris Cc: keng-yu.lin, tyson.chen, corentin.chary, dmitry.torokhov, acpi4asus-user, Joey Lee, mjg, linux-kernel, platform-driver-x86 於 五，2011-02-25 於 09:14 -0600，Chris Bagwell 提到： > On Fri, Feb 25, 2011 at 1:18 AM, Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > On Fri, Feb 25, 2011 at 07:52:11AM +0100, Corentin Chary wrote: > >> On Fri, Feb 25, 2011 at 6:19 AM, Keng-Yu Lin <keng-yu.lin@canonical.com> wrote: > >> > Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com> > >> > --- > >> > drivers/platform/x86/eeepc-wmi.c | 2 +- > >> > 1 files changed, 1 insertions(+), 1 deletions(-) > >> > > >> > https://bugs.freedesktop.org/show_bug.cgi?id=31333 > >> > > >> > diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c > >> > index d399775..da00cbc 100644 > >> > --- a/drivers/platform/x86/eeepc-wmi.c > >> > +++ b/drivers/platform/x86/eeepc-wmi.c > >> > @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { > >> > { KE_KEY, 0x32, { KEY_MUTE } }, > >> > { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ > >> > { KE_KEY, 0x5d, { KEY_WLAN } }, > >> > - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ > >> > + { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */ > >> > { KE_KEY, 0x82, { KEY_CAMERA } }, > >> > { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, > >> > { KE_KEY, 0x88, { KEY_WLAN } }, > >> > >> Hum, I'm not very comfortable with this patch now that we got > >> KEY_TOUCHPAD_TOGGLE. > >> I know, it doesn't work with current Xorg, but if we continue to > >> workaround that, it'll never be fixed. > >> > >> Dmitry, Matthew, any advice ? > > > > I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace > > should use udev's key re-mapping facilities while X is unable to process > > keycodes above 255 to adjust to the keycode du jour. If all kernel > > drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much > > easier (the utility would simply check capabilities for > > KEY_TOUCHPAD_TOGGLE and do the remap). > > I submitted last month a patch to udev to do the scancode-to-F21 > mapping. So that part should be covered for near term. > > I also agree if we are going to change kernel side, we should change > to KEY_TOUCHPAD_TOGGLE in both eeepc-laptop and eeepc-wmi. > > http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=0d8b6be5f5238360d2d8e220d6da280f842c5358 > Found acer-wmi also have Touchpad toggle but mapping to F22 {KE_KEY, 0x82, {KEY_F22} }, /* Touch Pad On/Off */ Will also send patch to udev keymap first, then change the wmi driver mapping to KEY_TOUCHPAD_TOGGLE. Thank's Joey Lee ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 2011-02-25 15:14 ` Chris Bagwell 2011-02-25 22:25 ` Joey Lee @ 2011-03-01 3:29 ` Keng-Yü Lin 1 sibling, 0 replies; 17+ messages in thread From: Keng-Yü Lin @ 2011-03-01 3:29 UTC (permalink / raw) To: Chris Bagwell Cc: Dmitry Torokhov, Corentin Chary, Matthew Garrett, acpi4asus-user, platform-driver-x86, linux-kernel, tyson.chen On Fri, Feb 25, 2011 at 11:14 PM, Chris Bagwell <chris@cnpbagwell.com> wrote: > > I submitted last month a patch to udev to do the scancode-to-F21 > mapping. So that part should be covered for near term. > > I also agree if we are going to change kernel side, we should change > to KEY_TOUCHPAD_TOGGLE in both eeepc-laptop and eeepc-wmi. > > http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=0d8b6be5f5238360d2d8e220d6da280f842c5358 > > Chris > Thanks Chris for the information. I also tested; it works. I will re-send a eeepc-wmi patch with KEY_TOUCHPAD_TOGGLE. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 2011-02-25 6:52 ` Corentin Chary 2011-02-25 7:18 ` Dmitry Torokhov @ 2011-02-25 14:12 ` Matthew Garrett 1 sibling, 0 replies; 17+ messages in thread From: Matthew Garrett @ 2011-02-25 14:12 UTC (permalink / raw) To: Corentin Chary Cc: Keng-Yu Lin, acpi4asus-user, platform-driver-x86, linux-kernel, tyson.chen, Dmitry Torokhov On Fri, Feb 25, 2011 at 07:52:11AM +0100, Corentin Chary wrote: > Hum, I'm not very comfortable with this patch now that we got > KEY_TOUCHPAD_TOGGLE. > I know, it doesn't work with current Xorg, but if we continue to > workaround that, it'll never be fixed. > > Dmitry, Matthew, any advice ? Yeah, I'd go with Dmitry's idea for now. -- Matthew Garrett | mjg59@srcf.ucam.org ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <1298611140-21573-1-git-send-email-keng-yu.lin-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>]
* [PATCH v2] eeepc-wmi: set the touchpad toggle key code to KEY_TOUCHPAD_TOGGLE 2011-02-25 5:19 ` Keng-Yu Lin @ 2011-03-01 4:56 ` Keng-Yu Lin -1 siblings, 0 replies; 17+ messages in thread From: Keng-Yu Lin @ 2011-03-01 4:56 UTC (permalink / raw) To: Corentin Chary, Matthew Garrett, acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Chris Bagwell, tyson.chen-Z7WLFzj8eWMS+FvcfC7Uqw, Keng-Yu Lin, Martin Pitt Signed-off-by: Keng-Yu Lin <keng-yu.lin-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> --- drivers/platform/x86/eeepc-wmi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c index d399775..a9f75e2 100644 --- a/drivers/platform/x86/eeepc-wmi.c +++ b/drivers/platform/x86/eeepc-wmi.c @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { { KE_KEY, 0x32, { KEY_MUTE } }, { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ { KE_KEY, 0x5d, { KEY_WLAN } }, - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ + { KE_KEY, 0x6b, { KEY_TOUCHPAD_TOGGLE } }, /* Toggle Touchpad */ { KE_KEY, 0x82, { KEY_CAMERA } }, { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, { KE_KEY, 0x88, { KEY_WLAN } }, -- 1.7.1 ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2] eeepc-wmi: set the touchpad toggle key code to KEY_TOUCHPAD_TOGGLE @ 2011-03-01 4:56 ` Keng-Yu Lin 0 siblings, 0 replies; 17+ messages in thread From: Keng-Yu Lin @ 2011-03-01 4:56 UTC (permalink / raw) To: Corentin Chary, Matthew Garrett, acpi4asus-user, platform-driver-x86, linux-kernel Cc: Chris Bagwell, tyson.chen, Martin Pitt, Keng-Yu Lin Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com> --- drivers/platform/x86/eeepc-wmi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c index d399775..a9f75e2 100644 --- a/drivers/platform/x86/eeepc-wmi.c +++ b/drivers/platform/x86/eeepc-wmi.c @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { { KE_KEY, 0x32, { KEY_MUTE } }, { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ { KE_KEY, 0x5d, { KEY_WLAN } }, - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ + { KE_KEY, 0x6b, { KEY_TOUCHPAD_TOGGLE } }, /* Toggle Touchpad */ { KE_KEY, 0x82, { KEY_CAMERA } }, { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, { KE_KEY, 0x88, { KEY_WLAN } }, -- 1.7.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
[parent not found: <1298955373-5645-1-git-send-email-keng-yu.lin-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>]
* Re: [PATCH v2] eeepc-wmi: set the touchpad toggle key code to KEY_TOUCHPAD_TOGGLE 2011-03-01 4:56 ` Keng-Yu Lin @ 2011-03-11 17:31 ` Matthew Garrett -1 siblings, 0 replies; 17+ messages in thread From: Matthew Garrett @ 2011-03-11 17:31 UTC (permalink / raw) To: Keng-Yu Lin Cc: acpi4asus-user-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Chris Bagwell, linux-kernel-u79uwXL29TY76Z2rM5mHXA, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA, tyson.chen-Z7WLFzj8eWMS+FvcfC7Uqw, Martin Pitt Applied, thanks. -- Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] eeepc-wmi: set the touchpad toggle key code to KEY_TOUCHPAD_TOGGLE @ 2011-03-11 17:31 ` Matthew Garrett 0 siblings, 0 replies; 17+ messages in thread From: Matthew Garrett @ 2011-03-11 17:31 UTC (permalink / raw) To: Keng-Yu Lin Cc: Corentin Chary, acpi4asus-user, platform-driver-x86, linux-kernel, Chris Bagwell, tyson.chen, Martin Pitt Applied, thanks. -- Matthew Garrett | mjg59@srcf.ucam.org ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2011-03-11 17:31 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-25 5:19 [PATCH] eeepc-wmi: set the touchpad toggle key code to F21 Keng-Yu Lin
2011-02-25 5:19 ` Keng-Yu Lin
2011-02-25 6:52 ` Corentin Chary
2011-02-25 7:18 ` Dmitry Torokhov
2011-02-25 9:22 ` Keng-Yü Lin
[not found] ` <AANLkTim6pxadoTSsNqYV_gmRGOwyFRvfErSvcwRtaavy-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-25 9:33 ` Dmitry Torokhov
2011-02-25 9:33 ` Dmitry Torokhov
2011-02-25 9:53 ` Martin Pitt
2011-02-25 15:14 ` Chris Bagwell
2011-02-25 22:25 ` Joey Lee
2011-02-25 22:25 ` Joey Lee
2011-03-01 3:29 ` Keng-Yü Lin
2011-02-25 14:12 ` Matthew Garrett
[not found] ` <1298611140-21573-1-git-send-email-keng-yu.lin-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2011-03-01 4:56 ` [PATCH v2] eeepc-wmi: set the touchpad toggle key code to KEY_TOUCHPAD_TOGGLE Keng-Yu Lin
2011-03-01 4:56 ` Keng-Yu Lin
[not found] ` <1298955373-5645-1-git-send-email-keng-yu.lin-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2011-03-11 17:31 ` Matthew Garrett
2011-03-11 17:31 ` Matthew Garrett
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.