From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec
Date: Fri, 11 Mar 2011 18:34:42 -0300 [thread overview]
Message-ID: <20110311213442.GA16222@amt.cnet> (raw)
In-Reply-To: <4D727D22.2030700@web.de>
On Sat, Mar 05, 2011 at 07:12:50PM +0100, Jan Kiszka wrote:
> >> @@ -956,7 +956,6 @@ int kvm_cpu_exec(CPUState *env)
> >> abort();
> >> }
> >>
> >> - ret = 0; /* exit loop */
> >> switch (run->exit_reason) {
> >
> > Better keep ret assignment here so default behaviour is to
> > exit loop? EXCP_INTERRUPT.
>
> There is no real default behavior: in two cases we stay in the loop, in
> two others we leave, and the rest obtains ret from a return value.
> Moreover, if a new case misses to set ret, the compiler will complain.
>
> Jan
It will not complain because "ret" is used to store return value
of KVM_RUN.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec
Date: Fri, 11 Mar 2011 18:34:42 -0300 [thread overview]
Message-ID: <20110311213442.GA16222@amt.cnet> (raw)
In-Reply-To: <4D727D22.2030700@web.de>
On Sat, Mar 05, 2011 at 07:12:50PM +0100, Jan Kiszka wrote:
> >> @@ -956,7 +956,6 @@ int kvm_cpu_exec(CPUState *env)
> >> abort();
> >> }
> >>
> >> - ret = 0; /* exit loop */
> >> switch (run->exit_reason) {
> >
> > Better keep ret assignment here so default behaviour is to
> > exit loop? EXCP_INTERRUPT.
>
> There is no real default behavior: in two cases we stay in the loop, in
> two others we leave, and the rest obtains ret from a return value.
> Moreover, if a new case misses to set ret, the compiler will complain.
>
> Jan
It will not complain because "ret" is used to store return value
of KVM_RUN.
next prev parent reply other threads:[~2011-03-11 21:39 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 10:19 [PATCH 00/15] [uq/master] Patch queue, part V (the rest) Jan Kiszka
2011-03-04 10:19 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:19 ` [PATCH 01/15] Break up user and system cpu_interrupt implementations Jan Kiszka
2011-03-04 10:19 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:19 ` [PATCH 02/15] Redirect cpu_interrupt to callback handler Jan Kiszka
2011-03-04 10:19 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 03/15] kvm: Install optimized interrupt handlers Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-05 15:37 ` Marcelo Tosatti
2011-03-05 15:37 ` [Qemu-devel] " Marcelo Tosatti
2011-03-05 18:11 ` Jan Kiszka
2011-03-05 18:11 ` [Qemu-devel] " Jan Kiszka
2011-03-06 2:13 ` Marcelo Tosatti
2011-03-06 2:13 ` [Qemu-devel] " Marcelo Tosatti
2011-03-07 8:00 ` Jan Kiszka
2011-03-07 8:00 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 04/15] kvm: Add in-kernel irqchip awareness to cpu_thread_is_idle Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 05/15] kvm: x86: Do not leave halt if interrupts are disabled Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 06/15] kvm: Mark VCPU state dirty on creation Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 07/15] x86: Properly reset PAT MSR Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 08/15] x86: Save/restore " Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 09/15] kvm: x86: Synchronize PAT MSR with the kernel Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 10/15] kvm: Consider EXIT_DEBUG unknown without CAP_SET_GUEST_DEBUG Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-05 16:05 ` Marcelo Tosatti
2011-03-05 16:05 ` [Qemu-devel] " Marcelo Tosatti
2011-03-05 18:12 ` Jan Kiszka
2011-03-05 18:12 ` [Qemu-devel] " Jan Kiszka
2011-03-11 21:34 ` Marcelo Tosatti [this message]
2011-03-11 21:34 ` Marcelo Tosatti
2011-03-12 9:16 ` Jan Kiszka
2011-03-12 9:16 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 12/15] kvm: Align kvm_arch_handle_exit to kvm_cpu_exec changes Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-11 6:50 ` Alexander Graf
2011-03-11 6:50 ` [Qemu-devel] " Alexander Graf
2011-03-11 7:13 ` Jan Kiszka
2011-03-11 7:13 ` [Qemu-devel] " Jan Kiszka
2011-03-11 7:26 ` Alexander Graf
2011-03-11 7:26 ` [Qemu-devel] " Alexander Graf
2011-03-11 7:33 ` Jan Kiszka
2011-03-11 7:33 ` [Qemu-devel] " Jan Kiszka
2011-03-11 7:38 ` Alexander Graf
2011-03-11 7:38 ` [Qemu-devel] " Alexander Graf
2011-03-11 7:35 ` Alexander Graf
2011-03-11 7:35 ` [Qemu-devel] " Alexander Graf
2011-03-04 10:20 ` [PATCH 13/15] kvm: x86: Reorder functions in kvm.c Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 14/15] kvm: x86: Push kvm_arch_debug to kvm_arch_handle_exit Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
2011-03-04 10:20 ` [PATCH 15/15] Expose thread_id in info cpus Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110311213442.GA16222@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.