From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Greg KH <greg@kroah.com>
Cc: Nikolai Kondrashov <spbnick@gmail.com>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] Platform: add Samsung Laptop platform driver
Date: Sun, 13 Mar 2011 16:28:12 +0000 [thread overview]
Message-ID: <20110313162812.GA25369@srcf.ucam.org> (raw)
In-Reply-To: <20110313161752.GC10718@kroah.com>
On Sun, Mar 13, 2011 at 09:17:53AM -0700, Greg KH wrote:
> On Sun, Mar 13, 2011 at 12:03:20PM +0200, Nikolai Kondrashov wrote:
> > Sometime ago I've found this hack on some forum, which I use currently
> > to set the brightness:
> >
> > setpci -s 00:02.0 f4.b="$HEX_BYTE"
> >
> > It allows finer control of the brightness, but it seems it operates directly
> > on the video card PCI register. I assume there is no sane way to use
> > this interface from the platform driver, right?
>
> Yes, do not do this, it causes all sorts of problems in the end, not the
> least being the BIOS doesn't know what is going on at all as you are
> changing the brightness without it knowing it.
It's also modifying configuration that belongs to a device being managed
by another driver, so it's the kind of thing we frown upon. Having said
that, the Intel driver should gain native backlight support in .39.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-03-13 16:28 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 22:40 [PATCH] Platform: add Samsung Laptop platform driver Greg KH
2011-02-09 22:44 ` Randy Dunlap
2011-02-09 22:50 ` Greg KH
2011-02-09 22:58 ` Matthew Garrett
2011-02-09 22:50 ` Matthew Garrett
2011-02-09 23:02 ` Greg KH
2011-02-11 9:17 ` Jouke Witteveen
2011-02-11 11:37 ` Richard Schütz
2011-02-11 15:22 ` Greg KH
2011-02-11 16:27 ` Richard Schütz
2011-02-25 21:01 ` Greg KH
2011-02-11 15:45 ` Matthew Garrett
2011-02-11 18:42 ` Greg KH
2011-02-16 10:06 ` Nikolai Kondrashov
2011-02-25 21:03 ` Greg KH
2011-02-25 21:49 ` Nikolai Kondrashov
2011-02-25 22:50 ` Greg KH
2011-03-10 7:00 ` Nikolai Kondrashov
2011-03-10 17:01 ` Greg KH
2011-03-10 17:13 ` Nikolai Kondrashov
2011-03-10 17:19 ` Greg KH
2011-03-10 17:28 ` Nikolai Kondrashov
2011-03-10 18:09 ` Greg KH
2011-03-10 21:05 ` Nikolai Kondrashov
2011-03-10 21:15 ` Greg KH
2011-03-11 7:12 ` Nikolai Kondrashov
2011-03-11 17:03 ` Greg KH
2011-03-11 19:07 ` Nikolai Kondrashov
2011-03-11 19:34 ` Greg KH
2011-03-11 20:20 ` Nikolai Kondrashov
2011-03-11 20:23 ` Nikolai Kondrashov
2011-03-11 20:35 ` Greg KH
2011-03-11 20:30 ` Greg KH
2011-03-13 10:03 ` Nikolai Kondrashov
2011-03-13 10:55 ` Richard Schütz
2011-03-13 13:02 ` Nikolai Kondrashov
2011-03-13 16:18 ` Greg KH
2011-03-13 17:49 ` Nikolai Kondrashov
2011-03-13 17:58 ` Greg KH
2011-03-13 16:17 ` Greg KH
2011-03-13 16:28 ` Matthew Garrett [this message]
2011-03-13 17:51 ` Nikolai Kondrashov
2011-03-13 17:50 ` Nikolai Kondrashov
-- strict thread matches above, loose matches on Subject: below --
2011-02-25 22:47 Greg KH
2011-02-27 15:36 Greg KH
2011-03-05 4:24 Greg KH
2011-03-05 4:24 ` Greg KH
2011-03-11 17:43 ` Matthew Garrett
2011-03-11 19:35 ` Greg KH
2011-03-11 19:44 ` Matthew Garrett
2011-03-11 19:52 ` Greg KH
2011-03-11 19:55 ` Matthew Garrett
2011-03-14 15:18 ` Jörg-Volker Peetz
2011-03-11 17:57 Tommaso Massimi
2011-06-26 15:08 J Witteveen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110313162812.GA25369@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=spbnick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.