All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Schütz" <r.schtz@t-online.de>
To: Greg KH <greg@kroah.com>
Cc: Matthew Garrett <mjg@redhat.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] Platform: add Samsung Laptop platform driver
Date: Fri, 11 Feb 2011 12:37:26 +0100	[thread overview]
Message-ID: <4D551F76.1070303@t-online.de> (raw)
In-Reply-To: <20110209224006.GA11202@kroah.com>

 > +static struct dmi_system_id __initdata samsung_dmi_table[] = {
 > +	{
 > +		.ident = "N128",
 > +		.matches = {
 > +			DMI_MATCH(DMI_SYS_VENDOR,
 > +					"SAMSUNG ELECTRONICS CO., LTD."),
 > +			DMI_MATCH(DMI_PRODUCT_NAME, "N128"),
 > +			DMI_MATCH(DMI_BOARD_NAME, "N128"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +	},
 > +	{
 > +		.ident = "N130",
 > +		.matches = {
 > +			DMI_MATCH(DMI_SYS_VENDOR,
 > +					"SAMSUNG ELECTRONICS CO., LTD."),
 > +			DMI_MATCH(DMI_PRODUCT_NAME, "N130"),
 > +			DMI_MATCH(DMI_BOARD_NAME, "N130"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +	},
 > +	{
 > +		.ident = "X125",
 > +		.matches = {
 > +			DMI_MATCH(DMI_SYS_VENDOR,
 > +					"SAMSUNG ELECTRONICS CO., LTD."),
 > +			DMI_MATCH(DMI_PRODUCT_NAME, "X125"),
 > +			DMI_MATCH(DMI_BOARD_NAME, "X125"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +	},
 > +	{
 > +		.ident = "NC10",
 > +		.matches = {
 > +			DMI_MATCH(DMI_SYS_VENDOR,
 > +					"SAMSUNG ELECTRONICS CO., LTD."),
 > +			DMI_MATCH(DMI_PRODUCT_NAME, "NC10"),
 > +			DMI_MATCH(DMI_BOARD_NAME, "NC10"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +	},
 > +		{
 > +		.ident = "NP-Q45",
 > +		.matches = {
 > +			DMI_MATCH(DMI_SYS_VENDOR,
 > +					"SAMSUNG ELECTRONICS CO., LTD."),
 > +			DMI_MATCH(DMI_PRODUCT_NAME, "SQ45S70S"),
 > +			DMI_MATCH(DMI_BOARD_NAME, "SQ45S70S"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +		},
 > +	{
 > +		.ident = "X360",
 > +		.matches = {
 > +			DMI_MATCH(DMI_SYS_VENDOR,
 > +					"SAMSUNG ELECTRONICS CO., LTD."),
 > +			DMI_MATCH(DMI_PRODUCT_NAME, "X360"),
 > +			DMI_MATCH(DMI_BOARD_NAME, "X360"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +	},
 > +	{
 > +		.ident = "R518",
 > +		.matches = {
 > +			DMI_MATCH(DMI_SYS_VENDOR,
 > +					"SAMSUNG ELECTRONICS CO., LTD."),
 > +			DMI_MATCH(DMI_PRODUCT_NAME, "R518"),
 > +			DMI_MATCH(DMI_BOARD_NAME, "R518"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +	},
 > +	{
 > +		.ident = "N150/N210/N220",
 > +		.matches = {
 > +			DMI_MATCH(DMI_SYS_VENDOR,
 > +					"SAMSUNG ELECTRONICS CO., LTD."),
 > +			DMI_MATCH(DMI_PRODUCT_NAME, "N150/N210/N220"),
 > +			DMI_MATCH(DMI_BOARD_NAME, "N150/N210/N220"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +	},
 > +	{
 > +		.ident = "R530/R730",
 > +		.matches = {
 > +		      DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
 > +		      DMI_MATCH(DMI_PRODUCT_NAME, "R530/R730"),
 > +		      DMI_MATCH(DMI_BOARD_NAME, "R530/R730"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +	},
 > +	{
 > +		.ident = "NF110/NF210/NF310",
 > +		.matches = {
 > +			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
 > +			DMI_MATCH(DMI_PRODUCT_NAME, "NF110/NF210/NF310"),
 > +			DMI_MATCH(DMI_BOARD_NAME, "NF110/NF210/NF310"),
 > +		},
 > +		.callback = dmi_check_cb,
 > +	},
 > +	{ },
 > +};
 > +MODULE_DEVICE_TABLE(dmi, samsung_dmi_table);

Could you add

.ident = "N145P/N250P/N260P",
.matches = {
	DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
	DMI_MATCH(DMI_PRODUCT_NAME, "N145P/N250P/N260P"),
	DMI_MATCH(DMI_BOARD_NAME, "N145P/N250P/N260P"),
},
.callback = dmi_check_cb,

there, please? I've tested the driver successfully on my N145P.

-- 
Regards,
Richard Schütz

  parent reply	other threads:[~2011-02-11 11:38 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 22:40 [PATCH] Platform: add Samsung Laptop platform driver Greg KH
2011-02-09 22:44 ` Randy Dunlap
2011-02-09 22:50   ` Greg KH
2011-02-09 22:58     ` Matthew Garrett
2011-02-09 22:50 ` Matthew Garrett
2011-02-09 23:02   ` Greg KH
2011-02-11  9:17 ` Jouke Witteveen
2011-02-11 11:37 ` Richard Schütz [this message]
2011-02-11 15:22   ` Greg KH
2011-02-11 16:27     ` Richard Schütz
2011-02-25 21:01       ` Greg KH
2011-02-11 15:45 ` Matthew Garrett
2011-02-11 18:42   ` Greg KH
2011-02-16 10:06 ` Nikolai Kondrashov
2011-02-25 21:03   ` Greg KH
2011-02-25 21:49     ` Nikolai Kondrashov
2011-02-25 22:50       ` Greg KH
2011-03-10  7:00         ` Nikolai Kondrashov
2011-03-10 17:01           ` Greg KH
2011-03-10 17:13             ` Nikolai Kondrashov
2011-03-10 17:19               ` Greg KH
2011-03-10 17:28                 ` Nikolai Kondrashov
2011-03-10 18:09                   ` Greg KH
2011-03-10 21:05                     ` Nikolai Kondrashov
2011-03-10 21:15                       ` Greg KH
2011-03-11  7:12                         ` Nikolai Kondrashov
2011-03-11 17:03                           ` Greg KH
2011-03-11 19:07                             ` Nikolai Kondrashov
2011-03-11 19:34                               ` Greg KH
2011-03-11 20:20                                 ` Nikolai Kondrashov
2011-03-11 20:23                                   ` Nikolai Kondrashov
2011-03-11 20:35                                     ` Greg KH
2011-03-11 20:30                                   ` Greg KH
2011-03-13 10:03                                     ` Nikolai Kondrashov
2011-03-13 10:55                                       ` Richard Schütz
2011-03-13 13:02                                         ` Nikolai Kondrashov
2011-03-13 16:18                                           ` Greg KH
2011-03-13 17:49                                             ` Nikolai Kondrashov
2011-03-13 17:58                                               ` Greg KH
2011-03-13 16:17                                       ` Greg KH
2011-03-13 16:28                                         ` Matthew Garrett
2011-03-13 17:51                                           ` Nikolai Kondrashov
2011-03-13 17:50                                         ` Nikolai Kondrashov
  -- strict thread matches above, loose matches on Subject: below --
2011-02-25 22:47 Greg KH
2011-02-27 15:36 Greg KH
2011-03-05  4:24 Greg KH
2011-03-05  4:24 ` Greg KH
2011-03-11 17:43 ` Matthew Garrett
2011-03-11 19:35   ` Greg KH
2011-03-11 19:44     ` Matthew Garrett
2011-03-11 19:52       ` Greg KH
2011-03-11 19:55         ` Matthew Garrett
2011-03-14 15:18           ` Jörg-Volker Peetz
2011-03-11 17:57 Tommaso Massimi
2011-06-26 15:08 J Witteveen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D551F76.1070303@t-online.de \
    --to=r.schtz@t-online.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.