From: Tony Lindgren <tony@atomide.com>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: aaro.koskinen@nokia.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: plat-omap: iommu: fix request_mem_region() error path
Date: Mon, 14 Mar 2011 11:12:30 -0700 [thread overview]
Message-ID: <20110314181230.GE7258@atomide.com> (raw)
In-Reply-To: <20110314.145029.848855634033118142.Hiroshi.DOYU@nokia.com>
* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [110314 05:50]:
> Hi Aaro,
>
> From: Aaro Koskinen <aaro.koskinen@nokia.com>
> Subject: [PATCH] arm: plat-omap: iommu: fix request_mem_region() error path
> Date: Mon, 14 Mar 2011 14:28:32 +0200
>
> > request_mem_region() error exit will leak ioremapped memory. Fix this
> > by moving the ioremap() after request_mem_region(), which is the proper
> > order to do this anyway.
> >
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> > ---
> > arch/arm/plat-omap/iommu.c | 14 ++++++++------
> > 1 files changed, 8 insertions(+), 6 deletions(-)
>
> True. Thank you for catching this.
Applying.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: plat-omap: iommu: fix request_mem_region() error path
Date: Mon, 14 Mar 2011 11:12:30 -0700 [thread overview]
Message-ID: <20110314181230.GE7258@atomide.com> (raw)
In-Reply-To: <20110314.145029.848855634033118142.Hiroshi.DOYU@nokia.com>
* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [110314 05:50]:
> Hi Aaro,
>
> From: Aaro Koskinen <aaro.koskinen@nokia.com>
> Subject: [PATCH] arm: plat-omap: iommu: fix request_mem_region() error path
> Date: Mon, 14 Mar 2011 14:28:32 +0200
>
> > request_mem_region() error exit will leak ioremapped memory. Fix this
> > by moving the ioremap() after request_mem_region(), which is the proper
> > order to do this anyway.
> >
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> > ---
> > arch/arm/plat-omap/iommu.c | 14 ++++++++------
> > 1 files changed, 8 insertions(+), 6 deletions(-)
>
> True. Thank you for catching this.
Applying.
Tony
next prev parent reply other threads:[~2011-03-14 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 12:28 [PATCH] arm: plat-omap: iommu: fix request_mem_region() error path Aaro Koskinen
2011-03-14 12:28 ` Aaro Koskinen
2011-03-14 12:50 ` Hiroshi DOYU
2011-03-14 12:50 ` Hiroshi DOYU
2011-03-14 18:12 ` Tony Lindgren [this message]
2011-03-14 18:12 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314181230.GE7258@atomide.com \
--to=tony@atomide.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=aaro.koskinen@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.