* [PATCH] perf lock: fix sorting by wait_min
@ 2011-02-22 17:47 Marcin Slusarz
2011-03-14 16:54 ` Marcin Slusarz
2011-03-17 11:04 ` [tip:perf/urgent] perf lock: Fix " tip-bot for Marcin Slusarz
0 siblings, 2 replies; 5+ messages in thread
From: Marcin Slusarz @ 2011-02-22 17:47 UTC (permalink / raw)
To: LKML; +Cc: Peter Zijlstra, Arnaldo Carvalho de Melo, Paul Mackerras,
Ingo Molnar
if lock was uncontended, wait_time_min == ULLONG_MAX, so we need to handle
this case differently to show high wait times first
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
---
tools/perf/builtin-lock.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index 0305a40..812ad26 100644
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -202,9 +202,20 @@ static struct thread_stat *thread_stat_findnew_first(u32 tid)
SINGLE_KEY(nr_acquired)
SINGLE_KEY(nr_contended)
SINGLE_KEY(wait_time_total)
-SINGLE_KEY(wait_time_min)
SINGLE_KEY(wait_time_max)
+static int lock_stat_key_wait_time_min(struct lock_stat *one,
+ struct lock_stat *two)
+{
+ u64 s1 = one->wait_time_min;
+ u64 s2 = two->wait_time_min;
+ if (s1 == ULLONG_MAX)
+ s1 = 0;
+ if (s2 == ULLONG_MAX)
+ s2 = 0;
+ return s1 > s2;
+}
+
struct lock_key {
/*
* name: the value for specify by user
--
1.7.4.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] perf lock: fix sorting by wait_min
2011-02-22 17:47 [PATCH] perf lock: fix sorting by wait_min Marcin Slusarz
@ 2011-03-14 16:54 ` Marcin Slusarz
2011-03-14 19:23 ` Arnaldo Carvalho de Melo
2011-03-17 11:04 ` [tip:perf/urgent] perf lock: Fix " tip-bot for Marcin Slusarz
1 sibling, 1 reply; 5+ messages in thread
From: Marcin Slusarz @ 2011-03-14 16:54 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra, Paul Mackerras, Ingo Molnar, LKML
On Tue, Feb 22, 2011 at 06:47:15PM +0100, Marcin Slusarz wrote:
> if lock was uncontended, wait_time_min == ULLONG_MAX, so we need to handle
> this case differently to show high wait times first
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> ---
> tools/perf/builtin-lock.c | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index 0305a40..812ad26 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -202,9 +202,20 @@ static struct thread_stat *thread_stat_findnew_first(u32 tid)
> SINGLE_KEY(nr_acquired)
> SINGLE_KEY(nr_contended)
> SINGLE_KEY(wait_time_total)
> -SINGLE_KEY(wait_time_min)
> SINGLE_KEY(wait_time_max)
>
> +static int lock_stat_key_wait_time_min(struct lock_stat *one,
> + struct lock_stat *two)
> +{
> + u64 s1 = one->wait_time_min;
> + u64 s2 = two->wait_time_min;
> + if (s1 == ULLONG_MAX)
> + s1 = 0;
> + if (s2 == ULLONG_MAX)
> + s2 = 0;
> + return s1 > s2;
> +}
> +
> struct lock_key {
> /*
> * name: the value for specify by user
> --
Anything wrong with this patch?
I can't find it in linux-next.
Marcin
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf lock: fix sorting by wait_min
2011-03-14 16:54 ` Marcin Slusarz
@ 2011-03-14 19:23 ` Arnaldo Carvalho de Melo
2011-03-15 8:08 ` Hitoshi Mitake
0 siblings, 1 reply; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-03-14 19:23 UTC (permalink / raw)
To: Hitoshi Mitake
Cc: Marcin Slusarz, Peter Zijlstra, Paul Mackerras, Ingo Molnar, LKML
Em Mon, Mar 14, 2011 at 05:54:58PM +0100, Marcin Slusarz escreveu:
> On Tue, Feb 22, 2011 at 06:47:15PM +0100, Marcin Slusarz wrote:
> > if lock was uncontended, wait_time_min == ULLONG_MAX, so we need to handle
> > this case differently to show high wait times first
> >
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > ---
> > tools/perf/builtin-lock.c | 13 ++++++++++++-
> > 1 files changed, 12 insertions(+), 1 deletions(-)
> >
> > diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> > index 0305a40..812ad26 100644
> > --- a/tools/perf/builtin-lock.c
> > +++ b/tools/perf/builtin-lock.c
> > @@ -202,9 +202,20 @@ static struct thread_stat *thread_stat_findnew_first(u32 tid)
> > SINGLE_KEY(nr_acquired)
> > SINGLE_KEY(nr_contended)
> > SINGLE_KEY(wait_time_total)
> > -SINGLE_KEY(wait_time_min)
> > SINGLE_KEY(wait_time_max)
> >
> > +static int lock_stat_key_wait_time_min(struct lock_stat *one,
> > + struct lock_stat *two)
> > +{
> > + u64 s1 = one->wait_time_min;
> > + u64 s2 = two->wait_time_min;
> > + if (s1 == ULLONG_MAX)
> > + s1 = 0;
> > + if (s2 == ULLONG_MAX)
> > + s2 = 0;
> > + return s1 > s2;
> > +}
> > +
> > struct lock_key {
> > /*
> > * name: the value for specify by user
> > --
>
> Anything wrong with this patch?
> I can't find it in linux-next.
Hitoshi-san, can I have your acked-by for this one?
Thanks,
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf lock: fix sorting by wait_min
2011-03-14 19:23 ` Arnaldo Carvalho de Melo
@ 2011-03-15 8:08 ` Hitoshi Mitake
0 siblings, 0 replies; 5+ messages in thread
From: Hitoshi Mitake @ 2011-03-15 8:08 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Marcin Slusarz, Peter Zijlstra, Paul Mackerras, Ingo Molnar, LKML
On 2011年03月15日 04:23, Arnaldo Carvalho de Melo wrote:
> Em Mon, Mar 14, 2011 at 05:54:58PM +0100, Marcin Slusarz escreveu:
>> On Tue, Feb 22, 2011 at 06:47:15PM +0100, Marcin Slusarz wrote:
>>> if lock was uncontended, wait_time_min == ULLONG_MAX, so we need to handle
>>> this case differently to show high wait times first
>>>
>>> Signed-off-by: Marcin Slusarz<marcin.slusarz@gmail.com>
>>> ---
>>> tools/perf/builtin-lock.c | 13 ++++++++++++-
>>> 1 files changed, 12 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
>>> index 0305a40..812ad26 100644
>>> --- a/tools/perf/builtin-lock.c
>>> +++ b/tools/perf/builtin-lock.c
>>> @@ -202,9 +202,20 @@ static struct thread_stat *thread_stat_findnew_first(u32 tid)
>>> SINGLE_KEY(nr_acquired)
>>> SINGLE_KEY(nr_contended)
>>> SINGLE_KEY(wait_time_total)
>>> -SINGLE_KEY(wait_time_min)
>>> SINGLE_KEY(wait_time_max)
>>>
>>> +static int lock_stat_key_wait_time_min(struct lock_stat *one,
>>> + struct lock_stat *two)
>>> +{
>>> + u64 s1 = one->wait_time_min;
>>> + u64 s2 = two->wait_time_min;
>>> + if (s1 == ULLONG_MAX)
>>> + s1 = 0;
>>> + if (s2 == ULLONG_MAX)
>>> + s2 = 0;
>>> + return s1> s2;
>>> +}
>>> +
>>> struct lock_key {
>>> /*
>>> * name: the value for specify by user
>>> --
>>
>> Anything wrong with this patch?
>> I can't find it in linux-next.
>
> Hitoshi-san, can I have your acked-by for this one?
>
> Thanks,
>
> - Arnaldo
>
Hi Arnaldo and Marcin,
Sure, ignoring the case of wait_time_min == ULLONG_MAX is my mistake.
Thanks a lot!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/urgent] perf lock: Fix sorting by wait_min
2011-02-22 17:47 [PATCH] perf lock: fix sorting by wait_min Marcin Slusarz
2011-03-14 16:54 ` Marcin Slusarz
@ 2011-03-17 11:04 ` tip-bot for Marcin Slusarz
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Marcin Slusarz @ 2011-03-17 11:04 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, paulus, hpa, mingo, a.p.zijlstra, mitake,
marcin.slusarz, tglx, mingo
Commit-ID: 9df03abeda3d928ecdedc0f427336931eac0a477
Gitweb: http://git.kernel.org/tip/9df03abeda3d928ecdedc0f427336931eac0a477
Author: Marcin Slusarz <marcin.slusarz@gmail.com>
AuthorDate: Tue, 22 Feb 2011 18:47:15 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 16 Mar 2011 09:05:58 -0300
perf lock: Fix sorting by wait_min
If lock was uncontended, wait_time_min == ULLONG_MAX, so we need to
handle this case differently to show high wait times first
Acked-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20110222174715.GC9687@joi.lan>
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-lock.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index 2e93f99..7a2a79d 100644
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -202,9 +202,20 @@ static struct thread_stat *thread_stat_findnew_first(u32 tid)
SINGLE_KEY(nr_acquired)
SINGLE_KEY(nr_contended)
SINGLE_KEY(wait_time_total)
-SINGLE_KEY(wait_time_min)
SINGLE_KEY(wait_time_max)
+static int lock_stat_key_wait_time_min(struct lock_stat *one,
+ struct lock_stat *two)
+{
+ u64 s1 = one->wait_time_min;
+ u64 s2 = two->wait_time_min;
+ if (s1 == ULLONG_MAX)
+ s1 = 0;
+ if (s2 == ULLONG_MAX)
+ s2 = 0;
+ return s1 > s2;
+}
+
struct lock_key {
/*
* name: the value for specify by user
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-17 11:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-22 17:47 [PATCH] perf lock: fix sorting by wait_min Marcin Slusarz
2011-03-14 16:54 ` Marcin Slusarz
2011-03-14 19:23 ` Arnaldo Carvalho de Melo
2011-03-15 8:08 ` Hitoshi Mitake
2011-03-17 11:04 ` [tip:perf/urgent] perf lock: Fix " tip-bot for Marcin Slusarz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.