From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
patches@opensource.wolfsonmicro.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: S3C64XX: Fix section mismatch from cpufreq init
Date: Wed, 16 Mar 2011 09:49:59 +0000 [thread overview]
Message-ID: <20110316094959.GB2688@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110316083811.GG13316@pengutronix.de>
On Wed, Mar 16, 2011 at 09:38:11AM +0100, Uwe Kleine-König wrote:
> On Thu, Mar 10, 2011 at 02:58:13PM +0000, Mark Brown wrote:
> > we don't appear to have annotations which allow us to mark that it'll
> > never be called after system init, causing the linker consistency
> Actually this is warning is a false positive. There is a section
> mismatch, but it is never a problem because the .init callback is only
> called by cpufreq_register_driver. To get rid of the warning the right
> fix is to remove the .init callback from struct cpufreq_driver and
> change the prototype of cpufreq_register_driver to
That's what I said above, pretty much. Ideally we'd have a way of
annotating the call sites so that the linker infrastructure rather than
having to faff about splitting the structures like this.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C64XX: Fix section mismatch from cpufreq init
Date: Wed, 16 Mar 2011 09:49:59 +0000 [thread overview]
Message-ID: <20110316094959.GB2688@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110316083811.GG13316@pengutronix.de>
On Wed, Mar 16, 2011 at 09:38:11AM +0100, Uwe Kleine-K?nig wrote:
> On Thu, Mar 10, 2011 at 02:58:13PM +0000, Mark Brown wrote:
> > we don't appear to have annotations which allow us to mark that it'll
> > never be called after system init, causing the linker consistency
> Actually this is warning is a false positive. There is a section
> mismatch, but it is never a problem because the .init callback is only
> called by cpufreq_register_driver. To get rid of the warning the right
> fix is to remove the .init callback from struct cpufreq_driver and
> change the prototype of cpufreq_register_driver to
That's what I said above, pretty much. Ideally we'd have a way of
annotating the call sites so that the linker infrastructure rather than
having to faff about splitting the structures like this.
next prev parent reply other threads:[~2011-03-16 9:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 14:58 [PATCH] ARM: S3C64XX: Fix section mismatch from cpufreq init Mark Brown
2011-03-10 14:58 ` Mark Brown
2011-03-11 7:51 ` Kukjin Kim
2011-03-11 7:51 ` Kukjin Kim
2011-03-15 12:04 ` Kukjin Kim
2011-03-15 12:04 ` Kukjin Kim
2011-03-15 12:05 ` Mark Brown
2011-03-15 12:05 ` Mark Brown
2011-03-16 8:38 ` Uwe Kleine-König
2011-03-16 8:38 ` Uwe Kleine-König
2011-03-16 9:49 ` Mark Brown [this message]
2011-03-16 9:49 ` Mark Brown
2011-03-16 10:13 ` Uwe Kleine-König
2011-03-16 10:13 ` Uwe Kleine-König
2011-03-16 10:53 ` Mark Brown
2011-03-16 10:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316094959.GB2688@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.