All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [2010.03-maintenance] [PATCH 1/7] image.bbclass: add link	to .rootfs.<type> or .<type>.img
Date: Wed, 16 Mar 2011 16:21:17 -0400	[thread overview]
Message-ID: <20110316202117.GE3042@denix.org> (raw)
In-Reply-To: <08cb84d24fdd8e9d40a5db836b98a3706187c7c6.1300293663.git.bengardiner@nanometrics.ca>

On Wed, Mar 16, 2011 at 12:50:34PM -0400, Ben Gardiner wrote:
> The current image link-creation code will unconditionaly create a link
> from .<type> pointing to the .rootfs.<type> output.
> 
> This is not compatible with the UBIFS images produced which have
> .<type>.img extension since they are not considered to be valid rootfs
> images when they are not included in a UBI container.
> 
> Check for existence of the link target .rootfs.<type> before creating the
> link and fallback to a check for the .<type>.img target after that.
> 
> Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>
> Acked-by: Denys Dmytriyenko <denys@ti.com>
> Signed-off-by: Tom Rini <tom_rini@mentor.com>
> (cherry picked from commit cfde49e8d0f1cf09d589910f1a342849db148519)
> 
> Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>

Acked-by: Denys Dmytriyenko <denys@ti.com>

> ---
>  classes/image.bbclass |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/classes/image.bbclass b/classes/image.bbclass
> index 9621614..d7fe9b0 100644
> --- a/classes/image.bbclass
> +++ b/classes/image.bbclass
> @@ -140,7 +140,11 @@ def get_imagecmds(d):
>          cmd  = "\t#Code for image type " + type + "\n"
>          cmd += "\t${IMAGE_CMD_" + type + "}\n"
>          cmd += "\tcd ${DEPLOY_DIR_IMAGE}/\n"
> -        cmd += "\tln -fs ${IMAGE_NAME}.rootfs." + type + " ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}." + type + "\n\n"
> +        cmd += "\tif [ -f ${IMAGE_NAME}.rootfs." + type + " ]; then\n"
> +        cmd += "\tln -fs ${IMAGE_NAME}.rootfs." + type + " ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}." + type + "\n"
> +        cmd += "\telif [ -f ${IMAGE_NAME}." + type + ".img ]; then\n"
> +        cmd += "\tln -fs ${IMAGE_NAME}." + type + ".img ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}." + type + "\n"
> +        cmd += "\tfi\n\n"
>          cmds += bb.data.expand(cmd, localdata)
>      return cmds
>  
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



  reply	other threads:[~2011-03-16 20:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 16:50 [2010.03-maintenance] [PATCH 0/7] 2010.03-maintenance: libc-headers, gdbserver and ubifs Ben Gardiner
2011-03-16 16:50 ` [2010.03-maintenance] [PATCH 1/7] image.bbclass: add link to .rootfs.<type> or .<type>.img Ben Gardiner
2011-03-16 20:21   ` Denys Dmytriyenko [this message]
2011-03-16 16:50 ` [2010.03-maintenance] [PATCH 2/7] bitbake.conf: use .ubifs.img extension in IMAGE_CMD_ubi Ben Gardiner
2011-03-16 20:21   ` Denys Dmytriyenko
2011-03-16 16:50 ` [2010.03-maintenance] [PATCH 3/7] external-toolchain: allow override of linux-libc-headers provider Ben Gardiner
2011-03-16 20:21   ` Denys Dmytriyenko
2011-03-16 16:50 ` [2010.03-maintenance] [PATCH 4/7] external-toolchain-csl: allow linux-libc-headers Ben Gardiner
2011-03-16 20:21   ` Denys Dmytriyenko
2011-03-16 16:50 ` [2010.03-maintenance] [PATCH 5/7] external-toolchain-csl: Drop do_stage, add gdbserver Ben Gardiner
2011-03-16 20:21   ` Denys Dmytriyenko
2011-03-16 16:50 ` [2010.03-maintenance] [PATCH 6/7] external-toolchain-csl: handle packaging of gdbserver based on PREFERRED_PROVIDER Ben Gardiner
2011-03-16 20:22   ` Denys Dmytriyenko
2011-03-16 16:50 ` [2010.03-maintenance] [PATCH 7/7] toolchain-external.conf: set the default provider for gdbserver Ben Gardiner
2011-03-16 20:22   ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110316202117.GE3042@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.