* fix reversed memset arguments in hv_mouse
@ 2011-03-17 1:40 Dave Jones
2011-03-17 2:05 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2011-03-17 1:40 UTC (permalink / raw)
To: gregkh; +Cc: Linux Kernel
size is 3rd arg, not the 2nd.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
index 50147f8..cbe5686 100644
--- a/drivers/staging/hv/hv_mouse.c
+++ b/drivers/staging/hv/hv_mouse.c
@@ -374,7 +374,7 @@ static void MousevscOnReceiveDeviceInfo(struct mousevsc_dev *InputDevice, struct
desc->desc[0].wDescriptorLength);
/* Send the ack */
- memset(&ack, sizeof(struct mousevsc_prt_msg), 0);
+ memset(&ack, 0, sizeof(struct mousevsc_prt_msg));
ack.type = PipeMessageData;
ack.size = sizeof(struct synthhid_device_info_ack);
@@ -595,7 +595,7 @@ static int MousevscConnectToVsp(struct hv_device *Device)
/*
* Now, initiate the vsc/vsp initialization protocol on the open channel
*/
- memset(request, sizeof(struct mousevsc_prt_msg), 0);
+ memset(request, 0, sizeof(struct mousevsc_prt_msg));
request->type = PipeMessageData;
request->size = sizeof(struct synthhid_protocol_request);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: fix reversed memset arguments in hv_mouse
2011-03-17 1:40 fix reversed memset arguments in hv_mouse Dave Jones
@ 2011-03-17 2:05 ` Greg KH
2011-03-17 3:06 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2011-03-17 2:05 UTC (permalink / raw)
To: Dave Jones, Linux Kernel
On Wed, Mar 16, 2011 at 09:40:59PM -0400, Dave Jones wrote:
> size is 3rd arg, not the 2nd.
Do you just have a script that checks lkml for this? :)
I thought checkpatch.pl caught these problems, I guess not. Thanks for
the patch, I'll queue it up.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fix reversed memset arguments in hv_mouse
2011-03-17 2:05 ` Greg KH
@ 2011-03-17 3:06 ` Dave Jones
0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2011-03-17 3:06 UTC (permalink / raw)
To: Greg KH; +Cc: Linux Kernel
On Wed, Mar 16, 2011 at 07:05:45PM -0700, Greg KH wrote:
> On Wed, Mar 16, 2011 at 09:40:59PM -0400, Dave Jones wrote:
> > size is 3rd arg, not the 2nd.
>
> Do you just have a script that checks lkml for this? :)
mutt hook.
> I thought checkpatch.pl caught these problems, I guess not. Thanks for
> the patch, I'll queue it up.
I thought so too. I'm sure I sent one in. I'll resend it.
Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-17 3:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-17 1:40 fix reversed memset arguments in hv_mouse Dave Jones
2011-03-17 2:05 ` Greg KH
2011-03-17 3:06 ` Dave Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.