All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikanth Karthikesan <knikanth@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Anton Altaparmakov <aia21@cam.ac.uk>,
	Jiri Kosina <trivial@kernel.org>,
	linux-ntfs-dev@lists.sourceforge.net,
	"Richard Russon (FlatCap)" <ldm@flatcap.org>,
	Klaus Hartmann <Klaus.Hartmann@ts.fujitsu.com>,
	Andries Brouwer <aeb@cwi.nl>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"
Date: Thu, 17 Mar 2011 11:04:14 +0530	[thread overview]
Message-ID: <201103171104.15086.knikanth@suse.de> (raw)
In-Reply-To: <68B01298-2FC4-4BA3-B76D-50BABA32AC4E@cam.ac.uk>

From: Nikanth Karthikesan <knikanth@suse.de>
Subject: Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet"

When the kernel does partition detection, on certain configurations with
external fibre channel raid systems (e.g. clariion from EMC) the read
would fail. And "ldm_validate_partition_table(): Disk read failed"
messages are printed to the console.

But the failure to read is not a critical error. Now since the message
is flagged as KERN_CRIT, it gets printed even when booting with the
"quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to
read here is not really an error.

Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Reported-by : Klaus Hartmann <Klaus.Hartmann@ts.fujitsu.com>
Signed-off-by: Anton Altaparmakov <aia21@cantab.net>

---

diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c
index b10e354..ea648b9 100644
--- a/fs/partitions/ldm.c
+++ b/fs/partitions/ldm.c
@@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state)
 
 	data = read_part_sector(state, 0, &sect);
 	if (!data) {
-		ldm_crit ("Disk read failed.");
+		ldm_info ("Disk read failed.");
 		return false;
 	}
 

       reply	other threads:[~2011-03-17  5:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201101121633.48567.knikanth@suse.de>
     [not found] ` <201103151125.05809.knikanth@suse.de>
     [not found]   ` <68B01298-2FC4-4BA3-B76D-50BABA32AC4E@cam.ac.uk>
2011-03-17  5:34     ` Nikanth Karthikesan [this message]
2011-04-10 15:05       ` [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet" Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103171104.15086.knikanth@suse.de \
    --to=knikanth@suse.de \
    --cc=Klaus.Hartmann@ts.fujitsu.com \
    --cc=aeb@cwi.nl \
    --cc=aia21@cam.ac.uk \
    --cc=ldm@flatcap.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=torvalds@linux-foundation.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.