* [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet" [not found] ` <68B01298-2FC4-4BA3-B76D-50BABA32AC4E@cam.ac.uk> @ 2011-03-17 5:34 ` Nikanth Karthikesan 2011-04-10 15:05 ` Jiri Kosina 0 siblings, 1 reply; 2+ messages in thread From: Nikanth Karthikesan @ 2011-03-17 5:34 UTC (permalink / raw) To: Linus Torvalds Cc: Anton Altaparmakov, Jiri Kosina, linux-ntfs-dev, Richard Russon (FlatCap), Klaus Hartmann, Andries Brouwer, linux-kernel From: Nikanth Karthikesan <knikanth@suse.de> Subject: Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet" When the kernel does partition detection, on certain configurations with external fibre channel raid systems (e.g. clariion from EMC) the read would fail. And "ldm_validate_partition_table(): Disk read failed" messages are printed to the console. But the failure to read is not a critical error. Now since the message is flagged as KERN_CRIT, it gets printed even when booting with the "quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to read here is not really an error. Signed-off-by: Nikanth Karthikesan <knikanth@suse.de> Reported-by : Klaus Hartmann <Klaus.Hartmann@ts.fujitsu.com> Signed-off-by: Anton Altaparmakov <aia21@cantab.net> --- diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c index b10e354..ea648b9 100644 --- a/fs/partitions/ldm.c +++ b/fs/partitions/ldm.c @@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state) data = read_part_sector(state, 0, §); if (!data) { - ldm_crit ("Disk read failed."); + ldm_info ("Disk read failed."); return false; } ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet" 2011-03-17 5:34 ` [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet" Nikanth Karthikesan @ 2011-04-10 15:05 ` Jiri Kosina 0 siblings, 0 replies; 2+ messages in thread From: Jiri Kosina @ 2011-04-10 15:05 UTC (permalink / raw) To: Nikanth Karthikesan Cc: Linus Torvalds, Anton Altaparmakov, linux-ntfs-dev, Richard Russon (FlatCap), Klaus Hartmann, Andries Brouwer, linux-kernel On Thu, 17 Mar 2011, Nikanth Karthikesan wrote: > From: Nikanth Karthikesan <knikanth@suse.de> > Subject: Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet" > > When the kernel does partition detection, on certain configurations with > external fibre channel raid systems (e.g. clariion from EMC) the read > would fail. And "ldm_validate_partition_table(): Disk read failed" > messages are printed to the console. > > But the failure to read is not a critical error. Now since the message > is flagged as KERN_CRIT, it gets printed even when booting with the > "quiet" kernel parameter. Fix it by using KERN_INFO, as the failure to > read here is not really an error. > > Signed-off-by: Nikanth Karthikesan <knikanth@suse.de> > Reported-by : Klaus Hartmann <Klaus.Hartmann@ts.fujitsu.com> > Signed-off-by: Anton Altaparmakov <aia21@cantab.net> > > --- > > diff --git a/fs/partitions/ldm.c b/fs/partitions/ldm.c > index b10e354..ea648b9 100644 > --- a/fs/partitions/ldm.c > +++ b/fs/partitions/ldm.c > @@ -565,7 +565,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state) > > data = read_part_sector(state, 0, §); > if (!data) { > - ldm_crit ("Disk read failed."); > + ldm_info ("Disk read failed."); > return false; > } Applied, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-10 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201101121633.48567.knikanth@suse.de>
[not found] ` <201103151125.05809.knikanth@suse.de>
[not found] ` <68B01298-2FC4-4BA3-B76D-50BABA32AC4E@cam.ac.uk>
2011-03-17 5:34 ` [PATCH] Silence "ldm_validate_partition_table(): Disk read failed" when booting with "quiet" Nikanth Karthikesan
2011-04-10 15:05 ` Jiri Kosina
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.