From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: ratbert@faraday-tech.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ftmac100: use resource_size()
Date: Sat, 19 Mar 2011 04:53:13 +0000 [thread overview]
Message-ID: <20110318.215313.149843288.davem@davemloft.net> (raw)
In-Reply-To: <20110319043915.GB2008@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Sat, 19 Mar 2011 07:39:15 +0300
> The calculation is off-by-one. It should be "end - start + 1". This
> patch fixes it to use resource_size() instead. Oddly, the code already
> uses resource size correctly a couple lines earlier when it calls
> request_mem_region() for this memory.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks for fixing this Dan.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: ratbert@faraday-tech.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ftmac100: use resource_size()
Date: Fri, 18 Mar 2011 21:53:13 -0700 (PDT) [thread overview]
Message-ID: <20110318.215313.149843288.davem@davemloft.net> (raw)
In-Reply-To: <20110319043915.GB2008@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Sat, 19 Mar 2011 07:39:15 +0300
> The calculation is off-by-one. It should be "end - start + 1". This
> patch fixes it to use resource_size() instead. Oddly, the code already
> uses resource size correctly a couple lines earlier when it calls
> request_mem_region() for this memory.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks for fixing this Dan.
next prev parent reply other threads:[~2011-03-19 4:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 4:39 [patch] ftmac100: use resource_size() Dan Carpenter
2011-03-19 4:39 ` Dan Carpenter
2011-03-19 4:53 ` David Miller [this message]
2011-03-19 4:53 ` David Miller
2011-03-19 5:05 ` Po-Yu Chuang
2011-03-19 5:05 ` Po-Yu Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318.215313.149843288.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ratbert@faraday-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.