From: Tejun Heo <tj@kernel.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] block: NULL dereference on error path in __blkdev_get()
Date: Fri, 18 Mar 2011 08:32:02 +0000 [thread overview]
Message-ID: <20110318083202.GC8571@htj.dyndns.org> (raw)
In-Reply-To: <20110314085819.GJ2005@htj.dyndns.org>
On Mon, Mar 14, 2011 at 09:58:19AM +0100, Tejun Heo wrote:
> Hello,
>
> On Sun, Mar 13, 2011 at 11:59:37PM +0300, Dan Carpenter wrote:
> > "disk" is always NULL when we goto out. There was a check for this
> > before, but it was removed in 69e02c59a7d9 "block: Don't check events
> > while open is in progress".
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Sorry about the trouble. I hate that function. :-(
I thought Jens was cc'd. I'll forward the patch to him & LKML.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] block: NULL dereference on error path in __blkdev_get()
Date: Fri, 18 Mar 2011 09:32:02 +0100 [thread overview]
Message-ID: <20110318083202.GC8571@htj.dyndns.org> (raw)
In-Reply-To: <20110314085819.GJ2005@htj.dyndns.org>
On Mon, Mar 14, 2011 at 09:58:19AM +0100, Tejun Heo wrote:
> Hello,
>
> On Sun, Mar 13, 2011 at 11:59:37PM +0300, Dan Carpenter wrote:
> > "disk" is always NULL when we goto out. There was a check for this
> > before, but it was removed in 69e02c59a7d9 "block: Don't check events
> > while open is in progress".
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Sorry about the trouble. I hate that function. :-(
I thought Jens was cc'd. I'll forward the patch to him & LKML.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-03-18 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 20:59 [patch] block: NULL dereference on error path in __blkdev_get() Dan Carpenter
2011-03-13 20:59 ` Dan Carpenter
2011-03-14 8:58 ` Tejun Heo
2011-03-14 8:58 ` Tejun Heo
2011-03-18 8:32 ` Tejun Heo [this message]
2011-03-18 8:32 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2011-03-18 8:37 [PATCH] " Tejun Heo
2011-03-18 22:26 ` Justin TerAvest
2011-03-19 12:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318083202.GC8571@htj.dyndns.org \
--to=tj@kernel.org \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.