All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	jean-philippe.menil@univ-nantes.fr, stable@kernel.org,
	Jason Wang <jasowang@redhat.com>
Subject: Re: [stable] [PATCH] kvm: fix crash on irqfd deassign
Date: Fri, 18 Mar 2011 15:21:02 +0200	[thread overview]
Message-ID: <20110318132102.GD4221@redhat.com> (raw)
In-Reply-To: <20110317161308.GA12740@kroah.com>

On Thu, Mar 17, 2011 at 09:13:08AM -0700, Greg KH wrote:
> On Thu, Mar 17, 2011 at 10:53:33AM +0200, Michael S. Tsirkin wrote:
> > irqfd in kvm used flush_work incorrectly:
> > it assumed that work scheduled previously can't run
> > after flush_work, but since kvm uses a non-reentrant
> > workqueue (by means of schedule_work)
> > we need flush_work_sync to get that guarantee.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reported-by: Jean-Philippe Menil <jean-philippe.menil@univ-nantes.fr>
> > Tested-by: Jean-Philippe Menil <jean-philippe.menil@univ-nantes.fr>
> > ---
> > 
> > Note: this is needed for kernel 2.6.39 and earlier.
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
> 
> thanks,
> 
> greg k-h

What I missed is Cc: stable@kernel.org in the text?
OK, thanks for the correction.  Actually I forgot, Avi and Marcelo want
to handle stable patches for kvm themselves.
Avi, Marcelo, right?
So Greg, you can forget about this one for now.

Thanks,

-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: kvm@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	linux-kernel@vger.kernel.org, jean-philippe.menil@univ-nantes.fr,
	Avi Kivity <avi@redhat.com>,
	stable@kernel.org
Subject: Re: [PATCH] kvm: fix crash on irqfd deassign
Date: Fri, 18 Mar 2011 15:21:02 +0200	[thread overview]
Message-ID: <20110318132102.GD4221@redhat.com> (raw)
In-Reply-To: <20110317161308.GA12740@kroah.com>

On Thu, Mar 17, 2011 at 09:13:08AM -0700, Greg KH wrote:
> On Thu, Mar 17, 2011 at 10:53:33AM +0200, Michael S. Tsirkin wrote:
> > irqfd in kvm used flush_work incorrectly:
> > it assumed that work scheduled previously can't run
> > after flush_work, but since kvm uses a non-reentrant
> > workqueue (by means of schedule_work)
> > we need flush_work_sync to get that guarantee.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reported-by: Jean-Philippe Menil <jean-philippe.menil@univ-nantes.fr>
> > Tested-by: Jean-Philippe Menil <jean-philippe.menil@univ-nantes.fr>
> > ---
> > 
> > Note: this is needed for kernel 2.6.39 and earlier.
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
> 
> thanks,
> 
> greg k-h

What I missed is Cc: stable@kernel.org in the text?
OK, thanks for the correction.  Actually I forgot, Avi and Marcelo want
to handle stable patches for kvm themselves.
Avi, Marcelo, right?
So Greg, you can forget about this one for now.

Thanks,

-- 
MST

  reply	other threads:[~2011-03-18 13:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17  8:53 [PATCH] kvm: fix crash on irqfd deassign Michael S. Tsirkin
2011-03-17 16:13 ` [stable] " Greg KH
2011-03-18 13:21   ` Michael S. Tsirkin [this message]
2011-03-18 13:21     ` Michael S. Tsirkin
2011-03-22 12:37 ` Avi Kivity
2011-03-22 12:50   ` Michael S. Tsirkin
2011-03-22 16:41 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110318132102.GD4221@redhat.com \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=greg@kroah.com \
    --cc=jasowang@redhat.com \
    --cc=jean-philippe.menil@univ-nantes.fr \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.