* [patch 1/2] xen-gntdev: return -EFAULT on copy_to_user failure
@ 2011-03-19 5:44 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2011-03-19 5:44 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: kernel-janitors, xen-devel, virtualization, Konrad Rzeszutek Wilk
copy_to_user() returns the amount of data remaining to be copied. We
want to return a negative error code here. The upper layers just
call WARN_ON() if we return non-zero so this doesn't change the
behavior. But returning -EFAULT is still cleaner.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index 017ce60..b0f9e8f 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -273,7 +273,7 @@ static int __unmap_grant_pages(struct grant_map *map, int offset, int pages)
map->vma->vm_start + map->notify.addr;
err = copy_to_user(tmp, &err, 1);
if (err)
- return err;
+ return -EFAULT;
map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE;
} else if (pgno >= offset && pgno < offset + pages) {
uint8_t *tmp = kmap(map->pages[pgno]);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [patch 1/2] xen-gntdev: return -EFAULT on copy_to_user failure
@ 2011-03-19 5:44 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2011-03-19 5:44 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: kernel-janitors, xen-devel, virtualization, Konrad Rzeszutek Wilk
copy_to_user() returns the amount of data remaining to be copied. We
want to return a negative error code here. The upper layers just
call WARN_ON() if we return non-zero so this doesn't change the
behavior. But returning -EFAULT is still cleaner.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index 017ce60..b0f9e8f 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -273,7 +273,7 @@ static int __unmap_grant_pages(struct grant_map *map, int offset, int pages)
map->vma->vm_start + map->notify.addr;
err = copy_to_user(tmp, &err, 1);
if (err)
- return err;
+ return -EFAULT;
map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE;
} else if (pgno >= offset && pgno < offset + pages) {
uint8_t *tmp = kmap(map->pages[pgno]);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Xen-devel] [patch 1/2] xen-gntdev: return -EFAULT on
2011-03-19 5:44 ` Dan Carpenter
@ 2011-03-25 15:04 ` Konrad Rzeszutek Wilk
-1 siblings, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-03-25 15:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jeremy Fitzhardinge, kernel-janitors, xen-devel, virtualization
On Sat, Mar 19, 2011 at 08:44:34AM +0300, Dan Carpenter wrote:
> copy_to_user() returns the amount of data remaining to be copied. We
> want to return a negative error code here. The upper layers just
> call WARN_ON() if we return non-zero so this doesn't change the
> behavior. But returning -EFAULT is still cleaner.
Thank you. Will put it on rc1 train.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> index 017ce60..b0f9e8f 100644
> --- a/drivers/xen/gntdev.c
> +++ b/drivers/xen/gntdev.c
> @@ -273,7 +273,7 @@ static int __unmap_grant_pages(struct grant_map *map, int offset, int pages)
> map->vma->vm_start + map->notify.addr;
> err = copy_to_user(tmp, &err, 1);
> if (err)
> - return err;
> + return -EFAULT;
> map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE;
> } else if (pgno >= offset && pgno < offset + pages) {
> uint8_t *tmp = kmap(map->pages[pgno]);
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Xen-devel] [patch 1/2] xen-gntdev: return -EFAULT on copy_to_user failure
2011-03-19 5:44 ` Dan Carpenter
(?)
@ 2011-03-25 15:04 ` Konrad Rzeszutek Wilk
-1 siblings, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-03-25 15:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jeremy Fitzhardinge, kernel-janitors, xen-devel, virtualization
On Sat, Mar 19, 2011 at 08:44:34AM +0300, Dan Carpenter wrote:
> copy_to_user() returns the amount of data remaining to be copied. We
> want to return a negative error code here. The upper layers just
> call WARN_ON() if we return non-zero so this doesn't change the
> behavior. But returning -EFAULT is still cleaner.
Thank you. Will put it on rc1 train.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> index 017ce60..b0f9e8f 100644
> --- a/drivers/xen/gntdev.c
> +++ b/drivers/xen/gntdev.c
> @@ -273,7 +273,7 @@ static int __unmap_grant_pages(struct grant_map *map, int offset, int pages)
> map->vma->vm_start + map->notify.addr;
> err = copy_to_user(tmp, &err, 1);
> if (err)
> - return err;
> + return -EFAULT;
> map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE;
> } else if (pgno >= offset && pgno < offset + pages) {
> uint8_t *tmp = kmap(map->pages[pgno]);
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 1/2] xen-gntdev: return -EFAULT on copy_to_user failure
@ 2011-03-25 15:04 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-03-25 15:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jeremy Fitzhardinge, kernel-janitors, xen-devel, virtualization
On Sat, Mar 19, 2011 at 08:44:34AM +0300, Dan Carpenter wrote:
> copy_to_user() returns the amount of data remaining to be copied. We
> want to return a negative error code here. The upper layers just
> call WARN_ON() if we return non-zero so this doesn't change the
> behavior. But returning -EFAULT is still cleaner.
Thank you. Will put it on rc1 train.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> index 017ce60..b0f9e8f 100644
> --- a/drivers/xen/gntdev.c
> +++ b/drivers/xen/gntdev.c
> @@ -273,7 +273,7 @@ static int __unmap_grant_pages(struct grant_map *map, int offset, int pages)
> map->vma->vm_start + map->notify.addr;
> err = copy_to_user(tmp, &err, 1);
> if (err)
> - return err;
> + return -EFAULT;
> map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE;
> } else if (pgno >= offset && pgno < offset + pages) {
> uint8_t *tmp = kmap(map->pages[pgno]);
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-25 15:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-19 5:44 [patch 1/2] xen-gntdev: return -EFAULT on copy_to_user failure Dan Carpenter
2011-03-19 5:44 ` Dan Carpenter
2011-03-25 15:04 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-03-25 15:04 ` [Xen-devel] [patch 1/2] xen-gntdev: return -EFAULT on Konrad Rzeszutek Wilk
2011-03-25 15:04 ` [patch 1/2] xen-gntdev: return -EFAULT on copy_to_user failure Konrad Rzeszutek Wilk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.