[U-Boot] cfi_flash - bug with flash banks with different sector numbers

[U-Boot] cfi_flash - bug with flash banks with different sector numbers

[Martin Krause]

Hi list,

I encountered a problem with the cfi_flash driver on a board with
two flash banks with a different number of flash secotrs.

It seems that the function find_sector() which tries to speed up 
successive flash accesses does not take into account the current
flash bank correctly.

I created a patch with a fix (see blow), but since I do not
work with current U-Boot, this patch likely will not apply cleanly
to TOT (but is neccessary, since the bug is still present there).

Best regards,
Martin

[U-Boot] cfi_flash - bug with flash banks with different sector numbers

[Stefan Roese]

Hi Martin,

On Monday 21 March 2011 13:42:00 Martin Krause wrote:
> I encountered a problem with the cfi_flash driver on a board with
> two flash banks with a different number of flash secotrs.
> 
> It seems that the function find_sector() which tries to speed up
> successive flash accesses does not take into account the current
> flash bank correctly.
> 
> I created a patch with a fix (see blow), but since I do not
> work with current U-Boot, this patch likely will not apply cleanly
> to TOT (but is neccessary, since the bug is still present there).

First, the patch is line wrapped. Would it be possible for you to take the 
time to rebase it against TOT and send a non line wrapped version?

Thanks.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

[U-Boot] cfi_flash - bug with flash banks with different sector numbers

[Martin Krause]

Hi Stefan,

Stefan Roese wrote on Montag, 21. M?rz 2011 14:10:
> Hi Martin,
> 
> On Monday 21 March 2011 13:42:00 Martin Krause wrote:
>> I encountered a problem with the cfi_flash driver on a board with
>> two flash banks with a different number of flash secotrs.
>> 
>> It seems that the function find_sector() which tries to speed up
>> successive flash accesses does not take into account the current
>> flash bank correctly. 
>> 
>> I created a patch with a fix (see blow), but since I do not
>> work with current U-Boot, this patch likely will not apply cleanly
>> to TOT (but is neccessary, since the bug is still present there).
> 
> First, the patch is line wrapped. Would it be possible for

Oh, I forgot dumb M$ outlook.

> you to take the
> time to rebase it against TOT and send a non line wrapped version?

I will do, if the patch otherwise is OK. Since the computer my git 
repo is installed on has no direct connection to the internet, this 
is not as easy as it could be. And I will not be able to test the 
patched TOT U-Boot apart from compiling without errors.

Best regards,
Martin