From: Ingo Molnar <mingo@elte.hu>
To: James Bottomley <James.Bottomley@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [build failure] Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window
Date: Mon, 21 Mar 2011 18:59:34 +0100 [thread overview]
Message-ID: <20110321175934.GA4849@elte.hu> (raw)
In-Reply-To: <1300725211.10634.20.camel@mulgrave.site>
* James Bottomley <James.Bottomley@suse.de> wrote:
> On Mon, 2011-03-21 at 13:21 +0100, Ingo Molnar wrote:
> > * James Bottomley <James.Bottomley@suse.de> wrote:
> >
> > > This represents the usual round of driver updates (fcoe, lpfc,
> > qla2xxx, > zfcp, bnx2i, mpt2sas, megaraid_sas, iscsi, cxgbi and hpsa)
> > plus one new > driver (bnx2fc) and as a bonus we move libsas from the
> > old libata eh to > the new one paving the way for junking the old one
> > (once we can get ipr > converted).
> >
> > The new bnx2fc driver does not build with module support disabled:
> >
> > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815:17: error: dereferencing
> > pointer to incomplete type drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815:28:
> > error: ‘MODULE_STATE_LIVE’ undeclared (first use in this function)
> > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1878:17: error: dereferencing
> > pointer to incomplete type drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1878:28:
> > error: ‘MODULE_STATE_LIVE’ undeclared (first use in this function)
> >
> > and this build breakage has been reported to you two weeks ago:
> >
> > http://lkml.org/lkml/2011/3/2/468
>
> The actual fix is here:
>
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=e81460b20107ae83a7541d12b14114ea731a86fc
This too does the trick.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: James Bottomley <James.Bottomley@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [build failure] Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window
Date: Mon, 21 Mar 2011 18:59:34 +0100 [thread overview]
Message-ID: <20110321175934.GA4849@elte.hu> (raw)
In-Reply-To: <1300725211.10634.20.camel@mulgrave.site>
* James Bottomley <James.Bottomley@suse.de> wrote:
> On Mon, 2011-03-21 at 13:21 +0100, Ingo Molnar wrote:
> > * James Bottomley <James.Bottomley@suse.de> wrote:
> >
> > > This represents the usual round of driver updates (fcoe, lpfc,
> > qla2xxx, > zfcp, bnx2i, mpt2sas, megaraid_sas, iscsi, cxgbi and hpsa)
> > plus one new > driver (bnx2fc) and as a bonus we move libsas from the
> > old libata eh to > the new one paving the way for junking the old one
> > (once we can get ipr > converted).
> >
> > The new bnx2fc driver does not build with module support disabled:
> >
> > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815:17: error: dereferencing
> > pointer to incomplete type drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815:28:
> > error: ‘MODULE_STATE_LIVE’ undeclared (first use in this function)
> > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1878:17: error: dereferencing
> > pointer to incomplete type drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1878:28:
> > error: ‘MODULE_STATE_LIVE’ undeclared (first use in this function)
> >
> > and this build breakage has been reported to you two weeks ago:
> >
> > http://lkml.org/lkml/2011/3/2/468
>
> The actual fix is here:
>
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=e81460b20107ae83a7541d12b14114ea731a86fc
This too does the trick.
Thanks,
Ingo
next prev parent reply other threads:[~2011-03-21 17:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 20:10 [GIT PULL] First round of SCSI updates for 2.6.38 merge window James Bottomley
2011-03-17 20:10 ` James Bottomley
2011-03-17 21:19 ` Nicholas A. Bellinger
2011-03-19 20:00 ` Geert Uytterhoeven
2011-03-22 4:27 ` Martin K. Petersen
2011-03-22 4:27 ` Martin K. Petersen
2011-03-22 12:59 ` Jeff Moyer
2011-03-21 12:21 ` [build failure] " Ingo Molnar
2011-03-21 12:21 ` Ingo Molnar
2011-03-21 16:33 ` James Bottomley
2011-03-21 17:59 ` Ingo Molnar [this message]
2011-03-21 17:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321175934.GA4849@elte.hu \
--to=mingo@elte.hu \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.