All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 3/3] hwmon: (f71882fg) Document all
Date: Thu, 24 Mar 2011 03:38:16 +0000	[thread overview]
Message-ID: <20110324033816.GC15395@ericsson.com> (raw)
In-Reply-To: <20110323215004.5b9ab7b0@endymion.delvare>

On Wed, Mar 23, 2011 at 04:50:04PM -0400, Jean Delvare wrote:
> The list of supported devices was not always well documented in all
> places. Clarify and list all devices in documentation, Kconfig and
> the driver itself.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> ---
>  Documentation/hwmon/f71882fg |   11 +++++++++++
>  drivers/hwmon/Kconfig        |   14 +++++++++++---
>  drivers/hwmon/f71882fg.c     |    2 +-
>  3 files changed, 23 insertions(+), 4 deletions(-)
> 
[ ... ]
>  
>  config SENSORS_F71882FG
> -	tristate "Fintek F71858FG, F71862FG, F71882FG, F71889FG and F8000"
> +	tristate "Fintek F71882FG and compatibles"
>  	help
>  	  If you say yes here you get support for hardware monitoring
> -	  features of the Fintek F71858FG, F71862FG/71863FG, F71882FG/F71883FG,
> -	  F71889FG and F8000 Super-I/O chips.
> +	  features of many Fintek Super-I/O (LPC) chips. The currently
> +	  supported chips are:
> +	    F71808E
> +	    F71858FG
> +	    F71862FG and F71863FG
> +	    F71869F and F71869E
> +	    F71882FG and F71883FG
> +	    F71889FG and F81801U
> +	    F71889ED
> +	    F8000
>  
Why not just a simple list ? The grouping seems to be a bit arbitrary unless one knows
that the "and" chip IDs are the same - but users won't usually know that.

Nitpick, so

Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2011-03-24  3:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23 20:50 [lm-sensors] [PATCH 3/3] hwmon: (f71882fg) Document all supported Jean Delvare
2011-03-24  3:38 ` Guenter Roeck [this message]
2011-03-24  7:30 ` [lm-sensors] [PATCH 3/3] hwmon: (f71882fg) Document all Jean Delvare
2011-03-24  8:16 ` Hans de Goede
2011-03-24  9:52 ` Guenter Roeck
2011-03-24 13:57 ` Jean Delvare
2011-03-24 15:19 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110324033816.GC15395@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.