Re: [lm-sensors] [PATCH 3/3] hwmon: (f71882fg) Document all

[Guenter Roeck <guenter.roeck@ericsson.com>]

Hi Jean,

On Thu, Mar 24, 2011 at 09:57:20AM -0400, Jean Delvare wrote:
> On Thu, 24 Mar 2011 02:52:01 -0700, Guenter Roeck wrote:
> > Hi Jean,
> > 
> > On Thu, Mar 24, 2011 at 03:30:36AM -0400, Jean Delvare wrote:
> > > Hi Guenter,
> > > 
> > [ ... ]
> > >  
> > >  config SENSORS_F71882FG
> > > -	tristate "Fintek F71858FG, F71862FG, F71882FG, F71889FG and F8000"
> > > +	tristate "Fintek F71882FG and compatibles"
> > >  	help
> > >  	  If you say yes here you get support for hardware monitoring
> > > -	  features of the Fintek F71858FG, F71862FG/71863FG, F71882FG/F71883FG,
> > > -	  F71889FG and F8000 Super-I/O chips.
> > > +	  features of many Fintek Super-I/O (LPC) chips. The currently
> > > +	  supported chips are:
> > > +	    F71808E
> > > +	    F71858FG
> > > +	    F71862FG
> > > +	    F71863FG
> > > +	    F71869F/E
> > > +	    F71882FG
> > > +	    F71883FG
> > > +	    F71889FG/ED
> > > +	    F8000
> > > +	    F81801U
> > >  
> > I meant something like
> > 	    F71808E, F71858FG, F71862FG, F71863FG, F71869F/E, F71882FG,
> > 	    F71883FG, F71889FG/ED, F8000, F81801U
> > 
> > but yes, the above is ok as well.
> 
> I tend to prefer "vertical" lists because patches adding or removing
> items are much more readable. With "horizontal" lists, add an item near
> the beginning of the first line and everything else is shifted, and you
> have to check the diff very carefully.

Good point ... makes sense.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors