From: Olaf Hering <olaf@aepfle.de>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 1 of 5] xentrace: fix t_info_pages calculation for the default case
Date: Thu, 24 Mar 2011 17:03:27 +0100 [thread overview]
Message-ID: <20110324160327.GA27980@aepfle.de> (raw)
In-Reply-To: <1300981626.2648.33.camel@silas>
On Thu, Mar 24, George Dunlap wrote:
> Then it's really clear when looking at it what the inputs and outputs of
> each line is supposed to be.
George,
lets not overdo things. The formula I came up with, based on the initial
code, is even slightly incorrect. It may allocate more than needed.
Each cpu has some pages/mfns stored as uint32_t. That list is stored
with an offset at tinfo. So its more like:
num_online_cpus() * pages * sizeof(uint32_t) + t_info_first_offset;
And that number of bytes is now correctly converted to pages with
PFN_UP.
t_info_words = num_online_cpus() * pages * sizeof(uint32_t);
t_info_pages = PFN_UP(t_info_first_offset + t_info_words);
(Modulo things I missed.)
Olaf
next prev parent reply other threads:[~2011-03-24 16:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 17:54 [PATCH 0 of 5] xentrace updates Olaf Hering
2011-03-23 17:54 ` [PATCH 1 of 5] xentrace: fix t_info_pages calculation for the default case Olaf Hering
2011-03-24 12:09 ` Christoph Egger
2011-03-24 12:18 ` Christoph Egger
2011-03-24 12:34 ` Keir Fraser
2011-03-24 15:47 ` George Dunlap
2011-03-24 16:03 ` Olaf Hering [this message]
2011-03-24 16:04 ` Keir Fraser
2011-03-23 17:54 ` [PATCH 2 of 5] xentrace: print calculated numbers in calculate_tbuf_size() Olaf Hering
2011-03-23 17:54 ` [PATCH 3 of 5] xentrace: remove gdprintk usage since they are not in guest context Olaf Hering
2011-03-23 17:54 ` [PATCH 4 of 5] xentrace: update comments Olaf Hering
2011-03-23 17:54 ` [PATCH 5 of 5] xentrace: use consistent printk prefix Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2011-03-22 19:21 [PATCH 0 of 5] xentrace updates Olaf Hering
2011-03-22 19:21 ` [PATCH 1 of 5] xentrace: fix t_info_pages calculation for the default case Olaf Hering
2011-03-23 10:12 ` Jan Beulich
2011-03-23 10:22 ` Keir Fraser
2011-03-23 11:20 ` Olaf Hering
2011-03-23 12:33 ` Keir Fraser
2011-03-23 12:46 ` Olaf Hering
2011-03-23 14:56 ` George Dunlap
2011-03-23 12:45 ` Jan Beulich
2011-03-23 13:16 ` Olaf Hering
2011-03-23 13:35 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324160327.GA27980@aepfle.de \
--to=olaf@aepfle.de \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.