From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: NFS page states & writeback
Date: Sat, 26 Mar 2011 10:04:50 +1100 [thread overview]
Message-ID: <20110325230450.GR26611@dastard> (raw)
In-Reply-To: <20110325222458.GB26932@quack.suse.cz>
On Fri, Mar 25, 2011 at 11:24:58PM +0100, Jan Kara wrote:
> So I think we could stop doing writeback when we have done the transition
> of pages from Dirty to Writeback state. We should only make sure someone
> kicks the background writeback again when there are enough unstable pages
> to be worth a commit. This tends to happen from balance_dirty_pages() or
> in the worst case when flusher thread awakes to check for old inodes to
> flush. But we can also kick the flusher thread from NFS when we transition
> enough pages which would seem rather robust to me. I'll try to write a
> patch in this direction.
I think making the background writeback commits triggered by NFS
write completion is a good way to proceed. A write request
completion gives us a guaranteed context to determine if we need to
issue a commit or not and should mostly avoid the need for polling
or some external event to trigger a threshold check.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>
To: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Wu Fengguang
<fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: NFS page states & writeback
Date: Sat, 26 Mar 2011 10:04:50 +1100 [thread overview]
Message-ID: <20110325230450.GR26611@dastard> (raw)
In-Reply-To: <20110325222458.GB26932-+0h/O2h83AeN3ZZ/Hiejyg@public.gmane.org>
On Fri, Mar 25, 2011 at 11:24:58PM +0100, Jan Kara wrote:
> So I think we could stop doing writeback when we have done the transition
> of pages from Dirty to Writeback state. We should only make sure someone
> kicks the background writeback again when there are enough unstable pages
> to be worth a commit. This tends to happen from balance_dirty_pages() or
> in the worst case when flusher thread awakes to check for old inodes to
> flush. But we can also kick the flusher thread from NFS when we transition
> enough pages which would seem rather robust to me. I'll try to write a
> patch in this direction.
I think making the background writeback commits triggered by NFS
write completion is a good way to proceed. A write request
completion gives us a guaranteed context to determine if we need to
issue a commit or not and should mostly avoid the need for polling
or some external event to trigger a threshold check.
Cheers,
Dave.
--
Dave Chinner
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-25 23:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 1:28 NFS page states & writeback Jan Kara
2011-03-25 4:47 ` Dave Chinner
2011-03-25 7:11 ` Wu Fengguang
2011-03-25 7:11 ` Wu Fengguang
2011-03-25 22:24 ` Jan Kara
2011-03-25 22:24 ` Jan Kara
2011-03-25 23:04 ` Dave Chinner [this message]
2011-03-25 23:04 ` Dave Chinner
2011-03-25 7:00 ` Wu Fengguang
2011-03-25 9:39 ` Dave Chinner
2011-03-25 9:39 ` Dave Chinner
2011-03-25 14:22 ` Wu Fengguang
2011-03-25 14:22 ` Wu Fengguang
2011-03-25 14:32 ` Wu Fengguang
2011-03-25 18:26 ` Jan Kara
2011-03-25 18:26 ` Jan Kara
2011-03-25 22:55 ` Dave Chinner
2011-03-25 23:24 ` Jan Kara
2011-03-26 1:18 ` Dave Chinner
2011-03-27 15:26 ` Trond Myklebust
2011-03-28 0:23 ` Dave Chinner
2011-03-28 0:23 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110325230450.GR26611@dastard \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.