From: Dan Carpenter <error27@gmail.com>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Matt Carlson <mcarlson@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] tg3: Don't use IRQF_SAMPLE_RANDOM
Date: Sun, 27 Mar 2011 03:08:30 +0000 [thread overview]
Message-ID: <20110327030830.GF1885@bicker> (raw)
In-Reply-To: <1301193753-10045-2-git-send-email-martinez.javier@gmail.com>
On Sun, Mar 27, 2011 at 04:42:32AM +0200, Javier Martinez Canillas wrote:
> This flag is scheduled for removal so we shouldn't used it.
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
> drivers/net/tg3.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index c67eb19..58c6049 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -8844,12 +8844,11 @@ static int tg3_request_irq(struct tg3 *tp, int irq_num)
> fn = tg3_msi;
> if (tp->tg3_flags2 & TG3_FLG2_1SHOT_MSI)
> fn = tg3_msi_1shot;
> - flags = IRQF_SAMPLE_RANDOM;
You need initialize flags to zero here. Apparently gcc doesn't catch
this. I'm using gcc 4.4.3-4ubuntu5.
regards,
dan carpenter
v
> } else {
> fn = tg3_interrupt;
> if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS)
> fn = tg3_interrupt_tagged;
> - flags = IRQF_SHARED | IRQF_SAMPLE_RANDOM;
> + flags = IRQF_SHARED;
> }
>
> return request_irq(tnapi->irq_vec, fn, flags, name, tnapi);
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Matt Carlson <mcarlson@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] tg3: Don't use IRQF_SAMPLE_RANDOM
Date: Sun, 27 Mar 2011 06:08:30 +0300 [thread overview]
Message-ID: <20110327030830.GF1885@bicker> (raw)
In-Reply-To: <1301193753-10045-2-git-send-email-martinez.javier@gmail.com>
On Sun, Mar 27, 2011 at 04:42:32AM +0200, Javier Martinez Canillas wrote:
> This flag is scheduled for removal so we shouldn't used it.
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
> drivers/net/tg3.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index c67eb19..58c6049 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -8844,12 +8844,11 @@ static int tg3_request_irq(struct tg3 *tp, int irq_num)
> fn = tg3_msi;
> if (tp->tg3_flags2 & TG3_FLG2_1SHOT_MSI)
> fn = tg3_msi_1shot;
> - flags = IRQF_SAMPLE_RANDOM;
You need initialize flags to zero here. Apparently gcc doesn't catch
this. I'm using gcc 4.4.3-4ubuntu5.
regards,
dan carpenter
v
> } else {
> fn = tg3_interrupt;
> if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS)
> fn = tg3_interrupt_tagged;
> - flags = IRQF_SHARED | IRQF_SAMPLE_RANDOM;
> + flags = IRQF_SHARED;
> }
>
> return request_irq(tnapi->irq_vec, fn, flags, name, tnapi);
next prev parent reply other threads:[~2011-03-27 3:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-27 2:42 [PATCH 1/3] tg3: use <linux/io.h> and <linux/uaccess.h> instead <asm/io.h> and <asm/uaccess.h> Javier Martinez Canillas
2011-03-27 2:42 ` Javier Martinez Canillas
2011-03-27 2:42 ` [PATCH 2/3] tg3: Don't use IRQF_SAMPLE_RANDOM Javier Martinez Canillas
2011-03-27 2:42 ` Javier Martinez Canillas
2011-03-27 3:08 ` Dan Carpenter [this message]
2011-03-27 3:08 ` Dan Carpenter
2011-03-28 1:38 ` David Miller
2011-03-28 1:38 ` David Miller
2011-03-27 2:42 ` [PATCH 3/3] tg3: Fix inline keyword usage Javier Martinez Canillas
2011-03-27 2:42 ` Javier Martinez Canillas
2011-03-28 1:39 ` David Miller
2011-03-28 1:39 ` David Miller
2011-03-28 1:38 ` [PATCH 1/3] tg3: use <linux/io.h> and <linux/uaccess.h> David Miller
2011-03-28 1:38 ` [PATCH 1/3] tg3: use <linux/io.h> and <linux/uaccess.h> instead <asm/io.h> and <asm/uaccess.h> David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110327030830.GF1885@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.