From: Lu Guanqun <guanqun.lu@intel.com>
To: Arjan van de Ven <arjan@linux.intel.com>,
Jeff Cheng <jeff_cheng@wistron.com>
Cc: "meego-kernel@lists.meego.com" <meego-kernel@lists.meego.com>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"Wu, Fengguang" <fengguang.wu@intel.com>,
"Tang, Feng" <feng.tang@intel.com>,
"Fu, Michael" <michael.fu@intel.com>,
"Wang, Xingchao" <xingchao.wang@intel.com>,
"Koul, Vinod" <vinod.koul@intel.com>,
"Kp, Jeeja" <jeeja.kp@intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
"Babu, Ramesh" <ramesh.babu@intel.com>,
"R, Dharageswari" <dharageswari.r@intel.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line
Date: Mon, 28 Mar 2011 10:53:13 +0800 [thread overview]
Message-ID: <20110328025313.GF12596@qtel.sh.intel.com> (raw)
In-Reply-To: <4D8FF3F8.6000003@linux.intel.com>
On Mon, Mar 28, 2011 at 10:35:36AM +0800, Arjan van de Ven wrote:
> On 3/27/2011 7:29 PM, Lu Guanqun wrote:
> >
> > pr_debug("sst: powering dn nc_power_down ....\n");
> >
> > + if (snd_pmic_ops_nc.output_dev_id == MONO_EARPIECE ||
> > + snd_pmic_ops_nc.output_dev_id == INTERNAL_SPKR) {
> > + msleep(30);
> > + nc_set_amp_power(0);
> > + }
> > msleep(30);
>
> this double msleep sounds rather harsh... why do we need two of these ?
> (heck... why do we need ONE ?)
>
This is legacy code from Jeff Cheng's patch.
Jeff, could you provide some information on this line?
--
guanqun
next prev parent reply other threads:[~2011-03-28 2:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1301279360-9839-1-git-send-email-guanqun.lu@intel.com>
2011-03-28 2:29 ` [PATCH v9 1/2] mrst: export get_gpio_by_name() function Lu Guanqun
2011-03-28 2:34 ` Arjan van de Ven
2011-03-28 2:47 ` Feng Tang
2011-03-28 2:47 ` Arjan van de Ven
2011-03-28 2:59 ` Lu Guanqun
2011-03-28 3:00 ` Feng Tang
2011-03-28 3:00 ` [Meego-kernel] " Arjan van de Ven
2011-03-28 3:12 ` Feng Tang
2011-03-28 9:46 ` Alan Cox
2011-03-28 5:50 ` Greg KH
2011-03-28 6:25 ` Feng Tang
2011-03-28 2:29 ` [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line Lu Guanqun
2011-03-28 2:35 ` Arjan van de Ven
2011-03-28 2:53 ` Lu Guanqun [this message]
2011-03-28 3:19 ` Jeff_Cheng
2011-03-28 5:51 ` Greg KH
2011-03-28 16:18 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328025313.GF12596@qtel.sh.intel.com \
--to=guanqun.lu@intel.com \
--cc=alan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dharageswari.r@intel.com \
--cc=feng.tang@intel.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@suse.de \
--cc=jeeja.kp@intel.com \
--cc=jeff_cheng@wistron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meego-kernel@lists.meego.com \
--cc=michael.fu@intel.com \
--cc=ramesh.babu@intel.com \
--cc=vinod.koul@intel.com \
--cc=xingchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.