From: Alan Cox <alan@linux.intel.com>
To: Lu Guanqun <guanqun.lu@intel.com>
Cc: meego-kernel@lists.meego.com, arjan@linux.intel.com,
fengguang.wu@intel.com, feng.tang@intel.com,
michael.fu@intel.com, xingchao.wang@intel.com,
vinod.koul@intel.com, jeeja.kp@intel.com,
Jeff Cheng <jeff_cheng@wistron.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Ramesh Babu K V <ramesh.babu@intel.com>,
Dharageswari R <dharageswari.r@intel.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line
Date: Mon, 28 Mar 2011 17:18:49 +0100 [thread overview]
Message-ID: <20110328171849.76243726@bob.linux.org.uk> (raw)
In-Reply-To: <1301279360-9839-3-git-send-email-guanqun.lu@intel.com>
On Mon, 28 Mar 2011 10:29:20 +0800
Lu Guanqun <guanqun.lu@intel.com> wrote:
> This patch originates from Jeff Cheng's patch to enable the internal
> speaker.
>
> On Moorestown platform, internal speaker's power line is connected to
> a GPIO line, this information is got from SFI GPIO table, so we need
> set it to 1 to enable the internal speaker, or set it to 0 to disable
> it.
>
> When we set the output device, we power on or off the internal
> speaker on demand.
This one looks fine to me - just need to figure out the right way to
get the GPIO pin. Really for a PCI device it ought to be coming from
the PCI space. I will talk to Arjan and co about it.
Alan
prev parent reply other threads:[~2011-03-28 16:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1301279360-9839-1-git-send-email-guanqun.lu@intel.com>
2011-03-28 2:29 ` [PATCH v9 1/2] mrst: export get_gpio_by_name() function Lu Guanqun
2011-03-28 2:34 ` Arjan van de Ven
2011-03-28 2:47 ` Feng Tang
2011-03-28 2:47 ` Arjan van de Ven
2011-03-28 2:59 ` Lu Guanqun
2011-03-28 3:00 ` Feng Tang
2011-03-28 3:00 ` [Meego-kernel] " Arjan van de Ven
2011-03-28 3:12 ` Feng Tang
2011-03-28 9:46 ` Alan Cox
2011-03-28 5:50 ` Greg KH
2011-03-28 6:25 ` Feng Tang
2011-03-28 2:29 ` [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line Lu Guanqun
2011-03-28 2:35 ` Arjan van de Ven
2011-03-28 2:53 ` Lu Guanqun
2011-03-28 3:19 ` Jeff_Cheng
2011-03-28 5:51 ` Greg KH
2011-03-28 16:18 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328171849.76243726@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dharageswari.r@intel.com \
--cc=feng.tang@intel.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@suse.de \
--cc=guanqun.lu@intel.com \
--cc=jeeja.kp@intel.com \
--cc=jeff_cheng@wistron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meego-kernel@lists.meego.com \
--cc=michael.fu@intel.com \
--cc=ramesh.babu@intel.com \
--cc=vinod.koul@intel.com \
--cc=xingchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.