From: Andrew Morton <akpm@linux-foundation.org>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mundt <lethal@linux-sh.org>,
David Howells <dhowells@redhat.com>,
Greg Ungerer <gerg@snapgear.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/RFT 0/6] nommu: improve the vma list handling
Date: Mon, 28 Mar 2011 15:01:02 -0700 [thread overview]
Message-ID: <20110328150102.11bcfca8.akpm@linux-foundation.org> (raw)
In-Reply-To: <1301320607-7259-1-git-send-email-namhyung@gmail.com>
On Mon, 28 Mar 2011 22:56:41 +0900
Namhyung Kim <namhyung@gmail.com> wrote:
> When I was reading nommu code, I found that it handles the vma list/tree in
> an unusual way. IIUC, because there can be more than one identical/overrapped
> vmas in the list/tree, it sorts the tree more strictly and does a linear
> search on the tree. But it doesn't applied to the list (i.e. the list could
> be constructed in a different order than the tree so that we can't use the
> list when finding the first vma in that order).
>
> Since inserting/sorting a vma in the tree and link is done at the same time,
> we can easily construct both of them in the same order. And linear searching
> on the tree could be more costly than doing it on the list, it can be
> converted to use the list.
>
> Also, after the commit 297c5eee3724 ("mm: make the vma list be doubly linked")
> made the list be doubly linked, there were a couple of code need to be fixed
> to construct the list properly.
>
> Patch 1/6 is a preparation. It maintains the list sorted same as the tree and
> construct doubly-linked list properly. Patch 2/6 is a simple optimization for
> the vma deletion. Patch 3/6 and 4/6 convert tree traversal to list traversal
> and the rest are simple fixes and cleanups.
>
> Note that I don't have a system to test on, so these are *totally untested*
> patches. There could be some basic errors in the code. In that case, please
> kindly let me know. :)
>
> Anyway, I just compiled them on my x86_64 desktop using this command:
>
> make mm/nommu.o
>
> (Of course this required few of dirty-fixes to proceed)
>
> Also note that these are on top of v2.6.38.
>
> Any comments are welcome.
That seems like a nice set of changes. There isn't much I can do with
them at this tims - hopefully some of the nommu people will be able to
find time to review and test the patches.
(Is there a way in which one can run a nommu kernel on a regular PC? Under
an emulator?)
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mundt <lethal@linux-sh.org>,
David Howells <dhowells@redhat.com>,
Greg Ungerer <gerg@snapgear.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/RFT 0/6] nommu: improve the vma list handling
Date: Mon, 28 Mar 2011 15:01:02 -0700 [thread overview]
Message-ID: <20110328150102.11bcfca8.akpm@linux-foundation.org> (raw)
In-Reply-To: <1301320607-7259-1-git-send-email-namhyung@gmail.com>
On Mon, 28 Mar 2011 22:56:41 +0900
Namhyung Kim <namhyung@gmail.com> wrote:
> When I was reading nommu code, I found that it handles the vma list/tree in
> an unusual way. IIUC, because there can be more than one identical/overrapped
> vmas in the list/tree, it sorts the tree more strictly and does a linear
> search on the tree. But it doesn't applied to the list (i.e. the list could
> be constructed in a different order than the tree so that we can't use the
> list when finding the first vma in that order).
>
> Since inserting/sorting a vma in the tree and link is done at the same time,
> we can easily construct both of them in the same order. And linear searching
> on the tree could be more costly than doing it on the list, it can be
> converted to use the list.
>
> Also, after the commit 297c5eee3724 ("mm: make the vma list be doubly linked")
> made the list be doubly linked, there were a couple of code need to be fixed
> to construct the list properly.
>
> Patch 1/6 is a preparation. It maintains the list sorted same as the tree and
> construct doubly-linked list properly. Patch 2/6 is a simple optimization for
> the vma deletion. Patch 3/6 and 4/6 convert tree traversal to list traversal
> and the rest are simple fixes and cleanups.
>
> Note that I don't have a system to test on, so these are *totally untested*
> patches. There could be some basic errors in the code. In that case, please
> kindly let me know. :)
>
> Anyway, I just compiled them on my x86_64 desktop using this command:
>
> make mm/nommu.o
>
> (Of course this required few of dirty-fixes to proceed)
>
> Also note that these are on top of v2.6.38.
>
> Any comments are welcome.
That seems like a nice set of changes. There isn't much I can do with
them at this tims - hopefully some of the nommu people will be able to
find time to review and test the patches.
(Is there a way in which one can run a nommu kernel on a regular PC? Under
an emulator?)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-28 22:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 13:56 [RFC/RFT 0/6] nommu: improve the vma list handling Namhyung Kim
2011-03-28 13:56 ` Namhyung Kim
2011-03-28 13:56 ` [PATCH 1/6] nommu: sort mm->mmap list properly Namhyung Kim
2011-03-28 13:56 ` Namhyung Kim
2011-03-31 18:51 ` Andrew Morton
2011-03-31 18:51 ` Andrew Morton
2011-04-01 1:10 ` Namhyung Kim
2011-04-01 1:10 ` Namhyung Kim
2011-03-28 13:56 ` [PATCH 2/6] nommu: don't scan the vma list when deleting Namhyung Kim
2011-03-28 13:56 ` Namhyung Kim
2011-03-28 13:56 ` [PATCH 3/6] nommu: find vma using the sorted vma list Namhyung Kim
2011-03-28 13:56 ` Namhyung Kim
2011-03-28 13:56 ` [PATCH 4/6] nommu: check the vma list when unmapping file-mapped vma Namhyung Kim
2011-03-28 13:56 ` Namhyung Kim
2011-03-28 13:56 ` [PATCH 5/6] nommu: fix a potential memory leak in do_mmap_private() Namhyung Kim
2011-03-28 13:56 ` Namhyung Kim
2011-03-28 13:56 ` [PATCH 6/6] nommu: fix a compile warning in do_mmap_pgoff() Namhyung Kim
2011-03-28 13:56 ` Namhyung Kim
2011-03-28 22:01 ` Andrew Morton [this message]
2011-03-28 22:01 ` [RFC/RFT 0/6] nommu: improve the vma list handling Andrew Morton
2011-03-31 4:56 ` Greg Ungerer
2011-03-31 4:56 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328150102.11bcfca8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=gerg@snapgear.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.