From: Chris Leech <christopher.leech@linux.intel.com>
To: Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] kexec, x86: fix kexec when boot_params.hardware_subarch != 0
Date: Mon, 28 Mar 2011 14:45:57 -0700 [thread overview]
Message-ID: <20110328214557.GA5670@cleech-lnx.jf.intel.com> (raw)
In-Reply-To: <20110328214012.GH4716@verge.net.au>
On Tue, Mar 29, 2011 at 06:40:12AM +0900, Simon Horman wrote:
> > +void setup_subarch(struct x86_linux_param_header *real_mode)
> > +{
> > + int data_file;
> > + const off_t offset = offsetof(typeof(*real_mode), hardware_subarch);
> > +
> > + data_file = open(BOOT_PARAMS_DBGFS, O_RDONLY);
> > + if (data_file < 0)
> > + return;
> > + if (lseek(data_file, offset, SEEK_SET) < 0)
> > + goto close;
> > + read(data, &real_mode->hardware_subarch, sizeof(uint32_t));
>
> Should data be data_file?
Yes. Sorry, looks like I sent an unrefreshed patch.
- Chris
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2011-03-28 21:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 19:40 [PATCH] kexec, x86: fix kexec when boot_params.hardware_subarch != 0 Chris Leech
2011-03-28 21:40 ` Simon Horman
2011-03-28 21:45 ` Chris Leech [this message]
2011-03-28 21:50 ` [PATCH V2] " Chris Leech
2011-03-28 22:19 ` Simon Horman
2011-03-29 9:04 ` WANG Cong
2011-03-29 23:22 ` Simon Horman
2011-03-31 17:21 ` Chris Leech
2011-04-01 2:00 ` [PATCH V2] kexec, x86: fix kexec when?boot_params.hardware_subarch " Simon Horman
2011-04-27 6:18 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328214557.GA5670@cleech-lnx.jf.intel.com \
--to=christopher.leech@linux.intel.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.