All of lore.kernel.org
 help / color / mirror / Atom feed
From: WANG Cong <xiyou.wangcong@gmail.com>
To: kexec@lists.infradead.org
Subject: Re: [PATCH V2] kexec, x86: fix kexec when boot_params.hardware_subarch != 0
Date: Tue, 29 Mar 2011 09:04:53 +0000 (UTC)	[thread overview]
Message-ID: <ims7bl$ik5$1@dough.gmane.org> (raw)
In-Reply-To: 20110328215011.30400.91252.stgit@localhost6.localdomain6

On Mon, 28 Mar 2011 14:50:11 -0700, Chris Leech wrote:

> kexec needs to keep the subarch setting the same as the running kernel
> in the boot parameters, or the kernel will die in early setup.  I ran
> into this with X86_SUBARCH_MRST, but it should apply to CE4100 and any
> future subarch that uses non-default early setup code.
> 
> This patch requires debugfs mounted at /sys/kernel/debug, as that's the
> only way I know of to get at the running kernels boot_params. Without
> debugfs mounted it falls back to the current behavior of assuming
> subarch 0.
> 
...
>  
> +#define BOOT_PARAMS_DBGFS	"/sys/kernel/debug/boot_params/data"

A minor issue here is that you are using a hard-coded debugfs path,
debugfs can be also mounted to /debug too, so it is better that if we can 
search the path dynamically here.

Thanks.


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2011-03-29  9:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28 19:40 [PATCH] kexec, x86: fix kexec when boot_params.hardware_subarch != 0 Chris Leech
2011-03-28 21:40 ` Simon Horman
2011-03-28 21:45   ` Chris Leech
2011-03-28 21:50 ` [PATCH V2] " Chris Leech
2011-03-28 22:19   ` Simon Horman
2011-03-29  9:04   ` WANG Cong [this message]
2011-03-29 23:22     ` Simon Horman
2011-03-31 17:21       ` Chris Leech
2011-04-01  2:00         ` [PATCH V2] kexec, x86: fix kexec when?boot_params.hardware_subarch " Simon Horman
2011-04-27  6:18           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ims7bl$ik5$1@dough.gmane.org' \
    --to=xiyou.wangcong@gmail.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.