From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] s3c2440: mini2440: Enable the backlight LED earlier at boot time.
Date: Tue, 29 Mar 2011 11:50:31 +0300 [thread overview]
Message-ID: <201103291150.32097.anarsoul@gmail.com> (raw)
In-Reply-To: <1301380363-3282-5-git-send-email-marek.belisko@open-nandra.com>
On Tuesday 29 March 2011 09:32:43 Marek Belisko wrote:
> Code overtaken from:
> http://repo.or.cz/w/linux-2.6/mini2440.git
>
> Use flag that allows s3c24xx LED to start in the "on" state.
> This is necesary to enable LCD backlight during early boot stage.
Why are you still using leds-s3c24xx driver? mini2440 should work OK with
leds-gpio. Anyway, looks like patch should be splitted into 2 patches: first
adds flag to leds-s3c24xx driver, second enables this flag for mini2440.
Regards
Vasily
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> Signed-off-by: Michel Pollet <buserror@gmail.com>
> ---
> arch/arm/mach-s3c2410/include/mach/leds-gpio.h | 1 +
> arch/arm/mach-s3c2440/mach-mini2440.c | 1 +
> drivers/leds/leds-s3c24xx.c | 6 +++++-
> 3 files changed, 7 insertions(+), 1 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Vasily Khoruzhick <anarsoul@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Marek Belisko <marek.belisko@open-nandra.com>,
ben-linux@fluff.org, linux@arm.linux.org.uk,
linux-kernel@vger.kernel.org, rpurdie@rpsys.net,
buserror@gmail.com, esta1ien@gmail.com
Subject: Re: [PATCH 4/4] s3c2440: mini2440: Enable the backlight LED earlier at boot time.
Date: Tue, 29 Mar 2011 11:50:31 +0300 [thread overview]
Message-ID: <201103291150.32097.anarsoul@gmail.com> (raw)
In-Reply-To: <1301380363-3282-5-git-send-email-marek.belisko@open-nandra.com>
On Tuesday 29 March 2011 09:32:43 Marek Belisko wrote:
> Code overtaken from:
> http://repo.or.cz/w/linux-2.6/mini2440.git
>
> Use flag that allows s3c24xx LED to start in the "on" state.
> This is necesary to enable LCD backlight during early boot stage.
Why are you still using leds-s3c24xx driver? mini2440 should work OK with
leds-gpio. Anyway, looks like patch should be splitted into 2 patches: first
adds flag to leds-s3c24xx driver, second enables this flag for mini2440.
Regards
Vasily
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> Signed-off-by: Michel Pollet <buserror@gmail.com>
> ---
> arch/arm/mach-s3c2410/include/mach/leds-gpio.h | 1 +
> arch/arm/mach-s3c2440/mach-mini2440.c | 1 +
> drivers/leds/leds-s3c24xx.c | 6 +++++-
> 3 files changed, 7 insertions(+), 1 deletions(-)
next prev parent reply other threads:[~2011-03-29 8:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 6:32 [PATCH 0/4] s3c2440: mini2440: Add missing code parts to be fully working with latest kernel Marek Belisko
2011-03-29 6:32 ` Marek Belisko
2011-03-29 6:32 ` [PATCH 1/4] s3c2440: mini2440: Add support for new LCD panels Marek Belisko
2011-03-29 6:32 ` Marek Belisko
2011-03-29 6:32 ` [PATCH 2/4] s3c2440: mini2440: Add touchscreen support for mini2440 Marek Belisko
2011-03-29 6:32 ` Marek Belisko
2011-03-29 6:32 ` [PATCH 3/4] s3c2440: mini2440: Select touchscreen by default Marek Belisko
2011-03-29 6:32 ` Marek Belisko
2011-03-29 6:32 ` [PATCH 4/4] s3c2440: mini2440: Enable the backlight LED earlier at boot time Marek Belisko
2011-03-29 6:32 ` Marek Belisko
2011-03-29 8:50 ` Vasily Khoruzhick [this message]
2011-03-29 8:50 ` Vasily Khoruzhick
2011-03-29 8:55 ` Belisko Marek
2011-03-29 8:55 ` Belisko Marek
2011-03-29 9:53 ` [PATCH] s3c2440: mini2440: Use leds-gpio driver for board leds handling Marek Belisko
2011-03-29 9:53 ` Marek Belisko
2011-03-29 9:59 ` Belisko Marek
2011-03-29 9:59 ` Belisko Marek
2011-03-29 12:58 ` Vasily Khoruzhick
2011-03-29 12:58 ` Vasily Khoruzhick
2011-03-29 7:20 ` [PATCH 0/4] s3c2440: mini2440: Add missing code parts to be fully working with latest kernel M P
2011-03-29 7:20 ` M P
2011-03-29 7:23 ` Belisko Marek
2011-03-29 7:23 ` Belisko Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103291150.32097.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.