From: Andrew Morton <akpm@linux-foundation.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>, linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH]mmap: add alignment for some variables
Date: Tue, 29 Mar 2011 15:24:34 -0700 [thread overview]
Message-ID: <20110329152434.d662706f.akpm@linux-foundation.org> (raw)
In-Reply-To: <1301360054.3981.31.camel@sli10-conroe>
On Tue, 29 Mar 2011 08:54:14 +0800
Shaohua Li <shaohua.li@intel.com> wrote:
> -struct percpu_counter vm_committed_as;
> +struct percpu_counter vm_committed_as ____cacheline_internodealigned_in_smp;
Why ____cacheline_internodealigned_in_smp? That's pretty aggressive.
afacit the main benefit from this will occur if the read-only
vm_committed_as.counters lands in the same cacheline as some
write-frequently storage.
But that's a complete mad guess and I'd prefer not to have to guess.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>, linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH]mmap: add alignment for some variables
Date: Tue, 29 Mar 2011 15:24:34 -0700 [thread overview]
Message-ID: <20110329152434.d662706f.akpm@linux-foundation.org> (raw)
In-Reply-To: <1301360054.3981.31.camel@sli10-conroe>
On Tue, 29 Mar 2011 08:54:14 +0800
Shaohua Li <shaohua.li@intel.com> wrote:
> -struct percpu_counter vm_committed_as;
> +struct percpu_counter vm_committed_as ____cacheline_internodealigned_in_smp;
Why ____cacheline_internodealigned_in_smp? That's pretty aggressive.
afacit the main benefit from this will occur if the read-only
vm_committed_as.counters lands in the same cacheline as some
write-frequently storage.
But that's a complete mad guess and I'd prefer not to have to guess.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-29 22:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 1:58 [PATCH]mmap: add alignment for some variables Shaohua Li
2011-03-28 1:58 ` Shaohua Li
2011-03-28 16:55 ` Andi Kleen
2011-03-28 16:55 ` Andi Kleen
2011-03-29 0:54 ` Shaohua Li
2011-03-29 0:54 ` Shaohua Li
2011-03-29 22:24 ` Andrew Morton [this message]
2011-03-29 22:24 ` Andrew Morton
2011-03-29 22:38 ` Christoph Lameter
2011-03-29 22:38 ` Christoph Lameter
2011-03-30 1:01 ` Shaohua Li
2011-03-30 1:01 ` Shaohua Li
2011-03-30 1:06 ` Andrew Morton
2011-03-30 1:06 ` Andrew Morton
2011-03-30 1:17 ` Shaohua Li
2011-03-30 1:17 ` Shaohua Li
2011-03-30 1:25 ` Andrew Morton
2011-03-30 1:25 ` Andrew Morton
2011-03-30 1:36 ` Shaohua Li
2011-03-30 1:36 ` Shaohua Li
2011-03-30 1:41 ` Andrew Morton
2011-03-30 1:41 ` Andrew Morton
2011-03-30 1:54 ` Shaohua Li
2011-03-30 1:54 ` Shaohua Li
2011-03-30 2:10 ` Andrew Morton
2011-03-30 2:10 ` Andrew Morton
2011-03-30 2:35 ` Shaohua Li
2011-03-30 2:35 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329152434.d662706f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.