From: Arnd Bergmann <arnd@arndb.de>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable
Date: Tue, 29 Mar 2011 14:42:49 +0000 [thread overview]
Message-ID: <201103291642.49555.arnd@arndb.de> (raw)
In-Reply-To: <019701cbee1e$c4e2d260$4ea87720$@mprc.pku.edu.cn>
On Tuesday 29 March 2011, Guan Xuetao wrote:
>
> 1. make videomemory kmalloc-ed in fb-puv3.c
> 2. remove resource reservation for old fixed UNIGFX_MMAP & UVC_MMAP space
> 3. remove unused PKUNTIY_UNIGFX_MMAP_BASE, PKUNITY_UNIGFX_MMAP_SIZE,
> PKUNITY_UVC_MMAP_BASE, PKUNITY_UVC_MMAP_SIZE and KUSER_UNIGFX_BASE
> 4. remove unused header linux/vmalloc.h in fb-puv3.c
>
> Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
How does this work? UNIFB_MEMSIZE seems to be 4 MB, much more than the
maximum of 128 KB that kmalloc can allocate.
Shouldn't this use get_free_pages() instead of kmalloc?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Guan Xuetao" <gxt@mprc.pku.edu.cn>
Cc: "Paul Mundt" <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable
Date: Tue, 29 Mar 2011 16:42:49 +0200 [thread overview]
Message-ID: <201103291642.49555.arnd@arndb.de> (raw)
In-Reply-To: <019701cbee1e$c4e2d260$4ea87720$@mprc.pku.edu.cn>
On Tuesday 29 March 2011, Guan Xuetao wrote:
>
> 1. make videomemory kmalloc-ed in fb-puv3.c
> 2. remove resource reservation for old fixed UNIGFX_MMAP & UVC_MMAP space
> 3. remove unused PKUNTIY_UNIGFX_MMAP_BASE, PKUNITY_UNIGFX_MMAP_SIZE,
> PKUNITY_UVC_MMAP_BASE, PKUNITY_UVC_MMAP_SIZE and KUSER_UNIGFX_BASE
> 4. remove unused header linux/vmalloc.h in fb-puv3.c
>
> Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
How does this work? UNIFB_MEMSIZE seems to be 4 MB, much more than the
maximum of 128 KB that kmalloc can allocate.
Shouldn't this use get_free_pages() instead of kmalloc?
Arnd
next prev parent reply other threads:[~2011-03-29 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 14:37 [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable Guan Xuetao
2011-03-29 14:37 ` Guan Xuetao
2011-03-29 14:42 ` Arnd Bergmann [this message]
2011-03-29 14:42 ` Arnd Bergmann
2011-03-29 14:54 ` Guan Xuetao
2011-03-29 14:54 ` Guan Xuetao
2011-03-30 1:39 ` Guan Xuetao
2011-03-30 1:39 ` Guan Xuetao
2011-03-30 6:54 ` Arnd Bergmann
2011-03-30 6:54 ` Arnd Bergmann
2011-03-30 8:43 ` Guan Xuetao
2011-03-30 8:43 ` Guan Xuetao
2011-03-30 10:55 ` Arnd Bergmann
2011-03-30 10:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103291642.49555.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gxt@mprc.pku.edu.cn \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.