[PATCH v2 1/1] ARM: imx: add gpu device

[u.kleine-koenig@pengutronix.de (Uwe Kleine-König)]

Hello,

On Wed, Mar 30, 2011 at 05:03:45PM +0800, Eric Miao wrote:
> >> > @@ -203,6 +205,7 @@ static void __init mx35_3ds_init(void)
> >> > ? ? ? ? ? ? pr_warn("Init of the debugboard failed, all "
> >> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? "devices on the debugboard are unusable.\n");
> >> > ? ? imx35_add_imx_i2c0(&mx35_3ds_i2c0_data);
> >> > + ? imx35_add_mxc_gpu(&z160_revision);
> >> Do you really need to pass this by pointer? Wouldn't
> >> imx35_add_mxc_gpu(0) be good enough?
> > It's because sometimes z160_revision has different values with different
> > TO versions and z160_revision will be dup as plat data.
Yeah, I got that. I just meant how imx_add_mxc_gpu works. Just let it
take a int (instead of an int *) and pass the address of the local
parameter to imx_add_platform_device_dmamask.
 
> This is where platform_device_id comes into play, at least by registering
> device with different names, e.g. 'imx35-gpu' or 'imx51-gpu', and the
> driver can handle.
> 
> Difference between steppings is a bit tricky though, I think a QUIRK_
> way, and pass combined QUIRK_* flags will be better in imx35_add_mxc_gpu()
> function itself.
... or that

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |